[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24877.
---------------------------------
Resolution: Done
pushed
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.5.1.AM2
>
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24877:
-------------------------------------
I really wanted to debug this bc it meant the detector is behaving badly. I added a few more checks, specifically, the cdk3 detector shouldn't return true unless a folder has a "cdk" file, a "config" folder, and a "config/config.json" file.
To be clear, my checks aren't specific to file or folders, so it can be tricked. So please don't open a bug by intentionally tricking it ;) We're doing light validation here.
Anyway, I've created https://github.com/jbosstools/jbosstools-openshift/pull/1553 with a fix.
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.5.1.AM2
>
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24802) Connection wizard: Lots of unnecessary errors in Error Log when filling oc location, Finish enabled even if oc location empty
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24802?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24802:
-------------------------------------
It wasn't merged "by mistake" ;) It was merged because it fixed the issue and you were away =P But yeah, it's not clean code just yet
> Connection wizard: Lots of unnecessary errors in Error Log when filling oc location, Finish enabled even if oc location empty
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24802
> URL: https://issues.jboss.org/browse/JBIDE-24802
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Radim Hopp
> Assignee: Rob Stryker
> Priority: Minor
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.1.AM2
>
> Attachments: Spectacle.F10835.png
>
>
> On-the-fly validation of "oc location" field in ConnectionWizardPage puts lot of errors into error log. I think that the on the fly validation should not be so agressive.
> !Spectacle.F10835.png!
> And another thing: Is there any reason why Finish is enabled even when there is not valid value in oc location field?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24893) Feature Request - Development tools - eclipse launch configurations should be possible to be inferred from domain home
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24893?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24893:
-------------------------------------
Hi [~nuno.godinhomatos]
Not to be pedantic, but, could you elaborate with clear steps your process, with a step for where it could be improved? I'm a bit confused what you mean by "create a new domain". Are you creating a new domain in domain-mode? Or are you using some slang for a new configuration that's similar to standalone?
It'd be great if I could get clear step-by-step instructions as to your current process, so I can ivnestigate whether we can improve it for you.
> Feature Request - Development tools - eclipse launch configurations should be possible to be inferred from domain home
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24893
> URL: https://issues.jboss.org/browse/JBIDE-24893
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: integration-platform, server
> Affects Versions: 4.5.0.Final
> Reporter: Nuno Godinho de Matos
> Assignee: Tomaz Cerar
> Priority: Optional
>
> Hi,
> I believe that eclipse development with wildfly is quite cumbersome at the moment of defining a new wildfly domain runtime, in particular in regard to the resutilng "open launch configurations".
> When we consider what happens with weblogic domains, they normally all have a dedicated bin/ folder.
> I do the same thing when a create a fresh new wildfly domain, i enrich it with an additional bin/ folder where I pump in scripts to start/stop etc.. the domain.
> Where in particular, the start script is created with properties like java options that matter to our deployments.
> Weblogic start plugin uses the startWeblogic.cmd in the bin folder.
> Naturally, this does not happen on Wildfly because the concept for the bin scripts is different. They are generic and domain independent.
> But It would in any case be very nice, if it were possible to have some sort of convention that when the eclipse plugin looks at a stand alone domain, it could at least hunt for some sort of configuration file, such as an .eclipse_launch_parameters config, to override the default settings.
> If such a mechanism would exist, i could enhance my create domain logic to pump into such a configuration file the same setting that is use in my start wildfly scripts.bat.sh.
> As it stands, every time I create a new runtime I need to open the configuration page.
> Go to the launch configurations, remove the heap settings.
> And then go to my startup domain scripts, search for the java opts that I care about, and copy them over.
> This is quite time wasteful.
> It would be extremely helpful to be able to dodge point and click configuration, once I tell wildfly where the folder for my stand alone domain is located.
> Many thanks for taking into consideration this enhancement request for widlfly eclipse plugin.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24896) Cannot start any JBoss server
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24896?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24896.
---------------------------------
Resolution: Done
pushed fix to master, and added an additional catch to the findPort logic so that we don't blow up a dozen other usecases.
> Cannot start any JBoss server
> -----------------------------
>
> Key: JBIDE-24896
> URL: https://issues.jboss.org/browse/JBIDE-24896
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Blocker
> Fix For: 4.5.1.AM2
>
>
> When I try to start any server such as WildFly or EAP 6/7, I immediately get a NPE:
> {code}
> An internal error occurred during: "Starting WildFly 10.1".
> java.lang.NullPointerException
> {code}
> {code}
> An internal error occurred during: "Starting WildFly 10.1".
> java.lang.NullPointerException
> at org.jboss.ide.eclipse.as.core.extensions.descriptors.XMLDocumentRepository.refresh(XMLDocumentRepository.java:131)
> at org.jboss.ide.eclipse.as.core.extensions.descriptors.XPathQuery.refresh(XPathQuery.java:146)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.XPathsPortsController.findPort(XPathsPortsController.java:84)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.XPathsPortsController.getPortOffset(XPathsPortsController.java:132)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.XPathsPortsController.getJBossWebPort(XPathsPortsController.java:114)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.XPathsPortsController.findPort(XPathsPortsController.java:58)
> at org.jboss.ide.eclipse.as.core.server.internal.JBossServer.findPort(JBossServer.java:209)
> at org.jboss.ide.eclipse.as.core.server.internal.JBossServer.getJBossWebPort(JBossServer.java:195)
> at org.jboss.ide.eclipse.as.core.extensions.polling.WebPortPoller.getURL(WebPortPoller.java:84)
> at org.jboss.ide.eclipse.as.core.extensions.polling.WebPortPoller.getCurrentStateSynchronous(WebPortPoller.java:155)
> at org.jboss.ide.eclipse.as.core.util.PollThreadUtils.isServerStarted(PollThreadUtils.java:218)
> at org.jboss.ide.eclipse.as.core.util.PollThreadUtils.isServerStarted(PollThreadUtils.java:204)
> at org.jboss.ide.eclipse.as.core.server.internal.launch.StandardLocalJBossStartLaunchDelegate.isServerStarted(StandardLocalJBossStartLaunchDelegate.java:67)
> at org.jboss.ide.eclipse.as.wtp.core.server.launch.AbstractStartJavaServerLaunchDelegate.preLaunchCheck(AbstractStartJavaServerLaunchDelegate.java:126)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.LocalJBossLaunchController.preLaunchCheck(LocalJBossLaunchController.java:110)
> at org.jboss.ide.eclipse.as.wtp.core.server.launch.ControllableServerLaunchConfiguration.preLaunchCheck(ControllableServerLaunchConfiguration.java:86)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:840)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
> at org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3566)
> at org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3502)
> at org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:377)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {code}
> I tried EAP 6.4, 7.0, 7.1 and WildFly 10.1.
> This is with devstudio 11.1.0.AM1 B873.
> As indicated by Rob, this is likely caused by this commit from JBIDE-24758:
> https://github.com/jbosstools/jbosstools-server/commit/1a58a4d54097e4d927...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months