[JBoss JIRA] (JBIDE-24881) Strange strings in cdk's PATH environmental variable
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24881?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24881:
-------------------------------------
I just had [~fbricon] try it out on Mac. He couldn't replicate this specific issue at all. (He could, of course, replicate the xhyve issue stopping suddenly).
But we tried a bunch of different stuff and couldn't once get a bunch of garbage in our launch config. If you're still able to replicate this, [~mmalina], then I think we need your help.
> Strange strings in cdk's PATH environmental variable
> ----------------------------------------------------
>
> Key: JBIDE-24881
> URL: https://issues.jboss.org/browse/JBIDE-24881
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM2
>
>
> Hardy was trying to test cdk in eclipse and got an error when starting cdk:
> {code}
> org.xml.sax.SAXParseException; lineNumber: 5; columnNumber: 67; Character reference "" is an invalid XML character. occurred while reading launch configuration file: /Volumes/Gram/Hardy/tmp/workspace/.metadata/.plugins/org.eclipse.debug.core/.launches/Container Development Environment 3.launch.
> Character reference "" is an invalid XML character.
> {code}
> It turns out that his PATH env var for cdk is this (from JBIDE-24222):
> {code}
> ]1337;RemoteHost=hardy@nineveh.lan]1337;CurrentDir=/Volumes/Gram/Hardy/tmp/devstudio/studio/devstudio.app/Contents/MacOS]1337;ShellIntegrationVersion=3;shell=bash/opt/local/bin:/opt/local/sbin:/Users/hardy/.rvm/gems/ruby-2.0.0-p648/bin:/Users/hardy/.rvm/gems/ruby-2.0.0-p648@global/bin:/Users/hardy/.rvm/rubies/ruby-2.0.0-p648/bin:/opt/local/bin:/opt/local/sbin:/Users/hardy/work/developer-platform/openshift/oc/1.3.1:/opt/java/wildfly/bin:/opt/java/tomcat/bin:/opt/java/ant/bin:/opt/java/maven/bin:/opt/java/scala/bin:/opt/java/gradle/bin:/bin:/Applications/Development/Vagrant/bin:/Users/hardy/work/developer-platform/cdk-3/go/bin:/opt/local/bin:/opt/local/sbin:/Users/hardy/bin:/opt/openshift:/opt/local/lib/mariadb/bin:/Applications/Internet/Firefox.app/Contents/MacOS:/Applications/Dev/Editor/Sublime Text.app/Contents/SharedSupport/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/Applications/Wireshark.app/Contents/MacOS:/Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home/bin/:/opt/local/bin:/opt/local/sbin:/Users/hardy/.rvm/gems/ruby-2.0.0-p648/bin:/Users/hardy/.rvm/gems/ruby-2.0.0-p648@global/bin:/Users/hardy/.rvm/rubies/ruby-2.0.0-p648/bin:/Users/hardy/work/developer-platform/openshift/oc/1.3.1:/opt/java/wildfly/bin:/opt/java/tomcat/bin:/opt/java/ant/bin:/opt/java/maven/bin:/opt/java/scala/bin:/opt/java/gradle/bin:/Applications/Development/Vagrant/bin:/Users/hardy/work/developer-platform/cdk-3/go/bin:/Users/hardy/bin:/opt/openshift:/opt/local/lib/mariadb/bin:/Applications/Internet/Firefox.app/Contents/MacOS:/Applications/Dev/Editor/Sublime Text.app/Contents/SharedSupport/bin:/Users/hardy/.rvm/bin:/Users/hardy/.rvm/bin
> {code}
> This was in devstudio nightly. So I checked too and I have a similar problem. In my case I have this in the PATH variable in launch config:
> {code}
> Restored session: Tue Aug 22 15:34:26 CEST 2017
> /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin/bin
> Saving session...
> ...saving history...
> ...completed.:/Users/rasp/jbossqa/cdk/cdk-3.1.0
> {code}
> So something in the way you get the PATH is wrong. I would say this is definitely a regression - I remember seeing correct PATH there in the past.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24887) fabric8analysis must depend on jbosstools license feature
by Nick Boldt (JIRA)
Nick Boldt created JBIDE-24887:
----------------------------------
Summary: fabric8analysis must depend on jbosstools license feature
Key: JBIDE-24887
URL: https://issues.jboss.org/browse/JBIDE-24887
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 4.5.1.AM1
Reporter: Nick Boldt
Need to add a fabric8 analysis feature so that this plugin can be installed via Eclipse Marketplace or RH Central.
But by doing so, we also introduce a dependency on the jbosstools license feature.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24222) CDK3 Server adapter: fails to detect that cdk3 Beta3 was successfully started (on macos/xhyve?)
by Hardy Ferentschik (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24222?page=com.atlassian.jira.plugi... ]
Hardy Ferentschik commented on JBIDE-24222:
-------------------------------------------
{quote}
This is really odd! I'd never seen this until now. I didn't even know such a xml file gets created. But now I looked at the launch config and I can see very odd things in PATH env var in my case:
{quote}
Not me either. I guess the intention is that this particular element contains the PATH on your host. For example to then launch minishift. The problem seems to be that there is other content in there which should not be there. In some cases (as in yours) it might not trigger an error and things "just work", but in my case it creates some invalid XML as well, which triggers the error. There must be something which tries to determine the PATH, since even after hand editing, it gets reset to the problematic value.
{quote}
this is definitely a bug and I will create a JIRA shortly.
{quote}
+1
{quote}
As a workaround, you can edit the env var manually in the launch config (simply use your normal $PATH string) and then start cdk again.
{quote}
Hmm, that did not seem to work, but maybe I have to first close Eclipse before editing the XML and then re-start it. I tried to edit the XML while Eclipse was still running and that did not work. I will try again.
> CDK3 Server adapter: fails to detect that cdk3 Beta3 was successfully started (on macos/xhyve?)
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-24222
> URL: https://issues.jboss.org/browse/JBIDE-24222
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.4.4.AM2
> Environment: macos
> xhyve supervisor
> cdk3 beta3
> Reporter: Andre Dietisheim
> Assignee: Martin Malina
> Priority: Critical
> Labels: help_wanted
> Fix For: 4.5.x
>
> Attachments: Screenshot 2017-04-18 16.37.44.png, image-2017-04-04-15-48-59-677.png, server-adapter-error.tiff
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24884) Log an error if detected cdk registry is wrong
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24884?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24884:
--------------------------------
Fix Version/s: 4.5.1.AM1
> Log an error if detected cdk registry is wrong
> ----------------------------------------------
>
> Key: JBIDE-24884
> URL: https://issues.jboss.org/browse/JBIDE-24884
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM1
>
>
> This is a followup of JBIDE-24783.
> When minishift openshift registry is unable to return a valid registry, the tooling should log an error. JBIDE-24783 was supposed to add this thing (along with removing the default value), but I was not able to trigger the error.
> The workflow is:
> Once cdk is started in eclipse, the cdk tooling will create the openshift connection and run minishift openshift registry to figure out which registry to use. But in my testing even if this returns "bla bla", the tooling will happily accept it.
> To test this, you can use a simple minishift wrapper such as this:
> {code}
> #!/bin/bash
> case $* in
> "openshift registry")
> echo bla bla
> exit 1
> ;;
> *)
> /Users/rasp/jbossqa/cdk/cdk-3.1.0/minishift $*
> esac
> {code}
> You can also remove the "exit 1" to check what happens with zero exit code.
> In my opinion any of these should trigger an error:
> a) minishift openshift registry finishes with a non-zero code
> b) the returned string is not a valid url
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24884) Log an error if detected cdk registry is wrong
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24884?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24884.
---------------------------------
Resolution: Done
Pushed
> Log an error if detected cdk registry is wrong
> ----------------------------------------------
>
> Key: JBIDE-24884
> URL: https://issues.jboss.org/browse/JBIDE-24884
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM1
>
>
> This is a followup of JBIDE-24783.
> When minishift openshift registry is unable to return a valid registry, the tooling should log an error. JBIDE-24783 was supposed to add this thing (along with removing the default value), but I was not able to trigger the error.
> The workflow is:
> Once cdk is started in eclipse, the cdk tooling will create the openshift connection and run minishift openshift registry to figure out which registry to use. But in my testing even if this returns "bla bla", the tooling will happily accept it.
> To test this, you can use a simple minishift wrapper such as this:
> {code}
> #!/bin/bash
> case $* in
> "openshift registry")
> echo bla bla
> exit 1
> ;;
> *)
> /Users/rasp/jbossqa/cdk/cdk-3.1.0/minishift $*
> esac
> {code}
> You can also remove the "exit 1" to check what happens with zero exit code.
> In my opinion any of these should trigger an error:
> a) minishift openshift registry finishes with a non-zero code
> b) the returned string is not a valid url
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24884) Log an error if detected cdk registry is wrong
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24884?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24884:
-------------------------------------
I decided only to log an error if the output is garbage or not a URL. If the output is a valid host:port combination but minishift returns a non-zero status, there's no real reason to error.
> Log an error if detected cdk registry is wrong
> ----------------------------------------------
>
> Key: JBIDE-24884
> URL: https://issues.jboss.org/browse/JBIDE-24884
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
>
> This is a followup of JBIDE-24783.
> When minishift openshift registry is unable to return a valid registry, the tooling should log an error. JBIDE-24783 was supposed to add this thing (along with removing the default value), but I was not able to trigger the error.
> The workflow is:
> Once cdk is started in eclipse, the cdk tooling will create the openshift connection and run minishift openshift registry to figure out which registry to use. But in my testing even if this returns "bla bla", the tooling will happily accept it.
> To test this, you can use a simple minishift wrapper such as this:
> {code}
> #!/bin/bash
> case $* in
> "openshift registry")
> echo bla bla
> exit 1
> ;;
> *)
> /Users/rasp/jbossqa/cdk/cdk-3.1.0/minishift $*
> esac
> {code}
> You can also remove the "exit 1" to check what happens with zero exit code.
> In my opinion any of these should trigger an error:
> a) minishift openshift registry finishes with a non-zero code
> b) the returned string is not a valid url
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months