[JBoss JIRA] (JBIDE-25000) Server adapter: starting into debugging fails initially (succeeds on a latter try)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25000?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25000:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.5.1.AM3)
> Server adapter: starting into debugging fails initially (succeeds on a latter try)
> ----------------------------------------------------------------------------------
>
> Key: JBIDE-25000
> URL: https://issues.jboss.org/browse/JBIDE-25000
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.5.x
>
> Attachments: failed-to-connect-v8-vm.png
>
>
> # ASSERT: have an application running in OpenShift based on the "nodejs-mongo-persistent" template
> # ASSERT: have a server adapter for it
> # EXEC/ASSERT: have the adapter started in non-debugging/normal mode
> # EXEC: restart the adapter debugging
> Result:
> !failed-to-connect-v8-vm.png!
> {code}
> java.io.IOException: Failed to get version
> at org.eclipse.wst.jsdt.chromium.internal.v8native.JavascriptVmImpl.newIOException(JavascriptVmImpl.java:114)
> at org.eclipse.wst.jsdt.chromium.internal.standalonev8.StandaloneVmImpl.attachImpl(StandaloneVmImpl.java:132)
> at org.eclipse.wst.jsdt.chromium.internal.standalonev8.StandaloneVmImpl.attach(StandaloneVmImpl.java:79)
> at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory$4$1.attach(JavascriptVmEmbedderFactory.java:207)
> at org.eclipse.wst.jsdt.chromium.debug.core.model.DebugTargetImpl.attach(DebugTargetImpl.java:74)
> at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:101)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
> at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
> at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> Caused by: java.util.concurrent.ExecutionException: java.io.IOException: End of stream
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:206)
> at org.eclipse.wst.jsdt.chromium.internal.standalonev8.StandaloneVmImpl.attachImpl(StandaloneVmImpl.java:127)
> ... 9 more
> Caused by: java.io.IOException: End of stream
> at org.eclipse.wst.jsdt.chromium.internal.transport.Handshaker$StandaloneV8Impl$HandshakeTaks.call(Handshaker.java:127)
> at org.eclipse.wst.jsdt.chromium.internal.transport.Handshaker$StandaloneV8Impl$HandshakeTaks.call(Handshaker.java:1)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at org.eclipse.wst.jsdt.chromium.internal.transport.Handshaker$StandaloneV8Impl.perform(Handshaker.java:104)
> at org.eclipse.wst.jsdt.chromium.internal.transport.SocketConnection$ReaderThread.run(SocketConnection.java:158)
> {code}
> ps. this can be simulated in the CDK, by having everything set and once the pod is up and ithe adapter is in debug, stopping the port forwarding.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25126) Server adapter editor, -wizard: validate debug-key, debug-port-key fields
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25126:
-------------------------------------
Summary: Server adapter editor, -wizard: validate debug-key, debug-port-key fields (was: Server adapter editor: validate debug-key, debug-port-key fields)
> Server adapter editor, -wizard: validate debug-key, debug-port-key fields
> -------------------------------------------------------------------------
>
> Key: JBIDE-25126
> URL: https://issues.jboss.org/browse/JBIDE-25126
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Labels: openshift_v3, server_adapter_editor, server_adapter_wizard
> Fix For: 4.5.x
>
>
> Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key fields
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25126:
-------------------------------------
Summary: Server adapter editor: validate debug-key, debug-port-key fields (was: Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields)
> Server adapter editor: validate debug-key, debug-port-key fields
> ----------------------------------------------------------------
>
> Key: JBIDE-25126
> URL: https://issues.jboss.org/browse/JBIDE-25126
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Fix For: 4.5.x
>
>
> Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-25115:
------------------------------------------
[~adietish] it's the same idea as the popup, in my opinion.
If you want to offer a user to restart a server adapter, then maybe we can add a link to the already discussed label, by hitting which the server adapter will be restarted. Although i'm not aware if it is possible/difficult to implement
> Server adapter editor: should inform user that changes in settings are effective after restart only
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25115
> URL: https://issues.jboss.org/browse/JBIDE-25115
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: openshift_v3, server_adapter_editor, ux
> Fix For: 4.5.x
>
>
> To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter.
> We could
> * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted")
> * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-25115 at 9/28/17 8:31 AM:
-------------------------------------------------------------------
[~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes.
Here's another idea: what about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time.
was (Author: adietish):
[~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes.
What about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time.
> Server adapter editor: should inform user that changes in settings are effective after restart only
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25115
> URL: https://issues.jboss.org/browse/JBIDE-25115
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: openshift_v3, server_adapter_editor, ux
> Fix For: 4.5.x
>
>
> To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter.
> We could
> * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted")
> * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months