[JBoss JIRA] (JBDS-4570) Downloader sometimes reports total download wrong when several files downloaded
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-4570?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-4570:
--------------------------------
Summary: Downloader sometimes reports total download wrong when several files downloaded (was: Downloader class sometimes reports total download wrong when several files downloaded)
> Downloader sometimes reports total download wrong when several files downloaded
> -------------------------------------------------------------------------------
>
> Key: JBDS-4570
> URL: https://issues.jboss.org/browse/JBDS-4570
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: platform-installer
> Affects Versions: 11.1.0.AM2
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 11.1.0.AM3
>
>
> This is happening when very small and big files are downloaded at the same time. In current implementation when download finished it decrements totalDownloads counter that affects condition in responseHandler that decides all content-length headers received and it is time to set total amount for downloader.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBDS-4570) Downloader class sometimes reports total download wrong when several files downloaded
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-4570?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-4570:
--------------------------------
Sprint: devex #138 September 2017
> Downloader class sometimes reports total download wrong when several files downloaded
> -------------------------------------------------------------------------------------
>
> Key: JBDS-4570
> URL: https://issues.jboss.org/browse/JBDS-4570
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: platform-installer
> Affects Versions: 11.1.0.AM2
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 11.1.0.AM3
>
>
> This is happening when very small and big files are downloaded at the same time. In current implementation when download finished it decrements totalDownloads counter that affects condition in responseHandler that decides all content-length headers received and it is time to set total amount for downloader.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBDS-4570) Downloader class sometimes reports total download wrong when several files downloaded
by Denis Golovin (JIRA)
Denis Golovin created JBDS-4570:
-----------------------------------
Summary: Downloader class sometimes reports total download wrong when several files downloaded
Key: JBDS-4570
URL: https://issues.jboss.org/browse/JBDS-4570
Project: Red Hat JBoss Developer Studio (devstudio)
Issue Type: Bug
Components: platform-installer
Affects Versions: 11.1.0.AM2
Reporter: Denis Golovin
Assignee: Denis Golovin
Fix For: 11.1.0.AM3
This is happening when very small and big files are downloaded at the same time. In current implementation when download finished it decrements totalDownloads counter that affects condition in responseHandler that decides all content-length headers received and it is time to set total amount for downloader.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25121:
-------------------------------------
Description:
steps 1:
# ASSERT: have a connection the cdk
# EXEC: edit the connection and move to "Image Registry URL" text field
# EXEC: provide some bogus URL (ex. bookaroo-banzai)
Result:
the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
But the text field is not decorated.
!image-2017-09-27-22-59-33-548.png!
steps 2:
# EXEC: provide the following URL: http:/bookaroo-banzai
Result:
It thinks that it's valid, there's no error in the title area, "Finish" is enabled
Expected result:
http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
was:
# ASSERT: have a connection the cdk
# EXEC: edit the connection and move to "Image Registry URL" text field
# EXEC: provide some bogus URL (ex. bookaroo-banzai)
Result:
the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
But the text field is not decorated.
!image-2017-09-27-22-59-33-548.png!
# EXEC: provide the following URL: http:/bookaroo-banzai
Result:
It thinks that it's valid, there's no error in the title area, "Finish" is enabled
Expected result:
http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
> Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: 4.5.x
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> steps 1:
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> steps 2:
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid ( and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25121:
-------------------------------------
Summary: Connection wizard: Image Registry URL is not decorated when not valid ( and validation seems weird) (was: Connection wizard: Image Registry URL is not decorated when not valid)
> Connection wizard: Image Registry URL is not decorated when not valid ( and validation seems weird)
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: 4.5.x
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25121:
-------------------------------------
Summary: Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird) (was: Connection wizard: Image Registry URL is not decorated when not valid ( and validation seems weird))
> Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: 4.5.x
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25121:
-------------------------------------
Description:
# ASSERT: have a connection the cdk
# EXEC: edit the connection and move to "Image Registry URL" text field
# EXEC: provide some bogus URL (ex. bookaroo-banzai)
Result:
the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
But the text field is not decorated.
!image-2017-09-27-22-59-33-548.png!
# EXEC: provide the following URL: http:/bookaroo-banzai
Result:
It thinks that it's valid, there's no error in the title area, "Finish" is enabled
Expected result:
http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
was:
# ASSERT: have a connection the cdk
# EXEC: edit the connection and move to "Image Registry URL" text field
# EXEC: provide some bogus URL (ex. bookaroo-banzai)
Result:
the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
But the text field is not decorated.
!image-2017-09-27-22-59-33-548.png!
# EXEC: provide the following URL: http:/bookaroo-banzai
Result:
It thinks that it's valid, there's no error in the title area, "Finish" is enabled
Expected result:
http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
> Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: 4.5.x
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25115:
-------------------------------------
I vote a label. A popup after doSave() might be obtrusive, unless you give them the option to not show again in the future.
> Server adapter editor: should inform user that changes in settings are effective after restart only
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25115
> URL: https://issues.jboss.org/browse/JBIDE-25115
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: openshift_v3, server_adapter_editor, ux
> Fix For: 4.5.x
>
>
> To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter.
> We could
> * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted")
> * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25089) Server adapter wizard: oc version exception thrown when using latest 3.7.1.alpha.1
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25089?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-25089:
--------------------------------
Fix Version/s: 4.5.1.AM3
(was: 4.5.1.Final)
> Server adapter wizard: oc version exception thrown when using latest 3.7.1.alpha.1
> ----------------------------------------------------------------------------------
>
> Key: JBIDE-25089
> URL: https://issues.jboss.org/browse/JBIDE-25089
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Priority: Minor
> Labels: oc_binary, server_adapter_wizard
> Fix For: 4.5.1.AM3
>
>
> steps:
> # ASSERT: use/configure the oc binary that you can download from https://github.com/openshift/origin/releases/download/v3.7.0-alpha.1/open...
> # ASSERT: make sure that you have an openshift application running in OpenShift
> # EXEC: in OpenShift explorer: select the service/dc/rc for your application and choose "Server adapter..." from the context menu
> # ASSERT: server adapter wizard shows up
> Result:
> In Eclipse log you'll find the following:
> {code}
> java.lang.IllegalArgumentException: invalid version "3.7.0.alpha.1": invalid qualifier "alpha.1"
> at org.osgi.framework.Version.validate(Version.java:205)
> at org.osgi.framework.Version.<init>(Version.java:94)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:109)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:93)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.getVersion(OCBinaryVersionValidator.java:78)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.isCompatibleForPublishing(OCBinaryVersionValidator.java:132)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinary.getStatus(OCBinary.java:137)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:179)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:169)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizard.<init>(ServerSettingsWizard.java:48)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.createServer(ServerAdapterHandler.java:137)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.openOrCreateServerAdapter(ServerAdapterHandler.java:127)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.getOpenShiftServer(ServerAdapterHandler.java:106)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.execute(ServerAdapterHandler.java:60)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:92)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:305)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:239)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:431)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:446)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.lambda$2(AbstractContributionItem.java:472)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5268)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1150)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1039)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1472)
> {code}
> Eclipse preferences will nevertheless recognize it partly correctly as 3.7.0
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months