September 2017 - jbosstools-issues

[JBoss JIRA] (JBIDE-25096) Server adapter editor: Modifications of debugging settings are ignored

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25096?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-25096: ------------------------------------------ merged into master > Server adapter editor: Modifications of debugging settings are ignored > ---------------------------------------------------------------------- > > Key: JBIDE-25096 > URL: https://issues.jboss.org/browse/JBIDE-25096 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Aurélien Pupier > Assignee: Andre Dietisheim > Labels: openshift_v3, server_adapter_editor > Fix For: 4.5.1.AM3 > > Attachments: server-editor-env-variables.png > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key fields

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-25126: ------------------------------------- Labels: openshift_v3 server_adapter_editor server_adapter_wizard (was: ) > Server adapter editor: validate debug-key, debug-port-key fields > ---------------------------------------------------------------- > > Key: JBIDE-25126 > URL: https://issues.jboss.org/browse/JBIDE-25126 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Labels: openshift_v3, server_adapter_editor, server_adapter_wizard > Fix For: 4.5.x > > > Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor, -wizard: validate debug-key, debug-port-key fields

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-25126: ------------------------------------- Summary: Server adapter editor, -wizard: validate debug-key, debug-port-key fields (was: Server adapter editor: validate debug-key, debug-port-key fields) > Server adapter editor, -wizard: validate debug-key, debug-port-key fields > ------------------------------------------------------------------------- > > Key: JBIDE-25126 > URL: https://issues.jboss.org/browse/JBIDE-25126 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Labels: openshift_v3, server_adapter_editor, server_adapter_wizard > Fix For: 4.5.x > > > Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key fields

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-25126: ------------------------------------------ The rules are printed out by the OpenShift REST API if you post invalid values: {code} start with alphabetic character or '_', followed by a string of alphanumeric characters or '_' (e.g. 'my_name', or 'MY_NAME', or 'MyName', regex used for validation is '[A-Za-z_][A-Za-z0-9_]*' {code} I implemented those rules when trying to solve JBIDE-25108: https://github.com/jbosstools/jbosstools-openshift/pull/1575/files#diff-b... > Server adapter editor: validate debug-key, debug-port-key fields > ---------------------------------------------------------------- > > Key: JBIDE-25126 > URL: https://issues.jboss.org/browse/JBIDE-25126 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Labels: openshift_v3, server_adapter_editor, server_adapter_wizard > Fix For: 4.5.x > > > Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key fields

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-25126: ------------------------------------- Summary: Server adapter editor: validate debug-key, debug-port-key fields (was: Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields) > Server adapter editor: validate debug-key, debug-port-key fields > ---------------------------------------------------------------- > > Key: JBIDE-25126 > URL: https://issues.jboss.org/browse/JBIDE-25126 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Fix For: 4.5.x > > > Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25126?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-25126: ------------------------------------- Issue Type: Enhancement (was: Bug) > Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields > ------------------------------------------------------------------------------------- > > Key: JBIDE-25126 > URL: https://issues.jboss.org/browse/JBIDE-25126 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Fix For: 4.5.x > > > Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25126) Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields

by Andre Dietisheim (JIRA)

Andre Dietisheim created JBIDE-25126: ---------------------------------------- Summary: Server adapter editor: validate debug-key, debug-port-key and debug-port-value fields Key: JBIDE-25126 URL: https://issues.jboss.org/browse/JBIDE-25126 Project: Tools (JBoss Tools) Issue Type: Bug Components: openshift Affects Versions: 4.5.1.AM2 Reporter: Andre Dietisheim Fix For: 4.5.x Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only

by Dmitrii Bocharov (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ] Dmitrii Bocharov commented on JBIDE-25115: ------------------------------------------ [~adietish] it's the same idea as the popup, in my opinion. If you want to offer a user to restart a server adapter, then maybe we can add a link to the already discussed label, by hitting which the server adapter will be restarted. Although i'm not aware if it is possible/difficult to implement > Server adapter editor: should inform user that changes in settings are effective after restart only > --------------------------------------------------------------------------------------------------- > > Key: JBIDE-25115 > URL: https://issues.jboss.org/browse/JBIDE-25115 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Priority: Minor > Labels: openshift_v3, server_adapter_editor, ux > Fix For: 4.5.x > > > To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter. > We could > * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted") > * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-25115 at 9/28/17 8:31 AM: ------------------------------------------------------------------- [~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes. Here's another idea: what about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time. was (Author: adietish): [~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes. What about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time. > Server adapter editor: should inform user that changes in settings are effective after restart only > --------------------------------------------------------------------------------------------------- > > Key: JBIDE-25115 > URL: https://issues.jboss.org/browse/JBIDE-25115 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Priority: Minor > Labels: openshift_v3, server_adapter_editor, ux > Fix For: 4.5.x > > > To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter. > We could > * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted") > * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-25115: ------------------------------------------ [~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes. What about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time. > Server adapter editor: should inform user that changes in settings are effective after restart only > --------------------------------------------------------------------------------------------------- > > Key: JBIDE-25115 > URL: https://issues.jboss.org/browse/JBIDE-25115 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.1.AM2 > Reporter: Andre Dietisheim > Priority: Minor > Labels: openshift_v3, server_adapter_editor, ux > Fix For: 4.5.x > > > To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter. > We could > * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted") > * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 6 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues September 2017