[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-25115:
------------------------------------------
[~dbocharov] [~rob.stryker] thanks for the inputs. I also tend towards a label, I actually like the idea of only showing the info upon changes.
What about asking whether the adapter should be restarted once the user hits save? That dialog could actually include the this very info at the same time.
> Server adapter editor: should inform user that changes in settings are effective after restart only
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25115
> URL: https://issues.jboss.org/browse/JBIDE-25115
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: openshift_v3, server_adapter_editor, ux
> Fix For: 4.5.x
>
>
> To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter.
> We could
> * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted")
> * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25017) 1 recurring Test Failure (20+ builds) in JBIDE 4.5.1.AM2 for webservices component
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25017?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-25017:
------------------------------------------
Now those tests are fixed themselves again, but a new failure appeared https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...:
{noformat}
java.lang.AssertionError: failed to generate sample class
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.jboss.tools.ws.creation.core.test.command.JBossWSClientCommandTest.testClientCodeGenerationCommand(JBossWSClientCommandTest.java:88)
{noformat}
> 1 recurring Test Failure (20+ builds) in JBIDE 4.5.1.AM2 for webservices component
> ----------------------------------------------------------------------------------
>
> Key: JBIDE-25017
> URL: https://issues.jboss.org/browse/JBIDE-25017
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: webservices
> Affects Versions: 4.5.1.AM2
> Reporter: Nick Boldt
> Assignee: Dmitrii Bocharov
> Priority: Critical
> Labels: testfailure
> Fix For: 4.5.1.AM3
>
>
> *1 Test Failure(s) in JBIDE 4.5.1.AM2 for webservices component:*
> https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
> -----
> {code}
> Regression
> org.jboss.tools.ws.jaxrs.core.internal.metamodel.builder.JaxrsMetamodelChangedProcessorTestCase.shouldChangeEndpointUriPathTemplateWhenSwitchingToWebxmlCoreApplication
> Failing for the past 22 builds (Since #671 )
> Took 0.13 sec.
> add description
> Error Message
> Expected: <6>
> but: was <10>
> Stacktrace
> java.lang.AssertionError:
> Expected: <6>
> but: was <10>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.builder.JaxrsMetamodelChangedProcessorTestCase.shouldChangeEndpointUriPathTemplateWhenSwitchingToWebxmlCoreApplication(JaxrsMetamodelChangedProcessorTestCase.java:358)
> {code}
> -- https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25115) Server adapter editor: should inform user that changes in settings are effective after restart only
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25115?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-25115:
------------------------------------------
I also vote for a label. But i think it'd be good to show it only when changes are being made to the settings. It seems to me that it'll take user's attention, in contrast to a persistent label - server adapter editor page is rather loaded and a new label can be lost among other elements.
> Server adapter editor: should inform user that changes in settings are effective after restart only
> ---------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25115
> URL: https://issues.jboss.org/browse/JBIDE-25115
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: openshift_v3, server_adapter_editor, ux
> Fix For: 4.5.x
>
>
> To the noob user it's not obvious that any change in settings to the server adapter (done in the server adapter editor) is only active after restarting the adapter.
> We could
> * add an explanatory label within the editor ("changes in settings are only active once the server adapter is restarted")
> * a dialog popping upon saving that says "changes in settings are only active once the server adapter is restarted"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-25089) Server adapter wizard: oc version exception thrown when using latest 3.7.0.alpha.1
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25089?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25089:
-------------------------------------
Summary: Server adapter wizard: oc version exception thrown when using latest 3.7.0.alpha.1 (was: Server adapter wizard: oc version exception thrown when using latest 3.7.1.alpha.1)
> Server adapter wizard: oc version exception thrown when using latest 3.7.0.alpha.1
> ----------------------------------------------------------------------------------
>
> Key: JBIDE-25089
> URL: https://issues.jboss.org/browse/JBIDE-25089
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Priority: Minor
> Labels: oc_binary, server_adapter_wizard
> Fix For: 4.5.1.AM3
>
>
> steps:
> # ASSERT: use/configure the oc binary that you can download from https://github.com/openshift/origin/releases/download/v3.7.0-alpha.1/open...
> # ASSERT: make sure that you have an openshift application running in OpenShift
> # EXEC: in OpenShift explorer: select the service/dc/rc for your application and choose "Server adapter..." from the context menu
> # ASSERT: server adapter wizard shows up
> Result:
> In Eclipse log you'll find the following:
> {code}
> java.lang.IllegalArgumentException: invalid version "3.7.0.alpha.1": invalid qualifier "alpha.1"
> at org.osgi.framework.Version.validate(Version.java:205)
> at org.osgi.framework.Version.<init>(Version.java:94)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:109)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:93)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.getVersion(OCBinaryVersionValidator.java:78)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.isCompatibleForPublishing(OCBinaryVersionValidator.java:132)
> at org.jboss.tools.openshift.internal.core.preferences.OCBinary.getStatus(OCBinary.java:137)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:179)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:169)
> at org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizard.<init>(ServerSettingsWizard.java:48)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.createServer(ServerAdapterHandler.java:137)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.openOrCreateServerAdapter(ServerAdapterHandler.java:127)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.getOpenShiftServer(ServerAdapterHandler.java:106)
> at org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.execute(ServerAdapterHandler.java:60)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:92)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:305)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:239)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:431)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:446)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.lambda$2(AbstractContributionItem.java:472)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5268)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1150)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1039)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1472)
> {code}
> Eclipse preferences will nevertheless recognize it partly correctly as 3.7.0
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months
[JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24868 at 9/28/17 4:38 AM:
-------------------------------------------------------------------
[~aurelien.pupier] [~rhuss] Setting the router timeout via the annotation described above works for me. The router wont timeout any more and there's no "504 Gateway timeout" error being displayed any more. But then the Eclipse browser gives up, saying that the page could not be loaded. The external (Chrome MacOS) browser doesnt seem to bother, it keeps waiting. But then the debug session in Eclipse gives up & terminates when you F8. I guess that requires more investigations.
We btw. respect the preference to use the internal or external browser.
* Without timeout setting in the router, default 1 minute timeout applies:
Browser displays 504 Gateway timeout after a minute
https://youtu.be/J6pmzVBgbnk
* Annotating with timeout setting in the router, custom timeout applies:
Internal Eclipse browser pops up a dialog saying that it could not load the page. My external chrome didnt come up with such a message, it just kept waiting for several minutes (didnt wait until the end):
https://youtu.be/KzxDvgm5kF4
was (Author: adietish):
[~aurelien.pupier] [~rhuss] Setting the router timeout via the annotation described above works for me. The router wont timeout any more and there's no "504 Gateway timeout" error being displayed any more. But then the Eclipse browser gives up, saying that the page could not be loaded. The external (Chrome MacOS) browser doesnt seem to bother, it keeps waiting. But then the debug session in Eclipse gives up & terminates when you F8. I guess that requires more investigations.
We btw. respect the preference to use the internal or external browser.
* Without timeout setting in the router, default 1 minute timeout applies:
Browser displays 504 Gateway timeout after a minute
https://youtu.be/J6pmzVBgbnk
* AnnotatingWithout timeout setting in the router, default 1 minute timeout applies:
Internal Eclipse browser pops up a dialog saying that it could not load the page. My external chrome didnt come up with such a message, it just kept waiting for several minutes (didnt wait until the end):
https://youtu.be/KzxDvgm5kF4
> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24868
> URL: https://issues.jboss.org/browse/JBIDE-24868
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Aurélien Pupier
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.1.AM3
>
> Attachments: breakpoint-suspend-thread.png
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-livene...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 7 months