[JBoss JIRA] (JBIDE-25049) Connection wizard: Cannot "Discover" "Image Registry URL"
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25049?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25049:
-------------------------------------
Description:
# ASSERT: make sure that you have a connection to the CDK/minishift in Eclipse
# ASSERT: make sure that you have a server adapter for your CDK/minishift in Eclipse
# EXEC/ASSERT: make sure that your CDK/minishift server adapter is started
# EXEC: edit the OpenShift connection
# ASSERT: connection wizard shows up
# EXEC: hit "Advanced" so that the "Image Registry URL" text field shows up
# EXEC: hit "Discover"
Result
An error dialog shows up telling you no registry provider could be found
!screenshot-1.png!
was:
# ASSERT: make sure that you have a connection to the CDK/minishift in Eclipse
# ASSERT: make sure that you have a server adapter for your CDK/minishift in Eclipse
# EXEC/ASSERT: make sure that your CDK/minishift server adapter is started
# EXEC: edit the OpenShift connection
# ASSERT: connection wizard shows up
# EXEC: hit "Advanced" so that the "Image Registry URL" text field shows up
# EXEC: hit "Discover"
Result
An error dialog shows up telling you no registry provider could be found
> Connection wizard: Cannot "Discover" "Image Registry URL"
> ---------------------------------------------------------
>
> Key: JBIDE-25049
> URL: https://issues.jboss.org/browse/JBIDE-25049
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Andre Dietisheim
> Attachments: screenshot-1.png
>
>
> # ASSERT: make sure that you have a connection to the CDK/minishift in Eclipse
> # ASSERT: make sure that you have a server adapter for your CDK/minishift in Eclipse
> # EXEC/ASSERT: make sure that your CDK/minishift server adapter is started
> # EXEC: edit the OpenShift connection
> # ASSERT: connection wizard shows up
> # EXEC: hit "Advanced" so that the "Image Registry URL" text field shows up
> # EXEC: hit "Discover"
> Result
> An error dialog shows up telling you no registry provider could be found
> !screenshot-1.png!
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25049) Connection wizard: Cannot "Discover" "Image Registry URL"
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-25049:
----------------------------------------
Summary: Connection wizard: Cannot "Discover" "Image Registry URL"
Key: JBIDE-25049
URL: https://issues.jboss.org/browse/JBIDE-25049
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdk, openshift
Affects Versions: 4.5.0.AM2
Reporter: Andre Dietisheim
# ASSERT: make sure that you have a connection to the CDK/minishift in Eclipse
# ASSERT: make sure that you have a server adapter for your CDK/minishift in Eclipse
# EXEC/ASSERT: make sure that your CDK/minishift server adapter is started
# EXEC: edit the OpenShift connection
# ASSERT: connection wizard shows up
# EXEC: hit "Advanced" so that the "Image Registry URL" text field shows up
# EXEC: hit "Discover"
Result
An error dialog shows up telling you no registry provider could be found
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25046) Can't find CDK for registry discovery when 2 connections are defined for CDK
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-25046 at 9/18/17 9:43 AM:
-------------------------------------------------------------------
Matching the fact that "Discover" doesnt work for me is that I see an update of the connection being executed at https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=ConfigureDependentFrameworksListener}
private void configureOpenshift(IServer server, ServiceManagerEnvironment adb) {
CDKOpenshiftUtility util = new CDKOpenshiftUtility();
IConnection con = util.findExistingOpenshiftConnection(server, adb);
if( con == null ) {
con = util.createOpenshiftConnection(adb);
} else {
util.updateOpenshiftConnection(adb, con);
}
if( con != null ) {
con.connect();
}
}
{code}
which ends up in https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=CDKOpenshiftUtility}
public void updateOpenshiftConnection(ServiceManagerEnvironment env, IConnection con, boolean fireUpdate) {
String dockerReg = env.getDockerRegistry();
((Connection)con).setExtendedProperty(ICommonAttributes.IMAGE_REGISTRY_URL_KEY, dockerReg);
{code}
but the registry is *null*
[~rob.stryker] any idea why "Discover" in connection wizard fails for me even though the server adapter is running?
was (Author: adietish):
Matching the fact that "Discover" doesnt work for me is that I see an update of the connection being executed at https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=ConfigureDependentFrameworksListener}
private void configureOpenshift(IServer server, ServiceManagerEnvironment adb) {
CDKOpenshiftUtility util = new CDKOpenshiftUtility();
IConnection con = util.findExistingOpenshiftConnection(server, adb);
if( con == null ) {
con = util.createOpenshiftConnection(adb);
} else {
util.updateOpenshiftConnection(adb, con);
}
if( con != null ) {
con.connect();
}
}
{code}
which ends up in https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=CDKOpenshiftUtility}
public void updateOpenshiftConnection(ServiceManagerEnvironment env, IConnection con, boolean fireUpdate) {
String dockerReg = env.getDockerRegistry();
((Connection)con).setExtendedProperty(ICommonAttributes.IMAGE_REGISTRY_URL_KEY, dockerReg);
{code}
but the registry is *null*
> Can't find CDK for registry discovery when 2 connections are defined for CDK
> ----------------------------------------------------------------------------
>
> Key: JBIDE-25046
> URL: https://issues.jboss.org/browse/JBIDE-25046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Jeff MAURY
> Assignee: Rob Stryker
> Labels: cdk, cdk_server_adapter_, explorer, openshift, openshift_v3
> Fix For: 4.5.x
>
>
> EXEC: define an Openshift connection for CDK/admin
> EXEC: define an Openshift connection for CDK/developer
> EXEC: define a CDK3 server
> EXEC: start the CDK 3 server
> ASSERT: the CDK/admin OS3 connection is updated (registry not empty)
> ASSERT: the CDK/developer OS3 connection is not updated (registry empty)
> EXEC: on the CDK/developer OS3 connection, click the DIscover buttoon
> ASSERT: the registry URL is updated, not the error dialog is displayed
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25046) Can't find CDK for registry discovery when 2 connections are defined for CDK
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-25046 at 9/18/17 9:42 AM:
-------------------------------------------------------------------
Matching the fact that "Discover" doesnt work for me is that I see an update of the connection being executed at https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=ConfigureDependentFrameworksListener}
private void configureOpenshift(IServer server, ServiceManagerEnvironment adb) {
CDKOpenshiftUtility util = new CDKOpenshiftUtility();
IConnection con = util.findExistingOpenshiftConnection(server, adb);
if( con == null ) {
con = util.createOpenshiftConnection(adb);
} else {
util.updateOpenshiftConnection(adb, con);
}
if( con != null ) {
con.connect();
}
}
{code}
which ends up in https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=CDKOpenshiftUtility}
public void updateOpenshiftConnection(ServiceManagerEnvironment env, IConnection con, boolean fireUpdate) {
String dockerReg = env.getDockerRegistry();
((Connection)con).setExtendedProperty(ICommonAttributes.IMAGE_REGISTRY_URL_KEY, dockerReg);
{code}
but the registry is *null*
was (Author: adietish):
Matching the fact that "Discover" doesnt work for me is that I see an update of the connection being executed at
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/listeners/ConfigureDependentFrameworksListener.java#L107}
private void configureOpenshift(IServer server, ServiceManagerEnvironment adb) {
CDKOpenshiftUtility util = new CDKOpenshiftUtility();
IConnection con = util.findExistingOpenshiftConnection(server, adb);
if( con == null ) {
con = util.createOpenshiftConnection(adb);
} else {
util.updateOpenshiftConnection(adb, con);
}
if( con != null ) {
con.connect();
}
}
{code}
which ends up in
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/listeners/CDKOpenshiftUtility.java#L93}
String dockerReg = env.getDockerRegistry();
((Connection)con).setExtendedProperty(ICommonAttributes.IMAGE_REGISTRY_URL_KEY, dockerReg);
{code}
but the registry is *null*
> Can't find CDK for registry discovery when 2 connections are defined for CDK
> ----------------------------------------------------------------------------
>
> Key: JBIDE-25046
> URL: https://issues.jboss.org/browse/JBIDE-25046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Jeff MAURY
> Assignee: Rob Stryker
> Labels: cdk, cdk_server_adapter_, explorer, openshift, openshift_v3
> Fix For: 4.5.x
>
>
> EXEC: define an Openshift connection for CDK/admin
> EXEC: define an Openshift connection for CDK/developer
> EXEC: define a CDK3 server
> EXEC: start the CDK 3 server
> ASSERT: the CDK/admin OS3 connection is updated (registry not empty)
> ASSERT: the CDK/developer OS3 connection is not updated (registry empty)
> EXEC: on the CDK/developer OS3 connection, click the DIscover buttoon
> ASSERT: the registry URL is updated, not the error dialog is displayed
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25046) Can't find CDK for registry discovery when 2 connections are defined for CDK
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-25046:
------------------------------------------
Matching the fact that "Discover" doesnt work for me is that I see an update of the connection being executed at
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/listeners/ConfigureDependentFrameworksListener.java#L107}
private void configureOpenshift(IServer server, ServiceManagerEnvironment adb) {
CDKOpenshiftUtility util = new CDKOpenshiftUtility();
IConnection con = util.findExistingOpenshiftConnection(server, adb);
if( con == null ) {
con = util.createOpenshiftConnection(adb);
} else {
util.updateOpenshiftConnection(adb, con);
}
if( con != null ) {
con.connect();
}
}
{code}
which ends up in
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/listeners/CDKOpenshiftUtility.java#L93}
String dockerReg = env.getDockerRegistry();
((Connection)con).setExtendedProperty(ICommonAttributes.IMAGE_REGISTRY_URL_KEY, dockerReg);
{code}
but the registry is *null*
> Can't find CDK for registry discovery when 2 connections are defined for CDK
> ----------------------------------------------------------------------------
>
> Key: JBIDE-25046
> URL: https://issues.jboss.org/browse/JBIDE-25046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Jeff MAURY
> Assignee: Rob Stryker
> Labels: cdk, cdk_server_adapter_, explorer, openshift, openshift_v3
> Fix For: 4.5.x
>
>
> EXEC: define an Openshift connection for CDK/admin
> EXEC: define an Openshift connection for CDK/developer
> EXEC: define a CDK3 server
> EXEC: start the CDK 3 server
> ASSERT: the CDK/admin OS3 connection is updated (registry not empty)
> ASSERT: the CDK/developer OS3 connection is not updated (registry empty)
> EXEC: on the CDK/developer OS3 connection, click the DIscover buttoon
> ASSERT: the registry URL is updated, not the error dialog is displayed
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24439) Block PRs for merge untill the Jenkins build is successful (protected branches)
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24439?page=com.atlassian.jira.plugi... ]
Nick Boldt closed JBIDE-24439.
------------------------------
Resolution: Rejected
Closing rejected. Won't do.
> Block PRs for merge untill the Jenkins build is successful (protected branches)
> -------------------------------------------------------------------------------
>
> Key: JBIDE-24439
> URL: https://issues.jboss.org/browse/JBIDE-24439
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: LATER
>
>
> As discussed in this thread [1], we'd like to implement *Protected Branches* and
> *Required Status Checks* [2] for some jbosstools-* projects.
> [1] http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
> [2] https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
> We will therefore need to document some requirements in jbosstools-devdoc about how to properly submit PRs when version-bumping is required:
> {quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.
> {quote}
> And we need to decide if we want to do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.
> [~jeffmaury] as project lead can you state which project(s) you'd like to see changed in github, and which ones should be changed as such:
> * jbosstools-_____
> ** Protected Branch = master
> ** Required Status Check(s) = ....? (which checks do we want)
> ** PR reviews required = [true/false]
> From that list of projects / requirements, we can then create subtask JIRAs to track the workj & the changes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt closed JBIDE-24671.
------------------------------
Assignee: Andre Dietisheim (was: Nick Boldt)
Resolution: Rejected
Closing rejected. Won't do.
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.AM2
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Fix Version/s: 4.5.1.AM2
(was: LATER)
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.5.1.AM2
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months