[JBoss JIRA] (JBIDE-25547) Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25547?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25547:
-------------------------------------
Attachment: connection-wizard.png
> Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
> --------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25547
> URL: https://issues.jboss.org/browse/JBIDE-25547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Fix For: 4.5.x
>
> Attachments: connection-wizard.png
>
>
> # ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
> # EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
> (this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
> # EXEC: launch connection wizard
> # EXEC: provide server url and authentication means
> # ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
> Result:
> You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
> Expected result:
> Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25547) Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25547?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25547:
-------------------------------------
Description:
# ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
# EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
(this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
# EXEC: launch connection wizard
# EXEC: provide server url and authentication means
# ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
!connection-wizard.png!
Result:
You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
Expected result:
Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
was:
# ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
# EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
(this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
# EXEC: launch connection wizard
# EXEC: provide server url and authentication means
# ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
Result:
You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
Expected result:
Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
> Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
> --------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25547
> URL: https://issues.jboss.org/browse/JBIDE-25547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Fix For: 4.5.x
>
> Attachments: connection-wizard.png
>
>
> # ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
> # EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
> (this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
> # EXEC: launch connection wizard
> # EXEC: provide server url and authentication means
> # ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
> !connection-wizard.png!
> Result:
> You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
> Expected result:
> Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25547) Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-25547:
----------------------------------------
Summary: Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
Key: JBIDE-25547
URL: https://issues.jboss.org/browse/JBIDE-25547
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.2.AM3
Reporter: Andre Dietisheim
# ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
# EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
(this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
# EXEC: launch connection wizard
# EXEC: provide server url and authentication means
# ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
Result:
You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
Expected result:
Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25547) Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25547?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25547:
-------------------------------------
Fix Version/s: 4.5.x
> Connection wizard: cannot save connection if "oc location" in preferences is invalid unless you override
> --------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25547
> URL: https://issues.jboss.org/browse/JBIDE-25547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Fix For: 4.5.x
>
>
> # ASSERT: make sure that you have the location to the oc binary set in OpenShift 3 preferences JBoss Tools > OpenShift 3 > 'oc' executable location
> # EXEC: rename the oc (that your preferences point to) so that the preferences value gets invalid
> (this happens if you setup a new cdk since you have to kill your .minishift and the path to the oc contains a folder named after the version of it: ex. ~/.minishift/cache/oc/v3.6.173.0.21/oc)
> # EXEC: launch connection wizard
> # EXEC: provide server url and authentication means
> # ASSERT: "Finish" is still disabled, an error about oc location is show in the title area
> Result:
> You cannot save your connection unless you override the oc location for this connection. I order to correct the preferences I have to cancel the wizard and go to the preferences
> Expected result:
> Either allow saving the connection even with an invalid oc location or allow to get to the preferences.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25546) Explorer: context menu has "Delete Resource" available even if there's nothing selected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25546?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-25546 at 1/8/18 9:08 AM:
------------------------------------------------------------------
I think that the delete resource entry in the context menu is visible because the handler for it is active if the properties view is active:
https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/or...
{code:title=org.jboss.tools.openshift.ui/plugin.xml}
<handler
class="org.jboss.tools.openshift.internal.ui.handler.DeleteResourceHandler"
commandId="org.eclipse.ui.edit.delete">
<activeWhen>
<or>
<with variable="activePartId">
<equals value="org.eclipse.ui.views.PropertySheet" />
</with>
<with
variable="selection">
<iterate>
<and>
<adapt type="com.openshift.restclient.model.IResource" />
</and>
</iterate>
</with>
</or>
</activeWhen>
</handler>
{code}
was (Author: adietish):
I think that the delete resource entry in the context menu is visible because the handler for it is active if the properties view is active:
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/plugin.xml#L1115}
<handler
class="org.jboss.tools.openshift.internal.ui.handler.DeleteResourceHandler"
commandId="org.eclipse.ui.edit.delete">
<activeWhen>
<or>
<with variable="activePartId">
<equals value="org.eclipse.ui.views.PropertySheet" />
</with>
<with
variable="selection">
<iterate>
<and>
<adapt type="com.openshift.restclient.model.IResource" />
</and>
</iterate>
</with>
</or>
</activeWhen>
</handler>
{code}
> Explorer: context menu has "Delete Resource" available even if there's nothing selected
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-25546
> URL: https://issues.jboss.org/browse/JBIDE-25546
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: explorer
> Fix For: 4.5.x
>
> Attachments: explorer-context-menu.png
>
>
> # ASSERT: have Properties view visible
> # ASSERT: have nothing selected in OpenShift Explorer
> # EXEC: open the context menu in OpenShift Explorer
> Result:
> !explorer-context-menu.png!
> The context menu in OpenShift Explorer holds New > Connection which is right, but also a "Delete Resource" entry which makes no sense at all
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25546) Explorer: context menu has "Delete Resource" available even if there's nothing selected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25546?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-25546 at 1/8/18 9:08 AM:
------------------------------------------------------------------
I think that the delete resource entry in the context menu is visible because the handler for it is active if the properties view is active:
{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/plugin.xml#L1115}
<handler
class="org.jboss.tools.openshift.internal.ui.handler.DeleteResourceHandler"
commandId="org.eclipse.ui.edit.delete">
<activeWhen>
<or>
<with variable="activePartId">
<equals value="org.eclipse.ui.views.PropertySheet" />
</with>
<with
variable="selection">
<iterate>
<and>
<adapt type="com.openshift.restclient.model.IResource" />
</and>
</iterate>
</with>
</or>
</activeWhen>
</handler>
{code}
was (Author: adietish):
I think that the delete resource entry in the context menu is visible because the handler for it is active if the properties view is active:
{code:title=plugin.xml in openshift.ui}
<handler
class="org.jboss.tools.openshift.internal.ui.handler.DeleteResourceHandler"
commandId="org.eclipse.ui.edit.delete">
<activeWhen>
<or>
<with variable="activePartId">
<equals value="org.eclipse.ui.views.PropertySheet" />
</with>
<with
variable="selection">
<iterate>
<and>
<adapt type="com.openshift.restclient.model.IResource" />
</and>
</iterate>
</with>
</or>
</activeWhen>
</handler>
{code}
> Explorer: context menu has "Delete Resource" available even if there's nothing selected
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-25546
> URL: https://issues.jboss.org/browse/JBIDE-25546
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: explorer
> Fix For: 4.5.x
>
> Attachments: explorer-context-menu.png
>
>
> # ASSERT: have Properties view visible
> # ASSERT: have nothing selected in OpenShift Explorer
> # EXEC: open the context menu in OpenShift Explorer
> Result:
> !explorer-context-menu.png!
> The context menu in OpenShift Explorer holds New > Connection which is right, but also a "Delete Resource" entry which makes no sense at all
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25546) Explorer: context menu has "Delete Resource" available even if there's nothing selected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25546?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-25546:
------------------------------------------
I think that the delete resource entry in the context menu is visible because the handler for it is active if the properties view is active:
{code:title=plugin.xml in openshift.ui}
<handler
class="org.jboss.tools.openshift.internal.ui.handler.DeleteResourceHandler"
commandId="org.eclipse.ui.edit.delete">
<activeWhen>
<or>
<with variable="activePartId">
<equals value="org.eclipse.ui.views.PropertySheet" />
</with>
<with
variable="selection">
<iterate>
<and>
<adapt type="com.openshift.restclient.model.IResource" />
</and>
</iterate>
</with>
</or>
</activeWhen>
</handler>
{code}
> Explorer: context menu has "Delete Resource" available even if there's nothing selected
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-25546
> URL: https://issues.jboss.org/browse/JBIDE-25546
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: explorer
> Fix For: 4.5.x
>
> Attachments: explorer-context-menu.png
>
>
> # ASSERT: have Properties view visible
> # ASSERT: have nothing selected in OpenShift Explorer
> # EXEC: open the context menu in OpenShift Explorer
> Result:
> !explorer-context-menu.png!
> The context menu in OpenShift Explorer holds New > Connection which is right, but also a "Delete Resource" entry which makes no sense at all
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25546) Explorer: context menu has "Delete Resource" available even if there's nothing selected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25546?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25546:
-------------------------------------
Labels: explorer (was: )
> Explorer: context menu has "Delete Resource" available even if there's nothing selected
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-25546
> URL: https://issues.jboss.org/browse/JBIDE-25546
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.2.AM3
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: explorer
> Fix For: 4.5.x
>
> Attachments: explorer-context-menu.png
>
>
> # ASSERT: have Properties view visible
> # ASSERT: have nothing selected in OpenShift Explorer
> # EXEC: open the context menu in OpenShift Explorer
> Result:
> !explorer-context-menu.png!
> The context menu in OpenShift Explorer holds New > Connection which is right, but also a "Delete Resource" entry which makes no sense at all
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (JBIDE-25546) Explorer: context menu has "Delete Resource" available even if there's nothing selected
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-25546:
----------------------------------------
Summary: Explorer: context menu has "Delete Resource" available even if there's nothing selected
Key: JBIDE-25546
URL: https://issues.jboss.org/browse/JBIDE-25546
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.2.AM3
Reporter: Andre Dietisheim
Priority: Minor
Attachments: explorer-context-menu.png
# ASSERT: have Properties view visible
# ASSERT: have nothing selected in OpenShift Explorer
# EXEC: open the context menu in OpenShift Explorer
Result:
The context menu in OpenShift Explorer holds New > Connection which is right, but also a "Delete Resource" entry which makes no sense at all
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months