[JBoss JIRA] (JBIDE-25829) Error when you cancel minishift location selection while creating cdk server
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25829?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-25829.
---------------------------------
Verified in devstudio-11.3.0.AM3-v20180322-1027-B2194-installer-standalone.jar
> Error when you cancel minishift location selection while creating cdk server
> ----------------------------------------------------------------------------
>
> Key: JBIDE-25829
> URL: https://issues.jboss.org/browse/JBIDE-25829
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.3.AM3
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
>
> I just noticed there is an error when you start the New Server dialog, select cdk 3.2+ and on the next page you first try to Browse for the minishift binary and then you change your mind and cancel that window.
> {code}
> Unhandled event loop exception
> java.lang.NullPointerException
> at java.io.File.<init>(File.java:277)
> at org.jboss.tools.openshift.cdk.server.ui.internal.CDK3ServerWizardFragment.kickValidationJob(CDK3ServerWizardFragment.java:218)
> at org.jboss.tools.openshift.cdk.server.ui.internal.CDK3ServerWizardFragment.access$3(CDK3ServerWizardFragment.java:214)
> at org.jboss.tools.openshift.cdk.server.ui.internal.CDK3ServerWizardFragment$3.widgetSelected(CDK3ServerWizardFragment.java:197)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4258)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1502)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1525)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1510)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1314)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4082)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3699)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
> at org.eclipse.jface.window.Window.open(Window.java:794)
> at org.eclipse.wst.server.ui.internal.actions.LaunchWizardAction.run(LaunchWizardAction.java:58)
> at org.eclipse.jface.action.Action.runWithEvent(Action.java:473)
> at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:565)
> at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:397)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4258)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1502)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1525)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1510)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1314)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4082)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3699)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1150)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1039)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-25835) Cannot download/install cdk-runtime
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25835?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-25835:
----------------------------------
Sprint: (was: devex #147 April 2018)
> Cannot download/install cdk-runtime
> -----------------------------------
>
> Key: JBIDE-25835
> URL: https://issues.jboss.org/browse/JBIDE-25835
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.2.AM3
> Environment: MacOSX
> Win10
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Labels: download_runtimes_wizard
> Fix For: 4.5.3.AM3
>
> Attachments: image-2018-03-21-15-13-35-753.png
>
>
> steps:
> # EXEC: Ctrl + 3 and provide "Runtime" into the filter field, choose *Download Runtimes*
> # EXEC: choose CDK v3.3.0, hit "Next"
> # ASSERT: credentials page shows up
> # EXEC: provide credentials, hit "Next"
> # ASSERT: license page shows up
> # EXEC: accept it, hit "Next"
> # ASSERT: "Download Runtime" page shows up
> # EXEC: confirm suggested values, hit "Finish"
> # ASSERT: download is triggered, is progressing.
> Result:
> Once the download is finished, an error shows up:
> !image-2018-03-21-15-13-35-753.png!
> If you verify the destination, you see that it's actually a file (while the dialog talks of a folder):
> {code}
> $ ls -l cdk-3.3.0-1-minishift-darwin-amd64
> -rwxr--r-- 1 adietish staff 461M Mar 21 14:52 cdk-3.3.0-1-minishift-darwin-amd64
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-25835) Cannot download/install cdk-runtime
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25835?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-25835.
---------------------------------
Closing in favor of the new issue.
> Cannot download/install cdk-runtime
> -----------------------------------
>
> Key: JBIDE-25835
> URL: https://issues.jboss.org/browse/JBIDE-25835
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.2.AM3
> Environment: MacOSX
> Win10
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Labels: download_runtimes_wizard
> Fix For: 4.5.3.AM3
>
> Attachments: image-2018-03-21-15-13-35-753.png
>
>
> steps:
> # EXEC: Ctrl + 3 and provide "Runtime" into the filter field, choose *Download Runtimes*
> # EXEC: choose CDK v3.3.0, hit "Next"
> # ASSERT: credentials page shows up
> # EXEC: provide credentials, hit "Next"
> # ASSERT: license page shows up
> # EXEC: accept it, hit "Next"
> # ASSERT: "Download Runtime" page shows up
> # EXEC: confirm suggested values, hit "Finish"
> # ASSERT: download is triggered, is progressing.
> Result:
> Once the download is finished, an error shows up:
> !image-2018-03-21-15-13-35-753.png!
> If you verify the destination, you see that it's actually a file (while the dialog talks of a folder):
> {code}
> $ ls -l cdk-3.3.0-1-minishift-darwin-amd64
> -rwxr--r-- 1 adietish staff 461M Mar 21 14:52 cdk-3.3.0-1-minishift-darwin-amd64
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-25835) Cannot download/install cdk-runtime
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25835?page=com.atlassian.jira.plugi... ]
Martin Malina resolved JBIDE-25835.
-----------------------------------
Fix Version/s: 4.5.3.AM3
(was: 4.5.3.Final)
Resolution: Done
I'm gonna mark this as resolved because the error is gone now. But it still doesn't work properly IMO. The server adapter is added, but minishift binary is not filled in. I created a new JIRA for that here: JBIDE-25858
> Cannot download/install cdk-runtime
> -----------------------------------
>
> Key: JBIDE-25835
> URL: https://issues.jboss.org/browse/JBIDE-25835
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.2.AM3
> Environment: MacOSX
> Win10
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Labels: download_runtimes_wizard
> Fix For: 4.5.3.AM3
>
> Attachments: image-2018-03-21-15-13-35-753.png
>
>
> steps:
> # EXEC: Ctrl + 3 and provide "Runtime" into the filter field, choose *Download Runtimes*
> # EXEC: choose CDK v3.3.0, hit "Next"
> # ASSERT: credentials page shows up
> # EXEC: provide credentials, hit "Next"
> # ASSERT: license page shows up
> # EXEC: accept it, hit "Next"
> # ASSERT: "Download Runtime" page shows up
> # EXEC: confirm suggested values, hit "Finish"
> # ASSERT: download is triggered, is progressing.
> Result:
> Once the download is finished, an error shows up:
> !image-2018-03-21-15-13-35-753.png!
> If you verify the destination, you see that it's actually a file (while the dialog talks of a folder):
> {code}
> $ ls -l cdk-3.3.0-1-minishift-darwin-amd64
> -rwxr--r-- 1 adietish staff 461M Mar 21 14:52 cdk-3.3.0-1-minishift-darwin-amd64
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-25858) Minishift binary is not set up after CDK runtime download
by Martin Malina (JIRA)
Martin Malina created JBIDE-25858:
-------------------------------------
Summary: Minishift binary is not set up after CDK runtime download
Key: JBIDE-25858
URL: https://issues.jboss.org/browse/JBIDE-25858
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime-detection
Affects Versions: 4.5.3.AM3
Reporter: Martin Malina
Assignee: Rob Stryker
This is a followup of JBIDE-25835 .
Recently a new feature was added - cdk can be downloaded directly from the IDE now.
As with other runtimes, there are two main paths you can take:
a) New Server -> Download
b) Preferences -> Runtime Detection -> Download
tl;dr: b) doesn't work properly with cdk because minishift binary is still not set after the download.
There is quite a big difference between a) and b). With a), you are adding a server manually and once your download is finished, the correct path is predefined for you. Runtime detection is not involved.
With b), the server is downloaded, extracted and then the path is added to runtime detection which is in turn run. This will result in the new server being detected and added.
Now cdk should theoretically support both of these paths. a) works - you're in the middle of adding a cdk server manually, you invoke the download and once that's done, the minishift binary field is filled properly for you.
But b) doesn't work properly for cdk, because runtime detection for cdk is built around your minishift home and not the minishift binary path. (I don't really know why that's the case, but I guess you had a good reason for it.) So when you do b), cdk binary is downloaded, but what's added to runtime detection is ~/.minishift (or $MINISHIFT_HOME if set). The result is that the cdk server adapter is added once the download is finished, but the minishift binary remains empty. So the usefulness of this feature is questionable.
Maybe you will say that there is no way to fix this. I hope you will at least agree that this is not ideal and b) doesn't really work properly right now.
I don't know what the proper solution for this is but let me start with a question: Wouldn't it make sense to change runtime detection of cdk so that it uses the minishift binary as the main path? What's stopping us from doing that?
Sorry for the lengthy description, I felt I needed to explain the whole context here.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months