[JBoss JIRA] (JBIDE-25753) Add links for downloading minishift and cdk in New Server Adapter wizard
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25753?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25753:
-------------------------------------
I've fixed the disclaimer stuff. I needed to make a small change in jbt-server.
So to be absolutely clear, to test this, you need to use the newest commits from jbosstools-base, and jbosstools-server, and this PR. Then you should see the correct behavior.
> Add links for downloading minishift and cdk in New Server Adapter wizard
> ------------------------------------------------------------------------
>
> Key: JBIDE-25753
> URL: https://issues.jboss.org/browse/JBIDE-25753
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, server
> Affects Versions: 4.5.3.AM2
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
> Attachments: cdk-dl-error.png
>
>
> In "New Server Adapter" wizard should be buttons/links to download minishift/cdk binaries or similar wizard as it is done for EAP/WildFly servers runtimes.
> WDYT [~adietish] [~jeffmaury] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-25753) Add links for downloading minishift and cdk in New Server Adapter wizard
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25753?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25753:
-------------------------------------
I think you didn't update from jbosstools-base, [~mmalina]. I replicated your bug when I tried it, and it has been fixed. The permissions were also changed (you can see that in the commit). Previously I was changing permissions on the wrong file (the file in the temporary folder, not the file in the destination folder) after having already copied it over.
So I believe strongly:
1) The file now gets downloaded to the tmp folder you chose
2) The file gets renamed to / moved to the real destination folder
3) The file permissions are then changed, and the versioning validation works as expected.
Please try this again with a new build of jbt-base.
As for the setup-cdk, well... I'd prefer a new issue for that. I don't necessarily want this to be part of the download-runtimes api. We'll need to investigate a better solution for setup-cdk.
But I am very convinced the patch is now working as expected. (I'll look into the community messaging real quick)
> Add links for downloading minishift and cdk in New Server Adapter wizard
> ------------------------------------------------------------------------
>
> Key: JBIDE-25753
> URL: https://issues.jboss.org/browse/JBIDE-25753
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, server
> Affects Versions: 4.5.3.AM2
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
> Attachments: cdk-dl-error.png
>
>
> In "New Server Adapter" wizard should be buttons/links to download minishift/cdk binaries or similar wizard as it is done for EAP/WildFly servers runtimes.
> WDYT [~adietish] [~jeffmaury] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-25753) Add links for downloading minishift and cdk in New Server Adapter wizard
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25753?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-25753:
---------------------------------------
[~rob.stryker], I tried the latest update (commit 3f00d10) and I still have the same problem.
!cdk-dl-error.png!
Also, keep in mind the other issue I mentioned too - that the binary will be read only. And then what about setup-cdk? Shall I create another jira for that? Because if we want this to be useful, then we should strive to have the full workflow supported directly in Eclipse, right? What's the point of downloading in Eclipse if you then have to go to CLI and run minishift setup-cdk? What do you think?
> Add links for downloading minishift and cdk in New Server Adapter wizard
> ------------------------------------------------------------------------
>
> Key: JBIDE-25753
> URL: https://issues.jboss.org/browse/JBIDE-25753
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, server
> Affects Versions: 4.5.3.AM2
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
> Attachments: cdk-dl-error.png
>
>
> In "New Server Adapter" wizard should be buttons/links to download minishift/cdk binaries or similar wizard as it is done for EAP/WildFly servers runtimes.
> WDYT [~adietish] [~jeffmaury] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-25753) Add links for downloading minishift and cdk in New Server Adapter wizard
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25753?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-25753:
---------------------------------------
[~rob.stryker], I have another comment/concern: "Warning - this is a community project." It's not really correct. It is a product, but still no formal support. I checked what we say for EAP and we don't say anything there :) So maybe we don't need that bit?
> Add links for downloading minishift and cdk in New Server Adapter wizard
> ------------------------------------------------------------------------
>
> Key: JBIDE-25753
> URL: https://issues.jboss.org/browse/JBIDE-25753
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, server
> Affects Versions: 4.5.3.AM2
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
>
> In "New Server Adapter" wizard should be buttons/links to download minishift/cdk binaries or similar wizard as it is done for EAP/WildFly servers runtimes.
> WDYT [~adietish] [~jeffmaury] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-25753) Add links for downloading minishift and cdk in New Server Adapter wizard
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25753?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25753:
-------------------------------------
[~mmalina] Fixed it. Please re-test Monday morning. There was an error in the base code. I had it working here but forgot to commit that change since it was another repo.
> Add links for downloading minishift and cdk in New Server Adapter wizard
> ------------------------------------------------------------------------
>
> Key: JBIDE-25753
> URL: https://issues.jboss.org/browse/JBIDE-25753
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, server
> Affects Versions: 4.5.3.AM2
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Fix For: 4.5.3.AM3
>
>
> In "New Server Adapter" wizard should be buttons/links to download minishift/cdk binaries or similar wizard as it is done for EAP/WildFly servers runtimes.
> WDYT [~adietish] [~jeffmaury] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-20569) OpenShift Explorer : "Import Application" menu is confusing
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20569?page=com.atlassian.jira.plugi... ]
Josef Kopriva commented on JBIDE-20569:
---------------------------------------
[~adietish] looks good. +1 to moving Deploy Latest and Scale to Miscellanous item.
I would also suggest to move "Server Adapter" to the "Import Openshift...". I would say its one of the core features so in my opinion it deserves better place.
> OpenShift Explorer : "Import Application" menu is confusing
> -----------------------------------------------------------
>
> Key: JBIDE-20569
> URL: https://issues.jboss.org/browse/JBIDE-20569
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.CR1
> Reporter: Fred Bricon
> Assignee: Andre Dietisheim
> Labels: explorer, ux
> Fix For: 4.5.3.AM3
>
> Attachments: existing-context-menu.png, import-application.png, new-context-menu-2.png, new-context-menu.png, project-explorer-context-menu.png
>
>
> [~sspeiche] finds the "Import Application" menu in OpenShift Explorer is confusing: does it mean import from eclipse to openshift or the other way around (it's the latter). Needs better wording.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-20569) OpenShift Explorer : "Import Application" menu is confusing
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20569?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-20569:
------------------------------------------
[~jeffmaury] [~jkopriva] +1 for those suggestions:
I'd move it to the block which currently holds *Deploy Latest* and *Scale* since it's more of a miscellanous item, so that we can keep the basic ordering (like it is in the Project Explorer)
* *New*
* *Show In*
* *Edit*
* *Delete*
* *Import*
* *Refresh*
* *Miscellaneous*
* *Properties*
!new-context-menu-2.@png!
[~jeffmaury] [~jkopriva]?
> OpenShift Explorer : "Import Application" menu is confusing
> -----------------------------------------------------------
>
> Key: JBIDE-20569
> URL: https://issues.jboss.org/browse/JBIDE-20569
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.CR1
> Reporter: Fred Bricon
> Assignee: Andre Dietisheim
> Labels: explorer, ux
> Fix For: 4.5.3.AM3
>
> Attachments: JBIDE-20569.bmpr, existing-context-menu.png, import-application.png, new-context-menu-2.png, new-context-menu.png, project-explorer-context-menu.png
>
>
> [~sspeiche] finds the "Import Application" menu in OpenShift Explorer is confusing: does it mean import from eclipse to openshift or the other way around (it's the latter). Needs better wording.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-20569) OpenShift Explorer : "Import Application" menu is confusing
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20569?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-20569 at 3/16/18 11:41 AM:
--------------------------------------------------------------------
[~jeffmaury] [~jkopriva] +1 for those suggestions:
I'd move it to the block which currently holds *Deploy Latest* and *Scale* since it's more of a miscellanous item, so that we can keep the basic ordering (like it is in the Project Explorer)
* *New*
* *Show In*
* *Edit*
* *Delete*
* *Import*
* *Refresh*
* *Miscellaneous*
* *Properties*
!new-context-menu-2.png!
[~jeffmaury] [~jkopriva]?
was (Author: adietish):
[~jeffmaury] [~jkopriva] +1 for those suggestions:
I'd move it to the block which currently holds *Deploy Latest* and *Scale* since it's more of a miscellanous item, so that we can keep the basic ordering (like it is in the Project Explorer)
* *New*
* *Show In*
* *Edit*
* *Delete*
* *Import*
* *Refresh*
* *Miscellaneous*
* *Properties*
!new-context-menu-2.@png!
[~jeffmaury] [~jkopriva]?
> OpenShift Explorer : "Import Application" menu is confusing
> -----------------------------------------------------------
>
> Key: JBIDE-20569
> URL: https://issues.jboss.org/browse/JBIDE-20569
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.CR1
> Reporter: Fred Bricon
> Assignee: Andre Dietisheim
> Labels: explorer, ux
> Fix For: 4.5.3.AM3
>
> Attachments: JBIDE-20569.bmpr, existing-context-menu.png, import-application.png, new-context-menu-2.png, new-context-menu.png, project-explorer-context-menu.png
>
>
> [~sspeiche] finds the "Import Application" menu in OpenShift Explorer is confusing: does it mean import from eclipse to openshift or the other way around (it's the latter). Needs better wording.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (JBIDE-20569) OpenShift Explorer : "Import Application" menu is confusing
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20569?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-20569:
-------------------------------------
Attachment: new-context-menu-2.png
> OpenShift Explorer : "Import Application" menu is confusing
> -----------------------------------------------------------
>
> Key: JBIDE-20569
> URL: https://issues.jboss.org/browse/JBIDE-20569
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.CR1
> Reporter: Fred Bricon
> Assignee: Andre Dietisheim
> Labels: explorer, ux
> Fix For: 4.5.3.AM3
>
> Attachments: JBIDE-20569.bmpr, existing-context-menu.png, import-application.png, new-context-menu-2.png, new-context-menu.png, project-explorer-context-menu.png
>
>
> [~sspeiche] finds the "Import Application" menu in OpenShift Explorer is confusing: does it mean import from eclipse to openshift or the other way around (it's the latter). Needs better wording.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months