[JBoss JIRA] (JBIDE-19412) Cleanup ConnectionURL usage for v3 connections
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19412?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-19412:
-------------------------------
Fix Version/s: 4.6.x
(was: 4.5.x)
> Cleanup ConnectionURL usage for v3 connections
> ----------------------------------------------
>
> Key: JBIDE-19412
> URL: https://issues.jboss.org/browse/JBIDE-19412
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.6.x
>
>
> In ConnectionsRegistry connections are stored by ConnectionURL. ConnectionURL is also used to persist v2 connections. v3 connections on the other hand are persisted in their very own json format. We need to clean this discrepany/inconsistency. We should either only use ConnectionURL for v2 connections or also store v3 connections in the ConnectionURL format.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-21201) TernError: No type found at the given position.
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21201?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-21201:
-------------------------------
Fix Version/s: 4.6.x
(was: 4.5.x)
> TernError: No type found at the given position.
> -----------------------------------------------
>
> Key: JBIDE-21201
> URL: https://issues.jboss.org/browse/JBIDE-21201
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: javascript, upstream
> Affects Versions: 4.3.0.Beta1
> Environment: tern 1.1.0
> Reporter: Pavol Srna
> Assignee: Victor Rubezhny
> Fix For: 4.6.x
>
>
> 1. Create JSF 1.2 Kick Start project
> 2. Open inputUserName.jsp in VPE
> 3. Click on 'user' text within <h:inputText> tag
> 4. Press F3 key
> {code}
> tern.TernException: TernError: No type found at the given position.
> at tern.server.DefaultResponseHandler.getData(DefaultResponseHandler.java:45)
> at tern.server.protocol.TernResultsProcessorsFactory.makeRequestAndProcess(TernResultsProcessorsFactory.java:43)
> at tern.eclipse.ide.internal.core.resources.IDETernServerAsyncReqProcessor.run(IDETernServerAsyncReqProcessor.java:104)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Caused by: tern.TernException: TernError: No type found at the given position.
> at tern.server.nodejs.NodejsTernHelper.makeRequest(NodejsTernHelper.java:86)
> at tern.server.nodejs.NodejsTernServer.makeRequest(NodejsTernServer.java:163)
> at tern.server.nodejs.NodejsTernServer.request(NodejsTernServer.java:127)
> at tern.server.protocol.TernResultsProcessorsFactory.makeRequestAndProcess(TernResultsProcessorsFactory.java:42)
> ... 2 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-24390) Items hidden by filter are excluded from installation
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24390?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-24390:
-------------------------------
Fix Version/s: 4.6.x
(was: 4.5.x)
> Items hidden by filter are excluded from installation
> -----------------------------------------------------
>
> Key: JBIDE-24390
> URL: https://issues.jboss.org/browse/JBIDE-24390
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.4.4.Final
> Reporter: Lukáš Valach
> Priority: Minor
> Fix For: 4.6.x
>
>
> Items which are hidden by filter won't be installed even if they are selected.
> For example:
> # Open Red Hat Central
> # Click "Select All"
> # Type into "Find" field "angular"
> # The only one item are now displayed and button "Install/Update (1)" shows that only one item are selected to be installed which isn't true. All items are still selected though only one of them are shown.
> # Click "Install/Update (1)" then you will see that only Angular is going to be installed.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-22756) Connection: various weirdness in token/password implementations
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22756?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-22756:
-------------------------------
Fix Version/s: 4.6.x
(was: 4.5.x)
> Connection: various weirdness in token/password implementations
> ---------------------------------------------------------------
>
> Key: JBIDE-22756
> URL: https://issues.jboss.org/browse/JBIDE-22756
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Andre Dietisheim
> Labels: connection
> Fix For: 4.6.x
>
>
> The lifecycle of the token is rather weird and needs a consistent logic:
> When connecting via wizard the token is set in the connection wizard:
> {code:title=ConnectionWizardPageModel#connect}
> ...
> try {
> IConnection connection = createConnection(connectionFactory, connectionAuthenticationProvider);
> ...
> {code}
> {code:title=ConnectionWizardPageModel#createConnection}
> ...
> if (authProvider != null) {
> authProvider.update(connection); // sets the token
> }
> ...
> {code}
> {code:title=BearTokenAuthenticationProvider#update}
> ...
> connection.setAuthScheme(IAuthorizationContext.AUTHSCHEME_OAUTH);
> connection.setToken(tokenObservable.getValue());
> connection.setRememberToken(rememberTokenObservable.getValue());
> ...
> {code}
> {code:title=Connection#connect}
> if(authorize()) {
> ...
> {code}
> {code:title=Connection#authorized}
> ...
> if (context.isAuthorized()) {
> String username = context.getUser().getName();
> String token = context.getToken();
> updateAuthorized(username, token);
> } else {
> ...
> {code}
> The token is then fetched from client and set to the connection
> {code:title=Connection#updateAuthorized}
> setToken(token);
> ...
> {code}
> and the password is cleared
> {code:Connectoin#savePasswordOrToken}
> } else if (IAuthorizationContext.AUTHSCHEME_OAUTH.equals(getAuthScheme())){
> boolean success = saveOrClear(SECURE_STORAGE_TOKEN_KEY, this.token, isRememberToken());
> if(success) {
> //Avoid second secure storage prompt.
> //Token is stored, password should be cleared.
> clearPassword();
> {code}
> I suspect the aim here is to clear existing password in secure storage if the user is switching password->token based auth (and vice versa)
> The opposite is then not fully congruent. The token is only cleared in secure storage, not in Connection instance var
> {code:title=Connection#savePasswordOrToken}
> if (IAuthorizationContext.AUTHSCHEME_BASIC.equals(getAuthScheme())) {
> boolean success = saveOrClear(SECURE_STORAGE_PASSWORD_KEY, this.password, isRememberPassword());
> if (success) {
> //Avoid second secure storage prompt.
> // Password is stored, token should be cleared.
> clearToken();
> }
> {code:Connection#clearToken}
> // dont clear the token instance var: JBIDE-22594
> setRememberToken(false);
> saveOrClear(SECURE_STORAGE_TOKEN_KEY, null, false);
> {code}
> I suspect that we should only clear in secure storage, not in the Connection instance as we see in JBIDE-22594 (for the opposite case where we dont clear the token in the Connection instance). But then one has to keep in mind that all auth is token based. Even if you auth via password initially, the auth is then switched to token based once the authorization succeeded and we got a token:
> {code:title=Connection#updateAuthorized}
> setToken(token);
> if (IAuthorizationContext.AUTHSCHEME_OAUTH.equalsIgnoreCase(getAuthScheme())) {
> setUsername(username);
> }
> // force auth strategy to token if authorized
> TokenAuthorizationStrategy tokenStrategy = new TokenAuthorizationStrategy(token, username);
> client.setAuthorizationStrategy(tokenStrategy);
> {code}
> Another issue is that the connection and the auth schemeare both stored in different classes. The connection is stored via
> {code:title=ConnectionPersistency#persist}
> preferences.saveConnections(connections.keySet().toArray(new String[] {}));
> ...
> {code}
> while the auth scheme is stored in Connection#saveAuthSchemePreference:
> {code:title=Connection#connect}
> saveAuthSchemePreference();
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JBIDE-17577) Wrong layout of Back and Forward buttons with GTK 3 and Java 8
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17577?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-17577:
-------------------------------
Fix Version/s: 4.6.x
(was: 4.5.x)
> Wrong layout of Back and Forward buttons with GTK 3 and Java 8
> --------------------------------------------------------------
>
> Key: JBIDE-17577
> URL: https://issues.jboss.org/browse/JBIDE-17577
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.Beta2
> Environment: JBDS 8.0.0 Beta2-v20140608-1040-B121
> Oracle JDK 1.8.0_05
> Fedora 20 64bit Gnome
> Reporter: Vlado Pakan
> Assignee: Ilya Buziuk
> Priority: Minor
> Fix For: 4.6.x
>
> Attachments: browsersimlayout.png
>
>
> 1. Select GTK3 in Windows > Preferences > BrowserSim/CordovaSim
> 2. Open BrowserSIm
> 3. Navigate BrowserSim to www.google.com
> ERROR: Once web page is fully loaded Back button has wrong layout and Forward buttons disappears
> !browsersimlayout.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months