[JBoss JIRA] (JBIDE-26098) Repair org.jboss.tools.stacks test failures in jbosstools_base-master job
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26098?page=com.atlassian.jira.plugi... ]
Ondrej Dockal updated JBIDE-26098:
----------------------------------
Description:
1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results).
2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin:
* org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
* org.yaml.snakeyaml; 1.10 -> 1.18
* org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
* org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
* org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
3. Run all stacks.tests available (only one test class was run)
4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)
5. Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
was:
org.jboss.tools.stacks needs to bump up a version while updating plugins to run all tests.
Have tests to be run on jenkins jbt-base master and pull request job and have green.
> Repair org.jboss.tools.stacks test failures in jbosstools_base-master job
> -------------------------------------------------------------------------
>
> Key: JBIDE-26098
> URL: https://issues.jboss.org/browse/JBIDE-26098
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: qa
> Affects Versions: 4.6.0.Final
> Reporter: Ondrej Dockal
> Assignee: Ondrej Dockal
> Fix For: 4.6.0.Final
>
>
> 1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results).
> 2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin:
> * org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
> * org.yaml.snakeyaml; 1.10 -> 1.18
> * org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
> * org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
> * org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
> 3. Run all stacks.tests available (only one test class was run)
> 4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)
> 5. Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-26098) Repair org.jboss.tools.stacks test failures in jbosstools_base-master job
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26098?page=com.atlassian.jira.plugi... ]
Ondrej Dockal updated JBIDE-26098:
----------------------------------
Description:
1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results).
2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin:
* org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
* org.yaml.snakeyaml; 1.10 -> 1.18
* org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
* org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
* org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
3. Run all stacks.tests available (only one test class was run)
4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)
5. Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
was:
1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results).
2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin:
* org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
* org.yaml.snakeyaml; 1.10 -> 1.18
* org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
* org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
* org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
3. Run all stacks.tests available (only one test class was run)
4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)
5. Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
> Repair org.jboss.tools.stacks test failures in jbosstools_base-master job
> -------------------------------------------------------------------------
>
> Key: JBIDE-26098
> URL: https://issues.jboss.org/browse/JBIDE-26098
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: qa
> Affects Versions: 4.6.0.Final
> Reporter: Ondrej Dockal
> Assignee: Ondrej Dockal
> Fix For: 4.6.0.Final
>
>
> 1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results).
> 2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin:
> * org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
> * org.yaml.snakeyaml; 1.10 -> 1.18
> * org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
> * org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
> * org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
> 3. Run all stacks.tests available (only one test class was run)
> 4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)
> 5. Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-26140) Remove unit testing related jars from SSP distribution
by Denis Golovin (JIRA)
Denis Golovin created JBIDE-26140:
-------------------------------------
Summary: Remove unit testing related jars from SSP distribution
Key: JBIDE-26140
URL: https://issues.jboss.org/browse/JBIDE-26140
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: stack-server-protocol
Reporter: Denis Golovin
Assignee: Rob Stryker
The size of zipped distribution is around 30MB. Could be less if unit test related jars like hamcrest or assertj are not included.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 6/22/18 6:48 PM:
-------------------------------------------------------------------
[~rob.stryker] I tracked the above down until I found an outdated map of the modules (that still had the old module name) in *JEEDeployableFactory*.
Here's the stacktrace for it:
{code}
JEEDeployableFactory(ProjectModuleFactoryDelegate).cacheModules(IProject) line: 53
JEEDeployableFactory(ProjectModuleFactoryDelegate).getModules(IProject) line: 265
ModuleFactory.getModules(IProject, IProgressMonitor) line: 140
ServerUtil.getModules(IProject) line: 98
OpenShiftServerUtils.findProjectModule(IProject) line: 289
OpenShiftPublishController.publishRootModule(IProgressMonitor, IProject, File) line: 60
OpenShiftPublishController.publishStart(IProgressMonitor) line: 53
OpenShiftServerBehaviour(CachedPublisherProfileBehavior).publishStart(IProgressMonitor) line: 47
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, IProgressMonitor) line: 942
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, List<IModule[]>, IProgressMonitor, IAdaptable) line: 774
Server.publishImpl(int, List<IModule[]>, IAdaptable, IProgressMonitor) line: 3182
Server.publish(int, IProgressMonitor) line: 1340
ResourceChangePublisher$MagicProjectChangeJob.autoPublish(IResourceChangeEvent) line: 248
ResourceChangePublisher$MagicProjectChangeJob.run(IProgressMonitor) line: 230
{code}
Looks like a bug in wtp, or do I miss something? Thoughts?
was (Author: adietish):
[~rob.stryker] I tracked the above down until I found in JEEDeployableFactory a map of the modules that didnt grasp the change. The map still contains the old module name that doesnt match what exists on disk (settings-file), wasn't updated.
Here's the stacktrace for it:
{code}
JEEDeployableFactory(ProjectModuleFactoryDelegate).cacheModules(IProject) line: 53
JEEDeployableFactory(ProjectModuleFactoryDelegate).getModules(IProject) line: 265
ModuleFactory.getModules(IProject, IProgressMonitor) line: 140
ServerUtil.getModules(IProject) line: 98
OpenShiftServerUtils.findProjectModule(IProject) line: 289
OpenShiftPublishController.publishRootModule(IProgressMonitor, IProject, File) line: 60
OpenShiftPublishController.publishStart(IProgressMonitor) line: 53
OpenShiftServerBehaviour(CachedPublisherProfileBehavior).publishStart(IProgressMonitor) line: 47
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, IProgressMonitor) line: 942
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, List<IModule[]>, IProgressMonitor, IAdaptable) line: 774
Server.publishImpl(int, List<IModule[]>, IAdaptable, IProgressMonitor) line: 3182
Server.publish(int, IProgressMonitor) line: 1340
ResourceChangePublisher$MagicProjectChangeJob.autoPublish(IResourceChangeEvent) line: 248
ResourceChangePublisher$MagicProjectChangeJob.run(IProgressMonitor) line: 230
{code}
Ideas?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22138:
------------------------------------------
[~rob.stryker] I tracked the above down until I found in JEEDeployableFactory a map of the modules that didnt grasp the change. The map still contains the old module name that doesnt match what exists on disk (settings-file), wasn't updated.
Here's the stacktrace for it:
{code}
JEEDeployableFactory(ProjectModuleFactoryDelegate).cacheModules(IProject) line: 53
JEEDeployableFactory(ProjectModuleFactoryDelegate).getModules(IProject) line: 265
ModuleFactory.getModules(IProject, IProgressMonitor) line: 140
ServerUtil.getModules(IProject) line: 98
OpenShiftServerUtils.findProjectModule(IProject) line: 289
OpenShiftPublishController.publishRootModule(IProgressMonitor, IProject, File) line: 60
OpenShiftPublishController.publishStart(IProgressMonitor) line: 53
OpenShiftServerBehaviour(CachedPublisherProfileBehavior).publishStart(IProgressMonitor) line: 47
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, IProgressMonitor) line: 942
OpenShiftServerBehaviour(ServerBehaviourDelegate).publish(int, List<IModule[]>, IProgressMonitor, IAdaptable) line: 774
Server.publishImpl(int, List<IModule[]>, IAdaptable, IProgressMonitor) line: 3182
Server.publish(int, IProgressMonitor) line: 1340
ResourceChangePublisher$MagicProjectChangeJob.autoPublish(IResourceChangeEvent) line: 248
ResourceChangePublisher$MagicProjectChangeJob.run(IProgressMonitor) line: 230
{code}
Ideas?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 6/22/18 6:37 PM:
-------------------------------------------------------------------
[~fbricon] yup, just found out ;)
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (.settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
This would correlate with the following:
I see .settings/org.eclipse.wst.common.component modifed to the new, correct module name, but {code}org.eclipse.wst.server.core.ServerUtil.getModules(p){code} still returning the old module name.
was (Author: adietish):
[~fbricon] yup, just found out ;)
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (.settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 6/22/18 6:19 PM:
-------------------------------------------------------------------
[~fbricon] yup, just found out ;)
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (.settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
was (Author: adietish):
[~fbricon] yup, just found out ;)
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22138:
------------------------------------------
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 6/22/18 6:18 PM:
-------------------------------------------------------------------
[~fbricon] yup, just found out ;)
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
was (Author: adietish):
[~rawb] Interestingly, I see the module name correctly changed in the filesystem (settings/org.eclipse.wst.common.component).
{code}
<?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0">
<wb-module deploy-name="hello">
<wb-resource deploy-path="/" source-path="/target/m2e-wtp/web-resources"/>
<wb-resource deploy-path="/" source-path="/src/main/webapp" tag="defaultRootSource"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/java"/>
<wb-resource deploy-path="/WEB-INF/classes" source-path="/src/main/resources"/>
<property name="java-output-path" value="/hello/target/classes"/>
<property name="context-root" value="hello"/>
</wb-module>
</project-modules>
{code}
Is this a refresh problem in the wtp "ModuleModifyWizard"?
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 9 months