[JBoss JIRA] (JBIDE-26089) Include org.eclipse.tips.feature in target platforms
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26089?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-26089:
------------------------------------
This close to the UI/feature/code freeze of devstudio 12.0.0.AM3 (which is June 13!), I don't think it's reasonable to try to create a new UX experience to merge usage/tips/RH Central/AERI opt-ins into a single dialog.
It's a good idea, I'm just not sure we have the bandwidth/people/priority to get this done in the 3 days remaining.
So... I'd rather we defer this until 12.1.0.AM1 so we have more time to tweak/hack/fix/UX it.
> Include org.eclipse.tips.feature in target platforms
> ----------------------------------------------------
>
> Key: JBIDE-26089
> URL: https://issues.jboss.org/browse/JBIDE-26089
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.6.0.AM2
> Reporter: Jeff MAURY
> Assignee: Nick Boldt
> Fix For: 4.6.0.AM3
>
>
> Photon brings a new tip of the day feature (through the org.eclipse.tips.feature). I would be nice to add it into the target platform and then in DevStudio
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (JBIDE-26089) Include org.eclipse.tips.feature in target platforms
by Bob Davis (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26089?page=com.atlassian.jira.plugi... ]
Bob Davis commented on JBIDE-26089:
-----------------------------------
Broadly speaking, I'm not a huge fan of pop-ups. And by that I mean I just don't like them.
How often does a user get presented with these? Is this first run only?
Is it possible to merge them all into a single "opt-in" panel that's shown on first run only - something like :
"Opt-in to:
[ ] share usage data
[ ] Show RH Central
[ ] etc.
[ ] etc.
Bob
> Include org.eclipse.tips.feature in target platforms
> ----------------------------------------------------
>
> Key: JBIDE-26089
> URL: https://issues.jboss.org/browse/JBIDE-26089
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.6.0.AM2
> Reporter: Jeff MAURY
> Assignee: Nick Boldt
> Fix For: 4.6.0.AM3
>
>
> Photon brings a new tip of the day feature (through the org.eclipse.tips.feature). I would be nice to add it into the target platform and then in DevStudio
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (JBIDE-26089) Include org.eclipse.tips.feature in target platforms
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26089?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-26089:
------------------------------------
Meanwhile in EPP, this was disabled for OOTB experience because it was too invasive / annoying.
https://dev.eclipse.org/mhonarc/lists/epp-dev/msg05092.html
You sure you want to add a 3rd popup in front of people? (opt-in for tracking, RH Central, & now the Tips). If you also install SpringIDE, that's another popup for their opt-in. And if you install devstudio into EPP, you get the opt-in dialog for AERI (both for Eclipse and JBoss).
[~rpdavis] [~rkratky] [~supriya.bharadwaj] your thoughts? (Aside: do we have a UX person we can ask?)
> Include org.eclipse.tips.feature in target platforms
> ----------------------------------------------------
>
> Key: JBIDE-26089
> URL: https://issues.jboss.org/browse/JBIDE-26089
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.6.0.AM2
> Reporter: Jeff MAURY
> Assignee: Nick Boldt
> Fix For: 4.6.0.AM3
>
>
> Photon brings a new tip of the day feature (through the org.eclipse.tips.feature). I would be nice to add it into the target platform and then in DevStudio
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (JBIDE-26089) Include org.eclipse.tips.feature in target platforms
by Jeff MAURY (JIRA)
Jeff MAURY created JBIDE-26089:
----------------------------------
Summary: Include org.eclipse.tips.feature in target platforms
Key: JBIDE-26089
URL: https://issues.jboss.org/browse/JBIDE-26089
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: target-platform
Affects Versions: 4.6.0.AM2
Reporter: Jeff MAURY
Assignee: Nick Boldt
Fix For: 4.6.0.AM3
Photon brings a new tip of the day feature (through the org.eclipse.tips.feature). I would be nice to add it into the target platform and then in DevStudio
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (JBIDE-26086) SSP server does not send error codes for bad requests
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26086?page=com.atlassian.jira.plugi... ]
Rob Stryker edited comment on JBIDE-26086 at 6/7/18 1:05 PM:
-------------------------------------------------------------
Steps to reproduce:
1) Start server
2) Switch to a new terminal
3) type telnet 127.0.0.1 27511
4) Paste following block:
{code}
GET / HTTP/1.1
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Host: localhost:27511
{code}
6) Note the server has error output
{code}
Jun 07, 2018 1:02:55 PM org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer fireError
SEVERE: Missing header Content-Length in input "GET / HTTP/1.1
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Host: localhost:27511
"
java.lang.IllegalStateException: Missing header Content-Length in input "GET / HTTP/1.1
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Host: localhost:27511
"
at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:89)
at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:95)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
{code}
7) Note the telnet client receives no response at all from the server.
was (Author: rob.stryker):
Steps to reproduce:
1) Start server
2) Switch to a new terminal
3) type telnet 127.0.0.1 27511
4) Paste following block:
{code}
GET / HTTP/1.1
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Host: localhost:27511
{code}
6) Note the server has error output
7) Note the telnet client receives no response at all from the server.
> SSP server does not send error codes for bad requests
> -----------------------------------------------------
>
> Key: JBIDE-26086
> URL: https://issues.jboss.org/browse/JBIDE-26086
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: stack-server-protocol
> Affects Versions: 4.6.0.AM3
> Reporter: Jan Richter
> Assignee: Rob Stryker
>
> Sending a request the server does not like produces no response, it is simply logged on the server side and the client is not notified of what happened. Something like a code 400 would be appreciated.
> For example, initiating a connection with no content-length header simply logs the following on the server side, but the client is stuck waiting.
> {noformat}java.lang.IllegalStateException: Missing header Content-Length in input "GET / HTTP/1.1
> Sec-WebSocket-Version: 13
> Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
> Connection: Upgrade
> Upgrade: websocket
> Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
> Host: localhost:27511
> "
> at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:89)
> at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:95)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748){noformat}
> This is most likely a 'feature' of lsp4j, thoughts?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (JBIDE-26086) SSP server does not send error codes for bad requests
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26086?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-26086:
-------------------------------------
Steps to reproduce:
1) Start server
2) Switch to a new terminal
3) type telnet 127.0.0.1 27511
4) Paste following block:
{code}
GET / HTTP/1.1
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Host: localhost:27511
{code}
6) Note the server has error output
7) Note the telnet client receives no response at all from the server.
> SSP server does not send error codes for bad requests
> -----------------------------------------------------
>
> Key: JBIDE-26086
> URL: https://issues.jboss.org/browse/JBIDE-26086
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: stack-server-protocol
> Affects Versions: 4.6.0.AM3
> Reporter: Jan Richter
> Assignee: Rob Stryker
>
> Sending a request the server does not like produces no response, it is simply logged on the server side and the client is not notified of what happened. Something like a code 400 would be appreciated.
> For example, initiating a connection with no content-length header simply logs the following on the server side, but the client is stuck waiting.
> {noformat}java.lang.IllegalStateException: Missing header Content-Length in input "GET / HTTP/1.1
> Sec-WebSocket-Version: 13
> Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
> Connection: Upgrade
> Upgrade: websocket
> Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
> Host: localhost:27511
> "
> at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:89)
> at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:95)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748){noformat}
> This is most likely a 'feature' of lsp4j, thoughts?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months