[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 8/3/18 11:09 AM:
-------------------------------------------------------------------
[~rob.stryker] m2e-wtp sets the module name in the following method: [AbstractProjectConfiguratorDelegate#configureDeployedName|https://github....]
I see it being called, which then causes the file to change on disk.
This then causes *J2EEModuleVirtualComponent* to clear it's cache:
{code}
J2EEModuleVirtualComponent(VirtualComponent).clearCache() line: 721
J2EEModuleVirtualComponent.clearCache() line: 512
J2EEModuleVirtualComponent(VirtualComponent).resourceChanged(Resource) line: 95
VirtualComponent$ResourceAdapter.notifyChanged(Notification) line: 78
WTPModulesResource(TranslatorResourceImpl).eNotify(Notification) line: 444
WTPModulesResource(ResourceImpl).setModified(boolean) line: 1867
WTPModulesResource(TranslatorResourceImpl).doSave(OutputStream, Map) line: 192
WTPModulesResource(ResourceImpl).save(OutputStream, Map<?,?>) line: 1475
WTPModulesResource(ResourceImpl).save(Map<?,?>) line: 1044
WTPModulesResource(ReferencedXMIResourceImpl).save(Map) line: 377
WTPModulesResource(TranslatorResourceImpl).save(Map) line: 167
ModuleStructuralModel(EditModel).primSaveResource(Resource) line: 1303
ModuleStructuralModel(EditModel).saveResource(Resource) line: 1334
ModuleStructuralModel(EditModel).primSave(IProgressMonitor) line: 1269
EditModel$1.run(IProgressMonitor) line: 373
Workspace.run(ICoreRunnable, ISchedulingRule, int, IProgressMonitor) line: 2289
Workspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor) line: 2316
ModuleStructuralModel.runSaveOperation(IWorkspaceRunnable, IProgressMonitor) line: 310
ModuleStructuralModel(EditModel).save(IProgressMonitor, Object) line: 376
ModuleStructuralModel.saveIfNecessary(IProgressMonitor, Object) line: 392
StructureEdit.saveIfNecessary(IProgressMonitor) line: 397
WebProjectConfiguratorDelegate(AbstractProjectConfiguratorDelegate).configureDeployedName(IProject, String) line: 189
{code}
But I dont see *JEEDeployableFactory#clearCache* being called. Btw. I dont see JEEDeployableFactory listening to resource change. Here are the listeners that I see registered:
* org.eclipse.emf.common.notify.impl.AdapterImpl@21197771
* org.eclipse.wst.common.internal.emfworkbench.integration.EditModel$ResourceAdapter@6bc55154
* org.eclipse.wst.common.internal.emfworkbench.WorkbenchResourceHelper$FileAdapter@3543d4e1
* EMF2DOMAdapterImpl(#document,WTPModulesResource), org.eclipse.wst.common.componentcore.internal.resources.VirtualComponent$ResourceAdapter@2e185af0
was (Author: adietish):
[~rob.stryker] m2e-wtp sets the module name in the following method: [AbstractProjectConfiguratorDelegate#configureDeployedName|https://github....]
I see it being called, which then causes the file to change on disk.
This then causes *J2EEModuleVirtualComponent* to clear it's cache:
{code}
J2EEModuleVirtualComponent(VirtualComponent).clearCache() line: 721
J2EEModuleVirtualComponent.clearCache() line: 512
J2EEModuleVirtualComponent(VirtualComponent).resourceChanged(Resource) line: 95
VirtualComponent$ResourceAdapter.notifyChanged(Notification) line: 78
WTPModulesResource(TranslatorResourceImpl).eNotify(Notification) line: 444
WTPModulesResource(ResourceImpl).setModified(boolean) line: 1867
WTPModulesResource(TranslatorResourceImpl).doSave(OutputStream, Map) line: 192
WTPModulesResource(ResourceImpl).save(OutputStream, Map<?,?>) line: 1475
WTPModulesResource(ResourceImpl).save(Map<?,?>) line: 1044
WTPModulesResource(ReferencedXMIResourceImpl).save(Map) line: 377
WTPModulesResource(TranslatorResourceImpl).save(Map) line: 167
ModuleStructuralModel(EditModel).primSaveResource(Resource) line: 1303
ModuleStructuralModel(EditModel).saveResource(Resource) line: 1334
ModuleStructuralModel(EditModel).primSave(IProgressMonitor) line: 1269
EditModel$1.run(IProgressMonitor) line: 373
Workspace.run(ICoreRunnable, ISchedulingRule, int, IProgressMonitor) line: 2289
Workspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor) line: 2316
ModuleStructuralModel.runSaveOperation(IWorkspaceRunnable, IProgressMonitor) line: 310
ModuleStructuralModel(EditModel).save(IProgressMonitor, Object) line: 376
ModuleStructuralModel.saveIfNecessary(IProgressMonitor, Object) line: 392
StructureEdit.saveIfNecessary(IProgressMonitor) line: 397
WebProjectConfiguratorDelegate(AbstractProjectConfiguratorDelegate).configureDeployedName(IProject, String) line: 189
{code}
But I dont see *JEEDeployableFactory#clearCache* being called. Btw. I dont see J2EEDeployableFactory listening to resource change. Here are the listeners that I see registered:
* org.eclipse.emf.common.notify.impl.AdapterImpl@21197771
* org.eclipse.wst.common.internal.emfworkbench.integration.EditModel$ResourceAdapter@6bc55154
* org.eclipse.wst.common.internal.emfworkbench.WorkbenchResourceHelper$FileAdapter@3543d4e1
* EMF2DOMAdapterImpl(#document,WTPModulesResource), org.eclipse.wst.common.componentcore.internal.resources.VirtualComponent$ResourceAdapter@2e185af0
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM2
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26161) Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26161?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-26161:
---------------------------------------
One test suite was green, the other yellow with 5 test failures ("widget was disposed"). Similar random failures can be seen elsewhere, so I assume that's not a problem of the particular mac slave.
I changed the job to use mac instead of mac_xhyve. [~nickboldt] please let me know if you want me to change it back or if you see more issues in the future.
> Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26161
> URL: https://issues.jboss.org/browse/JBIDE-26161
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: qa
> Affects Versions: 4.9.0.AM1
> Reporter: Ondrej Dockal
> Assignee: Martin Malina
> Fix For: 4.9.0.AM2
>
>
> Take a look and update/repair Mac os machines used in our infra, especially zamek and check out the others:
> * domek
> * bigmek
> * dev-platform-mac1
> * dev-platform-mac2
> Make dev-platform-macX machines capable to run cdk
> * add them to mac_xhyve label
> Should not be dev-platform-macX upgraded to High Sierra?
> cc: [~nickboldt] [~mmalina]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26161) Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26161?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-26161:
---------------------------------------
So, even after fixing the settings.xml file it still failed. Then I realized I probably need to delete the local maven repo as well - the html-file-disguised-as-xml was already there. So I did that and now it seems to be running. It should take around 17 minutes, so I will check back later.
Meanwhile, I updated bigmek and zamek to latest OS. Domek is not done yet - there are tests running ATM.
> Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26161
> URL: https://issues.jboss.org/browse/JBIDE-26161
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: qa
> Affects Versions: 4.9.0.AM1
> Reporter: Ondrej Dockal
> Assignee: Martin Malina
> Fix For: 4.9.0.AM2
>
>
> Take a look and update/repair Mac os machines used in our infra, especially zamek and check out the others:
> * domek
> * bigmek
> * dev-platform-mac1
> * dev-platform-mac2
> Make dev-platform-macX machines capable to run cdk
> * add them to mac_xhyve label
> Should not be dev-platform-macX upgraded to High Sierra?
> cc: [~nickboldt] [~mmalina]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26161) Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26161?page=com.atlassian.jira.plugi... ]
Martin Malina edited comment on JBIDE-26161 at 8/3/18 8:59 AM:
---------------------------------------------------------------
So, even after fixing the settings.xml file it still failed. Then I realized I probably need to delete the local maven repo as well - the html-file-disguised-as-xml was already there. So I did that and now it seems to be running. It should take around 17 minutes, so I will check back later.
It's running here:
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
Meanwhile, I updated bigmek and zamek to latest OS. Domek is not done yet - there are tests running ATM.
was (Author: mmalina):
So, even after fixing the settings.xml file it still failed. Then I realized I probably need to delete the local maven repo as well - the html-file-disguised-as-xml was already there. So I did that and now it seems to be running. It should take around 17 minutes, so I will check back later.
Meanwhile, I updated bigmek and zamek to latest OS. Domek is not done yet - there are tests running ATM.
> Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26161
> URL: https://issues.jboss.org/browse/JBIDE-26161
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: qa
> Affects Versions: 4.9.0.AM1
> Reporter: Ondrej Dockal
> Assignee: Martin Malina
> Fix For: 4.9.0.AM2
>
>
> Take a look and update/repair Mac os machines used in our infra, especially zamek and check out the others:
> * domek
> * bigmek
> * dev-platform-mac1
> * dev-platform-mac2
> Make dev-platform-macX machines capable to run cdk
> * add them to mac_xhyve label
> Should not be dev-platform-macX upgraded to High Sierra?
> cc: [~nickboldt] [~mmalina]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26161) Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26161?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-26161:
---------------------------------------
I wanted to figure out what was the problem with the mac slaves so that Nick had to use mac_xhyve.
So I set the job to use dev-platform-mac-1 or 2. And I saw errors like these:
{code}
11:59:26 [ERROR] Invalid extension descriptor for org.eclipse.tycho:tycho-maven-plugin:1.2.0: error in opening zip file
11:59:26 java.util.zip.ZipException: error in opening zip file
{code}
It felt familiar, I thought I was dealing with something similar not that long ago, but couldn't find it. And then it hit me: It was a problem with wrong maven repo setup.
For example see this:
{code}
11:59:57 [WARNING] Could not validate integrity of download from https://maven.repository.redhat.com/org/jboss/tools/parent/4.9.0.AM1-SNAP...
{code}
If you look at the url, it will redirect you to this page:
https://access.redhat.com/maven-repository
The main issue here is that there was a repo defined with this url:
http://maven.repository.redhat.com/
Instead of:
http://maven.repository.redhat.com/ga
I fixed it for all the slaves by replacing the settings.xml files with this:
https://gitlab.mw.lab.eng.bos.redhat.com/dev-platform/mwqa-cloud-slaves/b...
{code}
$ for i in domek.tpb.lab.eng.brq.redhat.com dev-platform-mac2.mw.lab.eng.rdu2.redhat.com bigmek.tpb.lab.eng.brq.redhat.com zamek.tpb.lab.eng.brq.redhat.com dev-platform-mac1.mw.lab.eng.rdu2.redhat.com; do scp /Users/rasp/Downloads/settings.xml jbossqa@${i}:.m2/; done
{code}
> Update Mac OS machines (deps, os, java, maven, etc.) and verify its usability in jenkins environment
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26161
> URL: https://issues.jboss.org/browse/JBIDE-26161
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: qa
> Affects Versions: 4.9.0.AM1
> Reporter: Ondrej Dockal
> Assignee: Martin Malina
> Fix For: 4.9.0.AM2
>
>
> Take a look and update/repair Mac os machines used in our infra, especially zamek and check out the others:
> * domek
> * bigmek
> * dev-platform-mac1
> * dev-platform-mac2
> Make dev-platform-macX machines capable to run cdk
> * add them to mac_xhyve label
> Should not be dev-platform-macX upgraded to High Sierra?
> cc: [~nickboldt] [~mmalina]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-25736) deprecate features from JBoss Tools with low usage / low development
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25736?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-25736.
---------------------------------
Closing, components has been removed.
Verified in:
Red Hat Developer Studio
Version: 12.9.0.AM1
Build id: AM1-v20180802-0119-B3094
Build date: 20180802-0119
> deprecate features from JBoss Tools with low usage / low development
> --------------------------------------------------------------------
>
> Key: JBIDE-25736
> URL: https://issues.jboss.org/browse/JBIDE-25736
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: aerogear-hybrid, browsersim, build, cdi, forge, jsf, livereload, portal-gatein, seam2, webservices
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.5.3.Final
>
> Attachments: Screenshot 2018-03-02 14.51.03.png
>
>
> This issue is to consider *deprecating* the following parts of JBoss Tools. Suggest we mark them deprecated in feature.properties, and add/update connectors in Central to be similarly marked.
> * jbosstools-portlet
> * jbosstools-aerogear
> * jbosstools-browsersim
> * jbosstools-livereload
> * {color:red}-jbosstools-webservices-{color}
> * {color:red}-jbosstools-javaee-{color}
> * {color:red}-jbosstools-forge-{color}
> These projects could be *removed*, since they were deprecated some time ago:
> * jbosstools-freemarker
> * jbosstools-arquillian
> For supporting arguments, see this doc (RH only, sorry):
> https://docs.google.com/spreadsheets/d/1PTep1KGK2DVbmaWGwQOPhtbSsyROL_PY6...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26172) Application wizard: cannot create apps via templates on OpenShift online
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26172?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-26172.
---------------------------------
Closing. Its fixed. I was able to create application based on template on several OpenShift instances.
Verified in:
Red Hat Developer Studio
Version: 12.9.0.AM1
Build id: AM1-v20180802-0119-B3094
Build date: 20180802-0119
> Application wizard: cannot create apps via templates on OpenShift online
> ------------------------------------------------------------------------
>
> Key: JBIDE-26172
> URL: https://issues.jboss.org/browse/JBIDE-26172
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.6.0.Final
> Environment: OpenShift Online, OpenShift version 3.10.9
> !image-2018-07-05-16-30-38-168.png!
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Blocker
> Labels: application_wizard
> Fix For: 4.6.0.Final
>
> Attachments: image-2018-07-05-14-52-49-127.png, image-2018-07-05-16-30-38-168.png, openshift-online-nodejs-app-created.png
>
>
> steps:
> # ASSERT: have a connection to OpenShift Online (https://console.starter-us-west-1.openshift.com)
> # EXEC: launch application wizard via explorer ctx menu New > Application
> # EXEC: select a template (ex. nodejs-mongo-persistent), hit "Finish"
> Result:
> The wizard complains that the API version in the data for
> * route
> * image
> * build
> * apps
> does not match the expected API version v1.
> !image-2018-07-05-14-52-49-127.png!
> The services are create but other than that nothing is: neither bc, builds, rc, dc, is etc.
> There's no error in the Eclipse log.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26204) Pod Log, Port Forwarding: when using bogus oc, log console shows up empty & port forwarding isn't functioning
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26204?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-26204.
---------------------------------
Closing.
Behavior has changed: when you are trying to show Pod Log or Port Forwarding an error message is shown, that you do not have correct executable.
Verified in:
Red Hat Developer Studio
Version: 12.9.0.AM1
Build id: AM1-v20180802-0119-B3094
Build date: 20180802-0119
> Pod Log, Port Forwarding: when using bogus oc, log console shows up empty & port forwarding isn't functioning
> -------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26204
> URL: https://issues.jboss.org/browse/JBIDE-26204
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.6.0.Final
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.9.0.AM1
>
> Attachments: pod-log-console-empty.png, port-forwarding-stopped.png
>
>
> * Setup:
> *# ASSERT: use the code that in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1772] for JBIDE-25700
> *# ASSERT: make sure you have an app with a pod running in OpenShift
> *# EXEC: open OpenShift preferences and point it to an oc that is a bogus executable file (that you created ex. by doing "touch oc && chmod +x oc")
> * Port Log:
> *# EXEC: in OpenShift Explorer: select the pod and pick "Pod Log..."
> *# Result:
> The "Console" view shows up but nothing happens, there's no output.
> !pod-log-console-empty.png!
> * Port Forwarding:
> *# EXEC: in OpenShift Explorer: select the pod and pick "Port Forwarding..."
> *# ASSERT: Port Forwarding wizard shows up listing the forwardable ports, the "Status" column shows them "Stopped"
> *# EXEC: hit "Start All" button
> *# Result:
> Port forwarding is not started, the "Status" column for the ports stays "Stopped"
> !port-forwarding-stopped.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months