[JBoss JIRA] (ERT-711) setTabs method in Text widget is ignored when style includes SWT.SINGLE [EBZ#436085]
by Eric Williams (Jira)
[ https://issues.jboss.org/browse/ERT-711?page=com.atlassian.jira.plugin.sy... ]
Eric Williams reassigned ERT-711:
---------------------------------
Sprint: devex #162 February 2019
Assignee: Eric Williams
> setTabs method in Text widget is ignored when style includes SWT.SINGLE [EBZ#436085]
> ------------------------------------------------------------------------------------
>
> Key: ERT-711
> URL: https://issues.jboss.org/browse/ERT-711
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Platform
> Reporter: Friendly Jira Robot
> Assignee: Eric Williams
> Priority: Major
> Labels: 4.12, SWT, bzira
>
> Creating a text widget with the style flag set to SWT.SINGLE, means that the setTabs method or at least the setTabStops method it calls) is ignored.
>
> Text txtInput = new Text(inputHolder, SWT.SINGLE);
> txtInput.setTabs(4);
> txtInput.addTraverseListener(new TraverseListener() {
> //code to ignore traverses
> });
> results in tabs still being shown as equal to 8 spaces.
> This is coming from the "if ((style & SWT.SINGLE) != 0) return;" line in the setTabStops method of the gtk Text widget. In the win32 version of the widget there is no such check (and may explain the worksforme resolution of bug #34805)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (ERT-709) [GTK] Incorrect behaviour of tree rendering on GTK after removing paint listener [EBZ#294300]
by Eric Williams (Jira)
[ https://issues.jboss.org/browse/ERT-709?page=com.atlassian.jira.plugin.sy... ]
Eric Williams reassigned ERT-709:
---------------------------------
Sprint: devex #162 February 2019
Assignee: Eric Williams
> [GTK] Incorrect behaviour of tree rendering on GTK after removing paint listener [EBZ#294300]
> ---------------------------------------------------------------------------------------------
>
> Key: ERT-709
> URL: https://issues.jboss.org/browse/ERT-709
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Platform
> Reporter: Friendly Jira Robot
> Assignee: Eric Williams
> Priority: Major
> Labels: SWT, bzira
>
> If I'd like to add custom paint listener to my tree and than remove it, sometimes all text disappear. Actually, the problem is text foreground == white after removing paint listener.
> Looks like the problem with Tree.drawForeground field: while custom rendering appear, Tree could cache this variable and then use invalid value when there are no custom painters (drawForeground value doesn't clear).
> Following example reproduce my problem. You need to select the last one item in the tree, check "Enable custom painter" and then uncheck it -- all text will be white:
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.SelectionAdapter;
> import org.eclipse.swt.events.SelectionEvent;
> import org.eclipse.swt.graphics.Color;
> import org.eclipse.swt.graphics.GC;
> import org.eclipse.swt.graphics.Image;
> import org.eclipse.swt.graphics.Rectangle;
> import org.eclipse.swt.graphics.TextLayout;
> import org.eclipse.swt.layout.GridData;
> import org.eclipse.swt.layout.GridLayout;
> import org.eclipse.swt.widgets.Button;
> import org.eclipse.swt.widgets.Display;
> import org.eclipse.swt.widgets.Event;
> import org.eclipse.swt.widgets.Listener;
> import org.eclipse.swt.widgets.Shell;
> import org.eclipse.swt.widgets.Tree;
> import org.eclipse.swt.widgets.TreeItem;
> public class TreePainter implements Listener {
> private Tree tree;
> private TextLayout textLayout;
> TreePainter(Tree tree) {
> this.tree = tree;
> }
> public void setListeners(boolean add) {
> if (add) {
> tree.addListener(SWT.EraseItem, this);
> tree.addListener(SWT.PaintItem, this);
> } else {
> tree.removeListener(SWT.EraseItem, this);
> tree.removeListener(SWT.PaintItem, this);
> }
> redraw();
> }
> @Override
> public void handleEvent(Event event) {
> switch (event.type) {
> case SWT.PaintItem:
> paint(event);
> break;
> case SWT.EraseItem:
> erase(event);
> break;
> }
> }
> private void erase(Event event) {
> event.detail &= ~(SWT.BACKGROUND | SWT.FOREGROUND | SWT.SELECTED | SWT.HOT);
> }
> private void paint(Event event) {
> TreeItem item = (TreeItem) event.item;
> GC gc = event.gc;
> // remember colors to restore the GC later
> Color oldForeground = gc.getForeground();
> Color oldBackground = gc.getBackground();
> int index = event.index;
> Color foreground = item.getForeground(index);
> if (foreground != null) {
> gc.setForeground(foreground);
> }
> Color background = item.getBackground(index);
> if (background != null) {
> gc.setBackground(background);
> }
> if ((event.detail & SWT.SELECTED) != 0) {
> gc.fillRectangle(item.getBounds(index));
> }
> Image image = item.getImage(index);
> if (image != null) {
> Rectangle imageBounds = item.getImageBounds(index);
> if (imageBounds != null) {
> Rectangle bounds = image.getBounds();
> // center the image in the given space
> int x = imageBounds.x
> + Math.max(0, (imageBounds.width - bounds.width) / 2);
> int y = imageBounds.y
> + Math.max(0, (imageBounds.height - bounds.height) / 2);
> gc.drawImage(image, x, y);
> }
> }
> Rectangle textBounds = item.getTextBounds(index);
> if (textBounds != null) {
> TextLayout layout = getTextLayout();
> layout.setText(item.getText(index));
> layout.setFont(item.getFont(index));
> Rectangle layoutBounds = layout.getBounds();
> int x = textBounds.x;
> int avg = (textBounds.height - layoutBounds.height) / 2;
> int y = textBounds.y + Math.max(0, avg);
> layout.draw(gc, x, y);
> }
> gc.setForeground(oldForeground);
> gc.setBackground(oldBackground);
> }
> public void redraw() {
> Rectangle rect = tree.getClientArea();
> tree.redraw(rect.x, rect.y, rect.width, rect.height, true);
> }
> private TextLayout getTextLayout() {
> if (textLayout == null) {
> int orientation = tree.getStyle()
> & (SWT.LEFT_TO_RIGHT | SWT.RIGHT_TO_LEFT);
> textLayout = new TextLayout(tree.getDisplay());
> textLayout.setOrientation(orientation);
> } else {
> textLayout.setText("");
> }
> return textLayout;
> }
> public static void main(String[] args) {
> Display display = new Display();
> Shell shell = new Shell(display);
> shell.setBounds(10, 10, 800, 600);
> shell.setLayout(new GridLayout());
> final Tree tree = new Tree(shell, SWT.BORDER);
> tree.setLinesVisible(true);
> for (int i = 0; i < 5; i++) {
> TreeItem item = new TreeItem(tree, SWT.NONE);
> item.setText("item " + i);
> for (int j = 0; j < 5; j++) {
> TreeItem child = new TreeItem(item, SWT.NONE);
> child.setText("item " + i + "-" + j);
> }
> }
> tree.setLayoutData(new GridData(GridData.FILL_BOTH));
> final TreePainter painer = new TreePainter(tree);
> final Button button = new Button(shell, SWT.CHECK);
> button.setText("Enable custom painter");
> button.addSelectionListener(new SelectionAdapter() {
> @Override
> public void widgetSelected(SelectionEvent e) {
> painer.setListeners(button.getSelection());
> }
> });
> shell.open();
> while (!shell.isDisposed()) {
> if (!display.readAndDispatch())
> display.sleep();
> }
> display.dispose();
> }
> }
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (ERT-708) Orca's flat review mode can not be used [EBZ#543949]
by Eric Williams (Jira)
[ https://issues.jboss.org/browse/ERT-708?page=com.atlassian.jira.plugin.sy... ]
Eric Williams resolved ERT-708.
-------------------------------
Resolution: Done
> Orca's flat review mode can not be used [EBZ#543949]
> ----------------------------------------------------
>
> Key: ERT-708
> URL: https://issues.jboss.org/browse/ERT-708
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Platform
> Reporter: Friendly Jira Robot
> Assignee: Eric Williams
> Priority: Major
> Labels: SWT, bzira
>
> Recently I reported on the orca list a problem where every time I
> tried to use flat review mode, my machine was completely frozen.
> The problem has been fixed but now I can not use the flat review mode. According to Joanie, the person who corrected the problem, the cause is due to a bug in the eclipse.
> I am copying the text of the email I received because I believe it
> will give more details.
> ----------
> Hey again.
> I have good news and bad news. The good news is that I have fixed the
> desktop lockup, at least for me. The bad news is that until the Eclipse
> developers fix their bug, flat review will not work in impacted windows.
> Eclipse is giving an insane bounding box (x, y, width, height) for a
> panel which seems to be the child of the scroll pane in that dialog. I
> get, for example, (618552120, 32709, 618552176, 32709). I should be
> getting things like (598, 353, 720, 328). In theory one should be able
> to test this in Accerciser, but Eclipse seems to still have that bug
> where it takes 15 or so seconds (followed by a DBus timeout to become
> responsive). And that seems to make Accerciser very unhappy. At least on
> my machine.
> Because flat review is constructing a 2-dimensional collection of
> objects based on their bounding boxes, we need accurate (not to mention
> sane) bounding boxes.
> So the way the Eclipse developers can test this is to grab the latest
> Orca master and perform the steps to reproduce. This time the expected
> result is that Orca should present the window via flat review and the
> actual result is that it just presents the name of the window ("Eclipse
> Platform Launcher"). To see why, look in your friendly debug.out. Here's
> what I get for reading the current line:
> vvvvv CONSUME ATSPI_KEY_PRESSED_EVENT: 'KP_Up' (80) vvvvv
> [normal, non-concerning stuff goes here]
> 00:47:16 - INFO: Extents for [panel | ] are: (618552120, 32709,
> 618552176, 32709)
> 00:47:16 - INFO: [panel | ] seems to have bogus coordinates
> [normal, non-concerning stuff goes here]
> ^^^^^ CONSUME ATSPI_KEY_PRESSED_EVENT: 'KP_Up' (80) ^^^^^
> You can quickly find these strings by searching for "bogus coordinates"
> and then looking at the previous line.
> ----------
> The steps to reproduce this problem are:
> 1. Activate orca but you need to grab the latest from git.
> 2. Launch eclipse.
> 3. When eclipse ask for the workspace try to explore the screen using the flat review mode.
> Expected result:
> Orca should read the content of the screen according to the commands used.
> Actual result:
> Orca reads only Eclipse IDE Launcher.
> Important: If you use an old version of orca, probably yourmachine will freeze.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (ERT-711) setTabs method in Text widget is ignored when style includes SWT.SINGLE [EBZ#436085]
by Friendly Jira Robot (Jira)
Friendly Jira Robot created ERT-711:
---------------------------------------
Summary: setTabs method in Text widget is ignored when style includes SWT.SINGLE [EBZ#436085]
Key: ERT-711
URL: https://issues.jboss.org/browse/ERT-711
Project: Eclipse Release Train
Issue Type: Task
Components: Platform
Reporter: Friendly Jira Robot
Creating a text widget with the style flag set to SWT.SINGLE, means that the setTabs method or at least the setTabStops method it calls) is ignored.
Text txtInput = new Text(inputHolder, SWT.SINGLE);
txtInput.setTabs(4);
txtInput.addTraverseListener(new TraverseListener() {
//code to ignore traverses
});
results in tabs still being shown as equal to 8 spaces.
This is coming from the "if ((style & SWT.SINGLE) != 0) return;" line in the setTabStops method of the gtk Text widget. In the win32 version of the widget there is no such check (and may explain the worksforme resolution of bug #34805)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (JBDS-4735) Central projects Wizard sometimes fails to open
by Zbyněk Červinka (Jira)
[ https://issues.jboss.org/browse/JBDS-4735?page=com.atlassian.jira.plugin.... ]
Zbyněk Červinka commented on JBDS-4735:
---------------------------------------
Testing long time on following platforms, nothing found:
--------------------------------------------------------
Fedora 29, JDK8, OpenStack, AM1-v20190220-1130-B4104
OS X 10.13.6, JDK 11, localhost, AM1-v20190219-0850-B4091
> Central projects Wizard sometimes fails to open
> -----------------------------------------------
>
> Key: JBDS-4735
> URL: https://issues.jboss.org/browse/JBDS-4735
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: central
> Affects Versions: 12.9.0.GA
> Environment: manually Fedora 28, automation
> Reporter: Vojtech Prusa
> Assignee: Jeff MAURY
> Priority: Major
> Fix For: 12.11.0.AM1
>
> Attachments: central.tar.gz, image-2018-10-17-09-24-31-555.png, screenshot-1.png
>
>
> Sometimes central examples wizards fail to load and modal dialog is shown instead (screen attached).
> Nothing in Error log view.
> Restarting devstudio solves the issue.
> Adding screen and central tar of:
> devstudio-12.9.0.GA-v20180928-1629-B3448/workspaces/workspace/.metadata/.plugins/org.jboss.tools.central/central
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (JBDS-4735) Central projects Wizard sometimes fails to open
by Zbyněk Červinka (Jira)
[ https://issues.jboss.org/browse/JBDS-4735?page=com.atlassian.jira.plugin.... ]
Zbyněk Červinka updated JBDS-4735:
----------------------------------
Comment: was deleted
(was: Tested repeatedly on updated Fedora 28 with "devstudio-12.11.0.AM1-v20190220-0525-B4101", no issue found. All central project wizards always opens.)
> Central projects Wizard sometimes fails to open
> -----------------------------------------------
>
> Key: JBDS-4735
> URL: https://issues.jboss.org/browse/JBDS-4735
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: central
> Affects Versions: 12.9.0.GA
> Environment: manually Fedora 28, automation
> Reporter: Vojtech Prusa
> Assignee: Jeff MAURY
> Priority: Major
> Fix For: 12.11.0.AM1
>
> Attachments: central.tar.gz, image-2018-10-17-09-24-31-555.png, screenshot-1.png
>
>
> Sometimes central examples wizards fail to load and modal dialog is shown instead (screen attached).
> Nothing in Error log view.
> Restarting devstudio solves the issue.
> Adding screen and central tar of:
> devstudio-12.9.0.GA-v20180928-1629-B3448/workspaces/workspace/.metadata/.plugins/org.jboss.tools.central/central
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (JBDS-4735) Central projects Wizard sometimes fails to open
by Josef Kopriva (Jira)
[ https://issues.jboss.org/browse/JBDS-4735?page=com.atlassian.jira.plugin.... ]
Josef Kopriva commented on JBDS-4735:
-------------------------------------
I was able to reproduce this on F29, JDK11 and devstudio AM1-v20190220-0420-B4100.
> Central projects Wizard sometimes fails to open
> -----------------------------------------------
>
> Key: JBDS-4735
> URL: https://issues.jboss.org/browse/JBDS-4735
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: central
> Affects Versions: 12.9.0.GA
> Environment: manually Fedora 28, automation
> Reporter: Vojtech Prusa
> Assignee: Jeff MAURY
> Priority: Major
> Fix For: 12.11.0.AM1
>
> Attachments: central.tar.gz, image-2018-10-17-09-24-31-555.png, screenshot-1.png
>
>
> Sometimes central examples wizards fail to load and modal dialog is shown instead (screen attached).
> Nothing in Error log view.
> Restarting devstudio solves the issue.
> Adding screen and central tar of:
> devstudio-12.9.0.GA-v20180928-1629-B3448/workspaces/workspace/.metadata/.plugins/org.jboss.tools.central/central
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (JBDS-4735) Central projects Wizard sometimes fails to open
by Zbyněk Červinka (Jira)
[ https://issues.jboss.org/browse/JBDS-4735?page=com.atlassian.jira.plugin.... ]
Zbyněk Červinka commented on JBDS-4735:
---------------------------------------
Tested repeatedly on updated Fedora 28 with "devstudio-12.11.0.AM1-v20190220-0525-B4101", no issue found. All central project wizards always opens.
> Central projects Wizard sometimes fails to open
> -----------------------------------------------
>
> Key: JBDS-4735
> URL: https://issues.jboss.org/browse/JBDS-4735
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: central
> Affects Versions: 12.9.0.GA
> Environment: manually Fedora 28, automation
> Reporter: Vojtech Prusa
> Assignee: Jeff MAURY
> Priority: Major
> Fix For: 12.11.0.AM1
>
> Attachments: central.tar.gz, image-2018-10-17-09-24-31-555.png, screenshot-1.png
>
>
> Sometimes central examples wizards fail to load and modal dialog is shown instead (screen attached).
> Nothing in Error log view.
> Restarting devstudio solves the issue.
> Adding screen and central tar of:
> devstudio-12.9.0.GA-v20180928-1629-B3448/workspaces/workspace/.metadata/.plugins/org.jboss.tools.central/central
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (JBIDE-26468) Connection wizard: should help user to get the correct OpenShift server for openshift.io
by Josef Kopriva (Jira)
[ https://issues.jboss.org/browse/JBIDE-26468?page=com.atlassian.jira.plugi... ]
Josef Kopriva commented on JBIDE-26468:
---------------------------------------
[~adietish] I agree, we should add warning in connection wizard and decorator and inform user, that URL is incorrect and probably give user a hint, where he can find correct server address.
> Connection wizard: should help user to get the correct OpenShift server for openshift.io
> ----------------------------------------------------------------------------------------
>
> Key: JBIDE-26468
> URL: https://issues.jboss.org/browse/JBIDE-26468
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.Final
> Environment: Red Hat Developer Studio
> Version: 12.9.0.GA
> Build id: GA-v20180928-1629-B3448
> Build date: 20180928-1629
> Eclipse Platform
> Version: 4.9.0.v20180906-1121
> Build id: I20180906-0745
> Red Hat Developer Studio (Core Features) 12.9.0.v20180928-1629
> Red Hat Developer Studio (RPM Features) 12.9.0.v20180928-1629
> JBoss OpenShift 3 Tools 3.5.2.v20180928-1232
> JBoss OpenShift JavaScript Tools 3.5.2.v20180807-2303
> JBoss OpenShift.io Tools 3.5.2.v20180823-1255
> Red Hat Container Development Kit Support 3.5.2.v20180816-1351
> Reporter: Suzumura Keishi
> Priority: Major
> Labels: connection_wizard, openshift_io, ux
> Fix For: 4.11.x
>
> Attachments: openshift-io-user-settings.png, openshift-online-copy-login-command.png, test.png
>
>
> When creating "New Connection" in OpenShift Explorer, the following error appears.
> ---
> Invalid character: <" w
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
