[JBoss JIRA] (JBIDE-27119) Hover over Microprofile config property annotation does not work
by Martin Lippert (Jira)
[ https://issues.redhat.com/browse/JBIDE-27119?page=com.atlassian.jira.plug... ]
Martin Lippert commented on JBIDE-27119:
----------------------------------------
For the Spring Boot language server, we implemented an LSP4E-specific hover provider that can be registered as a hover provider in JDT.
This is the registration piece:
https://github.com/spring-projects/sts4/blob/master/eclipse-language-serv...
Here is the implementation of the hover provider:
https://github.com/spring-projects/sts4/blob/master/eclipse-language-serv...
Since JDT doesn't combine the results from multiple hover providers, we had to take care of this ourselves, so that the regular Java hover would still appear in combination with ours for positions in the code where both hover provider could provide something.
The additional requirement here is that you have to register your language server for the pre-defined Java source code content-type and make sure that it gets started when the Java editor opens.
Would be more than happy to refactor and move this code (we have the same for content-assist) into LSP4E. Let me know if this approach would work for you, too, and we can start to contribute the code.
> Hover over Microprofile config property annotation does not work
> ----------------------------------------------------------------
>
> Key: JBIDE-27119
> URL: https://issues.redhat.com/browse/JBIDE-27119
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: quarkus
> Affects Versions: 4.14.0.Final
> Reporter: Jeff MAURY
> Priority: Major
> Fix For: 4.15.x
>
>
> When hovering over a Microprofile ConfigProperty name attribute, an LSP Hover request should be sent to that the current value of the property should be displayed. It is not, probably because the LSP Hover mecanism is not invoked against the JDT source editor.
> To be checked with [~mickael_istria]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (JBIDE-27119) Hover over Microprofile config property annotation does not work
by Mickael Istria (Jira)
[ https://issues.redhat.com/browse/JBIDE-27119?page=com.atlassian.jira.plug... ]
Mickael Istria commented on JBIDE-27119:
----------------------------------------
I confirm. LSP4E provides extension for Generic Editor, not for JDT editor.
I'm aware that Spring Tool Suite uses LSP4E to extend the JDT editor. Maybe this code would be reusable and shareable, as a plugin in LSP4E? Maybe that's worth chatting with [~mlippert], to see if the solutions they built can work for JBoss Tools, and -if yes- try to orchestrate a migration of such code into LSP4E.
> Hover over Microprofile config property annotation does not work
> ----------------------------------------------------------------
>
> Key: JBIDE-27119
> URL: https://issues.redhat.com/browse/JBIDE-27119
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: quarkus
> Affects Versions: 4.14.0.Final
> Reporter: Jeff MAURY
> Priority: Major
> Fix For: 4.15.x
>
>
> When hovering over a Microprofile ConfigProperty name attribute, an LSP Hover request should be sent to that the current value of the property should be displayed. It is not, probably because the LSP Hover mecanism is not invoked against the JDT source editor.
> To be checked with [~mickael_istria]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (JBIDE-27119) Hover over Microprofile config property annotation does not work
by Jeff MAURY (Jira)
Jeff MAURY created JBIDE-27119:
----------------------------------
Summary: Hover over Microprofile config property annotation does not work
Key: JBIDE-27119
URL: https://issues.redhat.com/browse/JBIDE-27119
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: quarkus
Affects Versions: 4.14.0.Final
Reporter: Jeff MAURY
Fix For: 4.15.x
When hovering over a Microprofile ConfigProperty name attribute, an LSP Hover request should be sent to that the current value of the property should be displayed. It is not, probably because the LSP Hover mecanism is not invoked against the JDT source editor.
To be checked with [~mickael_istria]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years