[
https://issues.jboss.org/browse/JBIDE-11322?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-11322:
------------------------------------------
ok, thanks for the review. So I'll
* correct the error message to be more explicit "There's already a file at "
+ ssh2Home + " that prevents us from using it for ssh keys" -> ssh2Home +
" is a file instead of a directory. This prevent creation and usage of ssh
keys"
* do ssh2HomeFille.mkdirs() instead of ssh2HomeFille.mkdir()
I double checked where the ssh2-homedir is actually needed. The only place where it's
presence is assumed (all other usages check for it's presence implicitly by checking
if the public/private key may be read) is where the keys are actually created.
Error creating a new ssh key pair in case of new OpenShift Express
account and there is no /home/user/.ssh folder
-----------------------------------------------------------------------------------------------------------------
Key: JBIDE-11322
URL:
https://issues.jboss.org/browse/JBIDE-11322
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.Beta2
Reporter: Daniel Azarov
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta2, 3.3.0.Beta3
Attachments: create-ssh-dir.patch, Domain Creation.png, Error creating a new ssh
key pair.png, New OpenShift Express Application.png
Test case:
EXECUTE:
1. Start JBDS
2. Open JBoss Central
3. Click "OpenShift Application" in part "Create Projects"
!New OpenShift Express Application.png!
4. Create new OpenShift Express account by pressing "here" link
5. Type username and password then press button "Next"
!Domain Creation.png!
6. Type Domain name and press button "New"
FAIL:
!Error creating a new ssh key pair.png!
and stack trace in log file:
{code}
com.openshift.express.client.OpenShiftException: Could not create new rsa key
at com.openshift.express.client.SSHKeyPair.create(SSHKeyPair.java:73)
at
org.jboss.tools.openshift.express.internal.ui.wizard.NewDomainWizardPageModel.createLibraKeyPair(NewDomainWizardPageModel.java:107)
at
org.jboss.tools.openshift.express.internal.ui.wizard.NewDomainWizardPage$1.widgetSelected(NewDomainWizardPage.java:164)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at
org.jboss.tools.openshift.express.internal.ui.wizard.ApplicationConfigurationWizardPage.onPageWillGetActivated(ApplicationConfigurationWizardPage.java:757)
at
org.jboss.tools.openshift.express.internal.ui.wizard.AbstractOpenShiftWizardPage$2.handlePageChanging(AbstractOpenShiftWizardPage.java:89)
at org.eclipse.jface.wizard.WizardDialog$10.run(WizardDialog.java:1602)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.wizard.WizardDialog.firePageChanging(WizardDialog.java:1600)
at org.eclipse.jface.wizard.WizardDialog.doPageChanging(WizardDialog.java:929)
at org.eclipse.jface.wizard.WizardDialog.showPage(WizardDialog.java:1218)
at org.eclipse.jface.wizard.WizardDialog.nextPressed(WizardDialog.java:915)
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:428)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at
org.jboss.tools.central.editors.GettingStartedPage$9.linkActivated(GettingStartedPage.java:619)
at
org.eclipse.ui.forms.widgets.AbstractHyperlink.handleActivate(AbstractHyperlink.java:233)
at org.eclipse.ui.forms.widgets.ImageHyperlink.handleActivate(ImageHyperlink.java:199)
at
org.eclipse.ui.forms.widgets.AbstractHyperlink.handleMouseUp(AbstractHyperlink.java:327)
at org.eclipse.ui.forms.widgets.AbstractHyperlink.access$2(AbstractHyperlink.java:311)
at
org.eclipse.ui.forms.widgets.AbstractHyperlink$4.handleEvent(AbstractHyperlink.java:125)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Caused by: java.io.FileNotFoundException: /home/daniel/.ssh/libra_id_rsa.pub (No such
file or directory)
at java.io.FileOutputStream.open(Native Method)
at java.io.FileOutputStream.<init>(FileOutputStream.java:209)
at java.io.FileOutputStream.<init>(FileOutputStream.java:99)
at com.jcraft.jsch.KeyPair.writePublicKey(KeyPair.java:144)
at com.openshift.express.client.SSHKeyPair.create(SSHKeyPair.java:69)
... 59 more
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira