[
https://issues.jboss.org/browse/JBIDE-15332?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-15332:
----------------------------------------
It does not seem safe to assume that all maven-download-plugin executions are for test and
all maven-dependency-plugin exectuins are for populating a bundle. Removing
<skip>${skipRequirements}</skip> from parent and moving it to relevant places
would be better.
As for usage of maven-dependency-plugin in test context, see
https://github.com/jbosstools/jbosstools-server/blob/master/as/tests/org....
why are skipRequirements controlling download of normal maven
dependencies ?
----------------------------------------------------------------------------
Key: JBIDE-15332
URL:
https://issues.jboss.org/browse/JBIDE-15332
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Mickael Istria
I stumbled on [~dgolovin]'s patch for livreload at
https://github.com/jbosstools/jbosstools-livereload/pull/54/files
This is not the first time i've seen skip having to be enabled for plain normal mvn
dependencies.
skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things
done via non-maven download mechanism.
Why is this applied to mvn dependency downloads ?
The culprit for needing this line is at:
https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
and a bugzilla (*not* jira?!) is referenced as the reason for this back in 2012:
https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b...
I understand why the explicit google download plugin (why is there two versions used
btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements
are using this for download ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira