[jbosstools-issues] [JBoss JIRA] (JBIDE-14311) org.jboss.tools.jst.jsp.outline.JSPPropertySourceAdapter.getAttributes() invokes PageProcessor.getAttributesAsMap with query == null as an argument

org.jboss.tools.jst.jsp.outline.JSPPropertySourceAdapter.getAttributes() invokes PageProcessor.getAttributesAsMap with query == null as an argument --------------------------------------------------------------------------------------------------------------------------------------------------- Key: JBIDE-14311 URL: https://issues.jboss.org/browse/JBIDE-14311 Project: Tools (JBoss Tools) Issue Type: Bug Components: jsp/jsf/xml/html source editing Affects Versions: 4.1.0.Alpha1 Reporter: Victor Rubezhny Assignee: Victor Rubezhny Fix For: 4.1.0.Beta1 When JSF page is not well-formed, the JSPPropertySourceAdapter.getAttributes() invokes PageProcessor.getAttributesAsMap with query == null as an argument which results in NullPointerException: {code} !ENTRY org.eclipse.e4.ui.workbench 4 0 2013-04-25 02:16:50.311 !MESSAGE An exception occurred while notifying part listeners !STACK 0 java.lang.NullPointerException at org.jboss.tools.jst.web.kb.PageProcessor.getAttributes(PageProcessor.java:244) at org.jboss.tools.jst.web.kb.PageProcessor.getAttributes(PageProcessor.java:240) at org.jboss.tools.jst.web.kb.PageProcessor.getAttributesAsMap(PageProcessor.java:270) at org.jboss.tools.jst.jsp.outline.JSPPropertySourceAdapter.getAttributes(JSPPropertySourceAdapter.java:661) at org.jboss.tools.jst.jsp.outline.JSPPropertySourceAdapter.createPropertyDescriptors(JSPPropertySourceAdapter.java:199) at org.jboss.tools.jst.jsp.outline.JSPPropertySourceAdapter.getPropertyDescriptors(JSPPropertySourceAdapter.java:170) at org.eclipse.ui.views.properties.PropertySheetEntry.computeMergedPropertyDescriptors(PropertySheetEntry.java:167) at org.eclipse.ui.views.properties.PropertySheetEntry.refreshChildEntries(PropertySheetEntry.java:530) at org.eclipse.ui.views.properties.PropertySheetEntry.setValues(PropertySheetEntry.java:760) at org.eclipse.ui.views.properties.PropertySheetViewer.setInput(PropertySheetViewer.java:973) at org.eclipse.ui.views.properties.PropertySheetPage.selectionChanged(PropertySheetPage.java:510) at org.eclipse.wst.sse.ui.internal.properties.ConfigurablePropertySheetPage.selectionChanged(ConfigurablePropertySheetPage.java:174) at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyPostSelectionListeners(SelectionService.java:173) at org.eclipse.ui.internal.e4.compatibility.SelectionService.updateSelection(SelectionService.java:120) at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partActivated(WorkbenchPage.java:178) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl$2.run(PartServiceImpl.java:192) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartActivated(PartServiceImpl.java:190) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:588) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:548) at org.eclipse.e4.ui.internal.workbench.swt.AbstractPartRenderer.activate(AbstractPartRenderer.java:104) at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer$1.handleEvent(ContributedPartRenderer.java:59) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1392) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1416) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1397) at org.eclipse.swt.widgets.Shell.setActiveControl(Shell.java:1669) at org.eclipse.swt.widgets.Control.sendFocusEvent(Control.java:3791) at org.eclipse.swt.widgets.Control.gtk_event_after(Control.java:3069) at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:2081) at org.eclipse.swt.widgets.Control.windowProc(Control.java:5344) at org.eclipse.swt.widgets.Display.windowProc(Display.java:4544) at org.eclipse.swt.internal.gtk.OS._gtk_widget_grab_focus(Native Method) at org.eclipse.swt.internal.gtk.OS.gtk_widget_grab_focus(OS.java:13658) at org.eclipse.swt.widgets.Control.forceFocus(Control.java:2400) at org.eclipse.swt.widgets.Composite.forceFocus(Composite.java:546) at org.eclipse.swt.widgets.Control.forceFocus(Control.java:2393) at org.eclipse.swt.widgets.Control.setFocus(Control.java:4203) at org.eclipse.swt.widgets.Composite.setFocus(Composite.java:1404) at org.eclipse.ui.texteditor.AbstractTextEditor.setFocus(AbstractTextEditor.java:6213) at org.eclipse.ui.texteditor.StatusTextEditor.setFocus(StatusTextEditor.java:122) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.delegateSetFocus(CompatibilityPart.java:190) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56) at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:231) at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:237) at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:208) at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:107) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.focusGui(PartRenderingEngine.java:759) at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer$2.setFocus(ContributedPartRenderer.java:102) at org.eclipse.swt.custom.CTabItem.setFocus(CTabItem.java:329) at org.eclipse.swt.custom.CTabFolder.setFocus(CTabFolder.java:2509) at org.eclipse.swt.widgets.Control.fixFocus(Control.java:204) at org.eclipse.swt.widgets.Control.setVisible(Control.java:4683) at org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.java:3049) at org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.java:3057) at org.eclipse.swt.custom.CTabFolder.onMouse(CTabFolder.java:1753) at org.eclipse.swt.custom.CTabFolder$1.handleEvent(CTabFolder.java:278) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1392) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3717) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3338) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1108) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:992) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:137) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:600) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} The issue could be easily reproduced using JBDS 7.0.0.Alpha1/JBT 4.1.0.Alpha1. Steps to reproduce: 1. EXECUTE: Start JBDS/JBT. Create JSF 2.1 Project using KickStart template. 2. EXECUTE: Select <project name>/WebContent/pages folder 3. EXECUTE: Create an empty file in selected folder, name it as 'test.jsp' 4. ASSERT: JBoss Tools JSP editor should be opened for the file 'test.jsp' 5. ASSERT: Properties View is opened. 6. EXECUTE: Set text cursor into the editor and press Enter for a few times due to enter a number of empty lines into the file 7. EXECUTE: Select the 'test.jsp' file in Package Explorer, Perform Right-Mouse-Click on the file and select 'Open With->JSP Editor' context menu item 8. ASSERT: WTP JSP Editor should be opened for the file 'test.jsp' 9. EXECUTE: Select 'Window->Show View->Other...->General->Error Log'. Clear the error log view in not empty. 10. EXECUTE: Set text cursor into some text line in currently opened editor for the 'test.jsp' file and immediately switch into another editor for the same file. 11. EXECUTE: Repeat #10 few times pointing the text cursor into a different line each time. 12. ASSERT: Error messages start appear in Error Log (In my environment it takes 3-5 switches between the editors before the error messages start to appear).