[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6439) Refactor and partially reimpement VpeDnD class
[
https://jira.jboss.org/browse/JBIDE-6439?page=com.atlassian.jira.plugin.s...
]
Maxim Areshkau commented on JBIDE-6439:
---------------------------------------
By the way, now we store inner drag info into static field of InnerDragBuffer class and
use empty string as data in drag object. It's not correct, we should put all info into
transfearable object. Refactor function VpeDnD.createTransferable.
Refactor and partially reimpement VpeDnD class
----------------------------------------------
Key: JBIDE-6439
URL: https://jira.jboss.org/browse/JBIDE-6439
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Visual Page Editor core
Reporter: Yahor Radtsevich
Assignee: Yahor Radtsevich
Fix For: 3.2.0.Beta
org.jboss.tools.vpe.dnd.VpeDnD class needs to be refactored and reimplemented for some
parts.
It has the following weak points:
1. 'sourceInnerDragInfo' variable is not always reflects actual state of the
'VpeDnD' objects. It is used to DnD elements inside VPE only, in other cases, e.g.
for external DnD it is ignored. It is error-prone and leads to many if-else structures.
2. 'selectionChanged' method has no interface and 'VpeDnD' class is
tightly coupled with 'VpeVisualDomBuilder' class.
3. The class uses VPE's own drop implementation, while it is also implemented in the
Outline View.
4. ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira