[
https://issues.jboss.org/browse/JBIDE-10220?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10220:
-----------------------------------------------
I have created the static instance for WhiteSettings. We have 12 implementations of
IFormLayoutData that in static declarations create FormData which needs WhiteSettings
instance, totally, in a static way, about 500 instances of WhiteSettings were created. Now
it will be one. It would involve great changes to avoid the static way of creating
FormData instances, and it may affect performance to create/dispose them on each request,
I think that in this case it is better to keep one set of resources for the session.
org.jboss.tools.common.model.ui has a lot of resorce leaks
----------------------------------------------------------
Key: JBIDE-10220
URL:
https://issues.jboss.org/browse/JBIDE-10220
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
1) TextEditorComponent has resorce leak problem -> it create Color, but does not
dispose it -> org.jboss.tools.common.model.ui.texteditors.TextEditorComponent line
186:
{code}
return (rgb != null) ? new Color(display, rgb) : null;
{code}
firstly I find this with TextEditorComponent... but org.jboss.tools.common.model.ui has a
lot of Color leaks - try to search "new Color(":
2) org.jboss.tools.common.model.ui.widgets.WhiteSettings
3) org.jboss.tools.common.model.ui.attribute.editor.ExtendedFieldEditor
- in these places Color created constantly, but never disposed.
in this plugin I've find a lot of commented "new Color(" - should be
deleted to avoid leaks after "just uncomment",
and there are places with "static Color" declarations - which at least looks
very "questionable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira