[jbosstools-issues] [JBoss JIRA] (JBIDE-8838) add source feature to JBT components; generate source plugins w/ Tycho
[
https://issues.jboss.org/browse/JBIDE-8838?page=com.atlassian.jira.plugin...
]
Mickael Istria commented on JBIDE-8838:
---------------------------------------
If we have to use a sourceTemplateFeature, how is that better/worse
than just creating the source feature itself?
It is just a folder to create which acts like a switch. It can be empty, the Tycho plugin
will generate the right source feature. Then there is no more maintainance or update of
source features necessary.
Note that using .feature.source instead of .source.feature may break
something downstream, at least as far parsing patterns of
"feature.feature.group" goes.
I thought about it. This change, if name cannot be overriden, would require to fix some
featureIds or patterns in downstream aggregators or mirrors. Do you think this would be a
blocking point?
Any way we can control the naming convention and keep using
.source.feature instead of .feature.source?
By reading at the Mojo code
(http://git.eclipse.org/c/tycho/org.eclipse.tycho.extras.git/tree/tycho-so...
), I would say no. But that could be contributed.
What makes more sense/cost less: adapting new patterns in downstream builds, or
contributing a "sourceFeatureName" option to this plugin. I estimate writing the
contribution to 15 minutes + half a day of serious negociations to get it integrated into
the master.
add source feature to JBT components; generate source plugins w/
Tycho
----------------------------------------------------------------------
Key: JBIDE-8838
URL: https://issues.jboss.org/browse/JBIDE-8838
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 3.3.0.M2
Reporter: Nick Boldt
Assignee: Mickael Istria
Priority: Critical
Fix For: 3.3.0.Beta1
As per example done in https://bugs.eclipse.org/bugs/show_bug.cgi?id=344515 and
http://wiki.eclipse.org/Minerva#Source, the rest of JBT needs source features/plugins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira