[jbosstools-issues] [JBoss JIRA] (JBIDE-25006) ITests profile is active by default

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Martin Malina updated JBIDE-25006: ---------------------------------- Description: The intention is that if you run a build of anything depending on the parent pom [1], by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. The parent pom sets <skipITests>true</skipITests> here: https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... And the ITests profile is activated if the skipITests property is not set at all: https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... {code} <activation> <property> <name>!skipITests</name> </property> </activation> {code} We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. Pavol suggests simply removing the activation clause for that profile. [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. But we should still fix this. Cc: [~psrna] was: The intention is that if you run a build of anything depending on the parent pom [1], by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. The parent pom sets <skipITests>true</skipITests> here: https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... And the ITests profile is activated if the skipITests property is not set at all: https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... {code} <activation> <property> <name>!skipITests</name> </property> </activation> {code} We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. Pavol suggests simply removing the activation clause for that profile. [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. But we should still fix this. -- This message was sent by Atlassian JIRA (v7.2.3#72005)