[jbosstools-issues] [JBoss JIRA] (JBIDE-19757) Use jbosstools aggregate site instead of special webtools-site for WTP's AS server discovery
[
https://issues.jboss.org/browse/JBIDE-19757?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-19757:
------------------------------------
There's no need to change the URL inside WTP.
If we can't use a simple symlink to the JBT site (due to performance concerns), then
instead we continue to use a symlink to the webtools-site
(../../static/mars/development/updates/webtools/4.3.0.Alpha2).
IMHO, there's no reason to switch to using a composite site when a symlink is just as
good (better, in fact, because less metadata to read) and easier to change (one symlink to
delete/create vs. 2 composite*.xml files to edit).
So... when Beta1 is released, we can switch the symlink to point to the webtools Beta1
site & get some performance numbers.
The, we can switch the symlink to point at the JBT Beta1 site & get some performance
numbers.
If the result says we need to revert, we can do so. If not, we can move ahead w/ deleting
the webtools-site config from Github and from the child-sites Jenkins jobs.
Sound good?
Use jbosstools aggregate site instead of special webtools-site for
WTP's AS server discovery
--------------------------------------------------------------------------------------------
Key: JBIDE-19757
URL: https://issues.jboss.org/browse/JBIDE-19757
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: build, server
Reporter: Mickael Istria
Assignee: Nick Boldt
Fix For: 4.3.0.Beta1
With https://bugs.eclipse.org/bugs/show_bug.cgi?id=434185 , WTP Server Discovery
mechanism was granted a new strategy which allows to rely on regular p2 metadata instead
of a site.xml.
Support for this was already merged in server (
https://github.com/jbosstools/jbosstools-server/commit/2d3cc63a9b67753ad9...
)
In order to save an artifact to manage (the webtools p2 repository), we could use this
mechanism and consider contributing directly the main JBT URL to webtools discovery.
However, server discovery also keeps older strategies and since we produce invalid
site.xml files, this is currently failing
{code}
!ENTRY org.eclipse.equinox.p2.updatesite 2 0 2015-05-04 09:40:58.088
!MESSAGE Error parsing feature stream. The unique identifier or the version is null or
empty for the State: "Category": unique identifier="minimal-json"
version="null".
{code}
because we are lines specifying bundle but no version in the site.xml.
[~nickboldt] What are those site.xml useful for? Could we get rid of them?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)