[
https://issues.jboss.org/browse/JBIDE-25273?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-25273 at 10/20/17 9:57 AM:
--------------------------------------------------------------------
The problem here is not a parsing issue. The tooling displays the correct value and units
for the resource that's being edited. It's the resource that's being edited,
that's differs:
The user operation above edits the *replication controller*. The web-ui does exactly that,
it is changing the replication controller.
Our tooling is changing the *deployment config*. It only falls back to the replication
controller if there's no deployment config.
for the above to reflect the correct value/unit I would have to edit the deployment
config. If I do that things are displayed correctly.
[~jeffmaury] thoughts? Which one is correct? Us or them?
btw. there's another problem with the code: the resource loading is done in the
handler whereas it should be done in a background job.
was (Author: adietish):
The problem here is not a parsing issue. The tooling displays the correct value and units
for the resource that's being edited. It's the resource that's being edited,
that's differs:
The user operation above edits the *replication controller*. The web-ui does exactly that,
it is changing the replication controller.
Our tooling is changing the *deployment config*. It only falls back to the replication
controller if there's no deployment config.
for the above to reflect the correct value/unit I would have to edit the deployment
config. If I do that things are displayed correctly.
[~jeffmaury] thoughts?
btw. there's another problem with the code: the resource loading is done in the
handler whereas it should be done in a background job.
Edit resource limits wizard: memory limit is erroneously shown as
"MiB" where it should be "bytes"
--------------------------------------------------------------------------------------------------
Key: JBIDE-25273
URL:
https://issues.jboss.org/browse/JBIDE-25273
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.1.AM3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Labels: edit_resource_limits_wizard, openshift_v3
Fix For: 4.5.1.Final
Attachments: edit-resource-limits-memory-limit-units.png
steps:
# ASSERT: make sure that you have an application with a service and replication
controller running in OpenShift (ex. create an app with the nodejs-mongo-persistent
template)
# ASSERT: make sure that your memory request limit is in bytes:
# EXEC: in OpenShift explorer, select your project
# EXEC: in "Properties" view, select "Deployments" tab and select
the last entry
# EXEC: pick "Edit" in the context menu to it
# ASSERT: replication controller is opened in the editor
# EXEC: search (Ctrl+F) "limits" and make sure it has an entry for memory
limits that has no unit
{code}
"resources" : {
"limits" : {"memory" : "512"},
},
{code}
# EXEC: in OpenShift Explorer: select the service for your application and pick
"Edit Resource Limits..." in the context menu
# ASSERT: Edit resource limits wizard shows up
Result:
Memory > Limits show *MiB* as unit
!edit-resource-limits-memory-limit-units.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)