[
https://issues.jboss.org/browse/JBIDE-19776?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-19776:
------------------------------------
Ah, so I added org.eclipse.tm.terminal plugin [4.0.0.201505051502], you told me to remove
it, and cross-project-issues says to add its containing feature in instead. Fun times. We
never included the tcf.te feature, only the new tm.terminal plugin.
So I guess my original PR was nearly valid and we DON'T need to remove server's
dependency on tm.terminal or replace it with wacky CDT dependencies?
{quote}The PR just shows a basic removal that looks perfectly fine. Could we please get a
p2diff ? {quote}
Did you mean my first PR, or this addendum [1] which adds a whole bunch of other stuff
instead? Please provide references when you say "the PR" so it's clear what
you mean -- I already provided p2diffs for the original PR, which shows no "basic
removal". Nor does the second commit in that PR, which is why I'm confused by
your statement.
[1]
https://github.com/nickboldt/jbosstools-target-platforms/commit/5300fdbb6...
Create and use Mars M7 target-platform
--------------------------------------
Key: JBIDE-19776
URL:
https://issues.jboss.org/browse/JBIDE-19776
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: target-platform
Reporter: Nick Boldt
Assignee: Mickael Istria
Priority: Blocker
Fix For: 4.3.0.Beta1
Attachments: jbdevstudio.p2diff.txt, jbdevstudio.p2diff.v3.txt,
jbosstools.p2diff.txt, jbosstools.p2diff.v3.txt
Mars M7 was released and contains interesting changes.
We need to start using it ASAP to leverage new functionalities and adapt to the most
important changes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)