[jbosstools-issues] [JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin

[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-15830 at 10/31/13 6:00 PM: -------------------------------------------------------------------- [~bleanhar] the above tests are unit tests, they're not run against any env. They just pass a client-id in and assert the useragent that the client's using. The code that's creating the useragent that's being used is the following: {code:title=UrlConnectionHttpClient} ... private static final String USERAGENT_FOR_KEYAUTH = "OpenShift"; ... private String setupUserAgent(String authKey, String authIV, String userAgent) { if (!StringUtils.isEmpty(authKey)) { if (userAgent == null) { userAgent = USERAGENT_FOR_KEYAUTH; } else if (!userAgent.startsWith(USERAGENT_FOR_KEYAUTH)) { userAgent = USERAGENT_FOR_KEYAUTH + '-' + userAgent; } } return userAgent; } {code} To my understanding this would always prepend "OpenShift" if it's not there already, given that the client's using an authkey. [~bleanhar] do you have any idea of what the jenkins-plugin's using as authkey? was (Author: adietish): [~bleanhar] the above tests are unit tests, they're not run against any env. They just pass a client-id in and assert the useragent that the client's using. The code that's creating the useragent that's being used is the following: {code:title=UrlConnectionHttpClient} ... private static final String USERAGENT_FOR_KEYAUTH = "OpenShift"; ... private String setupUserAgent(String authKey, String authIV, String userAgent) { if (!StringUtils.isEmpty(authKey)) { if (userAgent == null) { userAgent = USERAGENT_FOR_KEYAUTH; } else if (!userAgent.startsWith(USERAGENT_FOR_KEYAUTH)) { userAgent = USERAGENT_FOR_KEYAUTH + '-' + userAgent; } } return userAgent; } {code} To my understand this would always prepend "OpenShift" if it's not there already. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira