[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-854) our adapter uses different vm-install constant than other servers
[ http://jira.jboss.com/jira/browse/JBIDE-854?page=comments#action_12376329 ]
Max Andersen commented on JBIDE-854:
------------------------------------
1) lower case is much more readable than lower case in these kind of files (but not really
important I agree)
2) using the same names for the exactly same thing is though always a good thing IMO
our adapter uses different vm-install constant than other servers
-----------------------------------------------------------------
Key: JBIDE-854
URL: http://jira.jboss.com/jira/browse/JBIDE-854
Project: JBoss Tools
Issue Type: Bug
Components: JBossAS
Affects Versions: 2.0.0.Beta3
Reporter: Max Andersen
Assigned To: Rob Stryker
Priority: Minor
Just wondering why we use
public static String PROPERTY_VM_ID = "PROPERTY_VM_ID";
public static String PROPERTY_VM_TYPE_ID = "PROPERTY_VM_TYPE_ID";
when both tomcat and all generic servers uses
protected static final String PROP_VM_INSTALL_TYPE_ID = "vm-install-type-id";
protected static final String PROP_VM_INSTALL_ID = "vm-install-id";
?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira