[jbosstools-issues] [JBoss JIRA] Commented: (JBDS-637) use jbds builder instead of richfaces so product feature is set to 2.0 instead of 3.0

use jbds builder instead of richfaces so product feature is set to 2.0 instead of 3.0 ------------------------------------------------------------------------------------- Key: JBDS-637 URL: https://jira.jboss.org/jira/browse/JBDS-637 Project: Developer Studio Issue Type: Bug Components: Build Affects Versions: 2.0.0.GA Reporter: Denis Golovin Assignee: Nick Boldt Fix For: 2.0.0.GA (01:02:05 PM) dgolovin: nickboldt: so we need only add jbds builder in tag file and in product/build properties file into list of builders at the end. do not forget update richfaces/customTargets.xml (01:03:02 PM) dgolovin: nickboldt: code below should be removed to disable product feature build in richfaces builder (01:03:02 PM) dgolovin: <if> (01:03:02 PM) dgolovin: <isset property="enable-branding"/> (01:03:02 PM) dgolovin: <then> (01:03:02 PM) dgolovin: <ant antfile="${genericTargets}" target="${target}" > (01:03:02 PM) dgolovin: <property name="id" value="com.jboss.jbds.product.feature" /> (01:03:02 PM) dgolovin: <property name="customTargets" value="${builderDirectory}/customTargets.xml"/> (01:03:02 PM) dgolovin: <property name="type" value="feature"/> (01:03:02 PM) dgolovin: <property name="configs" value="*,*,*"/> (01:03:02 PM) dgolovin: </ant> (01:03:02 PM) dgolovin: </then> (01:03:02 PM) dgolovin: </if> (01:03:39 PM) dgolovin: and this one also should be removed (01:03:39 PM) dgolovin: <target name="assemble.com.jboss.jbds.product.feature"> (01:03:39 PM) dgolovin: <property name="archiveName" value="com.jboss.jbds.product.feature.zip"/> (01:03:39 PM) dgolovin: <ant antfile="${assembleScriptName}" dir="${buildDirectory}"/> (01:03:39 PM) dgolovin: </target> (01:03:50 PM) nickboldt: are you offering to do that? (01:04:02 PM) nickboldt: and should we branch and then worry about this after? (01:04:36 PM) nickboldt: I can do it, just figure if you've got the code open might as well commit the changes y'self :) (01:05:44 PM) dgolovin: lets try it on trunk first :) (01:06:05 PM) dgolovin: after branch :) (01:06:27 PM) dgolovin: at least we can rebranch it if everything is fine (01:07:38 PM) nickboldt: rebranch? or backport (01:07:54 PM) nickboldt: anyway, I'll branch now and worry about the new hudson builder (01:08:12 PM) nickboldt: jbds builder can wait (01:08:28 PM) dgolovin: yes, first things first (01:09:18 PM) dgolovin: including jbds builder in build also affects devstudio-installer (01:09:34 PM) dgolovin: <target name="prepare-transforms" depends="prepare-distribution-properties" unless="test.build"> (01:09:34 PM) dgolovin: <!-- It uses vetsionTag.richfaces because product feature build invoked inside richfaces build if branding is enabled --> (01:09:34 PM) dgolovin: <echo file="${distribution.dir}/eclipse/configuration/org.eclipse.equinox.simpleconfigurator/bundles.info" append="true">org.eclipse.equinox.transforms.hook,1.0.0.v20080610,file:plugins/org.eclipse.equinox.transforms.hook_1.0.0.v20080610.jar,4,false (01:09:34 PM) dgolovin: org.eclipse.equinox.transforms.xslt,1.0.0.v20080610,file:plugins/org.eclipse.equinox.transforms.xslt_1.0.0.v20080610.jar,1,true (01:09:34 PM) dgolovin: org.jboss.tools.equinox.transforms.xslt,${versionTags.richfaces}-${product.buildQualifier},file:plugins/org.jboss.tools.equinox.transforms.xslt_${versionTags.richfaces}-${product.buildQualifier}.jar,1,true (01:09:34 PM) dgolovin: com.jboss.jbds.product,${versionTags.richfaces}-${product.buildQualifier},file:plugins/com.jboss.jbds.product_${versionTags.richfaces}-${product.buildQualifier}.jar,4,false (01:09:34 PM) dgolovin: </echo> (01:09:34 PM) dgolovin: </target>