[jbosstools-issues] [JBoss JIRA] (JBIDE-10006) CLONE - Error when publishing project without git repo associated

CLONE - Error when publishing project without git repo associated ----------------------------------------------------------------- Key: JBIDE-10006 URL: https://issues.jboss.org/browse/JBIDE-10006 Project: Tools (JBoss Tools) Issue Type: Bug Components: JBossAS/Servers Affects Versions: 3.3.0.M4 Reporter: Max Rydahl Andersen Assignee: Rob Stryker Priority: Blocker Fix For: 3.3.0.M5 Attachments: JBIDE-10006.png, JBIDE-10006b.png try publishing project or deployable individual file without a git repo to an openshift server. publishng server doesn't check if project has a repository! java.lang.NullPointerException at org.eclipse.egit.core.IteratorService.createInitialIterator(IteratorService.java:39) at org.jboss.ide.eclipse.as.egit.core.EGitUtils.countCommitableChanges(EGitUtils.java:459) at org.jboss.tools.openshift.express.internal.core.behaviour.ExpressPublishMethod.publishModule(ExpressPublishMethod.java:50) at org.jboss.ide.eclipse.as.core.server.internal.DeployableServerBehavior.publishModule(DeployableServerBehavior.java:92) at org.jboss.ide.eclipse.as.core.server.internal.v7.DelegatingJBoss7ServerBehavior.publishModule(DelegatingJBoss7ServerBehavior.java:84) at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1046) at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1138) at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:955) at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774) at org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3027) at org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:341) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) this one is a blocker since if you drag a project to a server or use run as then it will keep giving NPE's and removal is broken too. Fixed in M4 by ignoring projects/units without a git repo. Looking at the logic of this then the dialog is shown for *every* module even if those modules are same git repo - that should be detected/handled somehow. And possibly resources without a git repo should be rejected. note, git repo's can still disappear in case users remove the git repo or git feature from project.