[jbosstools-issues] [JBoss JIRA] (JBIDE-24375) Remove PowerMock usage in tests

[ https://issues.jboss.org/browse/JBIDE-24375?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-24375: ------------------------------------------ [~aurelien.pupier] We had this very same discussion before merging this in. I agree in the fact that static accessors are a major problem when it comes to testability (and I personnally avoid static wherever possible because of this very reason and the drawbacks in inheritability). But then changing a class to be instantiatable for the sake of it's testability isn't nice either: no code should be changed to fulfil the needs of tests, tests should follow the code, not the other way round. But we all know how this is just a rule of thumb, not a rule set to stone. To me having those utils instantiatable isnt nice in terms of API either: at first state the class then looks as if it would hold state, which it isnt on purpose. I believe that using Powermock isnt the perfect solution but I dont see any other that's superior. -- This message was sent by Atlassian JIRA (v7.2.3#72005)