[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen commented on JBIDE-9021:
--------------------------------------------
Alexey,
i've been looking at the patch today and on first look it looks doable to include it
but got a few questions:
The code in addNatureToProjectWithValidationSupport seems way more complicated than it has
to be. shouldn't this just be "find highest index of either Java or WST builder,
add builder after that highest index" ? and why do we need to WST builder etc. in
here; shouldn't that be done by the validator nature or facet ?
p.s. thanks for adding tests for this ;)
p.p.s. i'm awaiting for tycho to download the updated dependencies for 3.2.x to verify
the test run while writing this - once that is ok and hear back from you then we should be
ok.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Max Rydahl Andersen
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira