[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-7935) sanitzie xml unmarshalling code in DeltaCloudClient
[
https://issues.jboss.org/browse/JBIDE-7935?page=com.atlassian.jira.plugin...
]
Andre Dietisheim updated JBIDE-7935:
------------------------------------
Description:
The code that unmarshals the XML responses from the deltacloud server is a mess. It is a
mix of classic parsing and JAXB. Furthermore it has a lot of unsafe access (no null
checks, no collection size checks etc.). It need serious refactoring.
Talking of design the code should be separated from the client and grouped along the
elements it unmarschals. This would allow us to switch communication to json or any other
encoded form if needed. The current implementation would now allow that.
was:The code that unmarshals the XML responses from the deltacloud server is a mess. It
is a mix of classic parsing and JAXB. It need serious refactoring.
sanitzie xml unmarshalling code in DeltaCloudClient
---------------------------------------------------
Key: JBIDE-7935
URL: https://issues.jboss.org/browse/JBIDE-7935
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: deltacloud
Affects Versions: 3.2.0.CR1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.2.x
The code that unmarshals the XML responses from the deltacloud server is a mess. It is a
mix of classic parsing and JAXB. Furthermore it has a lot of unsafe access (no null
checks, no collection size checks etc.). It need serious refactoring.
Talking of design the code should be separated from the client and grouped along the
elements it unmarschals. This would allow us to switch communication to json or any other
encoded form if needed. The current implementation would now allow that.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira