[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6346) New Struts/JSF Project Wizards slowdowns while typing the name for the project

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Rob Stryker commented on JBIDE-6346: ------------------------------------ Viacheslav, I'm going to go ahead and suggest that we do *not* use the patch above. It seems I misidentified server.getModules() as a long-running process when in fact it is very very quick. I was under the impression that was a call to getting child modules but it was not. It seems the only real delay here is server.getRootModules(m, null) call, but I no longer think this is necessary. Any error that would come from adding the module to a server should be discovered by serverWorkingCopy.canModifyModules(add, remove, monitor); And this call is already there. I think the proper fix is to *only* do the following: - try { - server.getRootModules(m, null); - } catch (CoreException ce) { - WebModelPlugin.getPluginLog().logError(ce); - return ce.getStatus().getMessage(); - } I believe no other changes are necessary. I also believe strongly this fix is safe because the call to canModifyModules(etc) should handle any errors. Adding the cache I did in the last patch is not required because servers.getModules() is actually a quick operation and my debugging was incorrect. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira