[jbosstools-issues] [JBoss JIRA] (JBIDE-24492) Details for custom template are not shown until "Next" is pressed.

[ https://issues.jboss.org/browse/JBIDE-24492?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-24492 at 10/17/18 4:53 AM: -------------------------------------------------------------------- [~jkopriva] Indeed, this is a regression of JBIDE-23473. JBIDE-23473 changed the code so that the template is only loaded when the page is up to get flipped over (*onPageWillGetDeactivated* doing the *model.loadAppSource*): {code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dR805} @Override protected void onPageWillGetDeactivated(Direction progress, PageChangingEvent event, DataBindingContext dbc) { if (model.isUseLocalAppSource()) { String filename = model.getLocalAppSourceFileName(); if (StringUtils.isNotBlank(filename)) { Job job = new Job(NLS.bind("Loading application source", filename)) { @Override protected IStatus run(IProgressMonitor monitor) { model.loadAppSource(monitor); return Status.OK_STATUS; } }; {code} Before JBIDE-23473 the template was being loaded upon keystroke (*handleValueChange* doing the *model.loadAppSource*): {code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dL825} @Override public void handleValueChange(ValueChangeEvent<? extends Object> event) { if (model.isUseLocalAppSource()) { if (StringUtils.isNotBlank(model.getLocalAppSourceFileName())) { Job job = new Job("Loading application source") { @Override protected IStatus run(IProgressMonitor monitor) { model.loadAppSource(monitor); return Status.OK_STATUS; } }; {code} was (Author: adietish): [~jkopriva] Indeed, this is a regression of JBIDE-23473. JBIDE-23473 changed the code so that the template is only loaded when the page is up to get flipped over: {code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dR805} @Override protected void onPageWillGetDeactivated(Direction progress, PageChangingEvent event, DataBindingContext dbc) { if (model.isUseLocalAppSource()) { String filename = model.getLocalAppSourceFileName(); if (StringUtils.isNotBlank(filename)) { Job job = new Job(NLS.bind("Loading application source", filename)) { @Override protected IStatus run(IProgressMonitor monitor) { model.loadAppSource(monitor); return Status.OK_STATUS; } }; {code} Before JBIDE-23473 the template was being loaded upon keystroke: {code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dL825} @Override public void handleValueChange(ValueChangeEvent<? extends Object> event) { if (model.isUseLocalAppSource()) { if (StringUtils.isNotBlank(model.getLocalAppSourceFileName())) { Job job = new Job("Loading application source") { @Override protected IStatus run(IProgressMonitor monitor) { model.loadAppSource(monitor); return Status.OK_STATUS; } }; {code} -- This message was sent by Atlassian Jira (v7.12.1#712002)