[jbosstools-issues] [JBoss JIRA] Assigned: (JBIDE-5520) Problem with associated sites in JBossTools-Update-3.1.0.v200912161943M-H182-RC1.zip

Problem with associated sites in JBossTools-Update-3.1.0.v200912161943M-H182-RC1.zip ------------------------------------------------------------------------------------ Key: JBIDE-5520 URL: https://jira.jboss.org/jira/browse/JBIDE-5520 Project: Tools (JBoss Tools) Issue Type: Bug Components: Build/Releng Affects Versions: 3.1.0.CR1 Reporter: Snjezana Peco Assignee: Snjezana Peco Priority: Critical Fix For: 3.1.0.CR2 The associated sites aren't created correctly in 3.1.0.RC1 If you try the following: - download JBossTools-Update-3.1.0.v200912161943M-H182-RC1.zip - replace content.jar with the attached content.jar in JBossTools-Update-3.1.0.v200912161943M-H182-RC1.zip - install fresh Eclipse Galileo EPP SR1 - start Eclipse with JDK6 - go to Help>Install New Software - add the changed JBossTools-Update-3.1.0.v200912161943M-H182-RC1.zip archive site - select all the JBoss Tools categories You will be able to install the complete JBoss Tools without adding the m2eclipse and BIRT 2.5 update site The problem is the following: The site.xml file within 3.1.0.v200912161943M-H182-RC1 is invalid. The URL http://download.jboss.org/jbosstools/updates/nightly/3.1.0.RC1/site.xml contains the associateSitesURL attribute http://download.jboss.org/jbosstools/updates/stable/associateSites.xml which contains the following sites : <associateSites> <associateSite label="Ganymede Update Site" url="http://download.eclipse.org/releases/ganymede/"/> <associateSite label="BIRT 2.3 Update Site" url="http://download.eclipse.org/birt/update-site/2.3/"/> </associateSites> which is incorrect. The correct associateSitesURL is http://download.jboss.org/jbosstools/updates/nightly/3.1.0.RC1/associateS... Attached is the correct site.xml site.xml has to be changed before generating p2 metadata because the Galileo P2 update engine ignores site.xml and uses content.jar which is invalid here. JBoss Tools 3.1.0.RC1 uses the org.eclipse.equinox.p2.metadata.generator.EclipseGenerator application to generate P2 metadata that is deprecated. I am not sure if it generates valid P2 metadata. The attached content.jar is created using the org.eclipse.equinox.p2.updatesite.UpdateSitePublisher application which creates p2 metadata correctly when using the attached site.xml. After fixing this issue, it will be possible to install JBoss Tools by adding JBoss Tools archive site or JBoss Tools web update site without adding any other site.