[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-4677) Properties aren't added properly from CSS editor if CSS class isn't competed with }

Properties aren't added properly from CSS editor if CSS class isn't competed with } ----------------------------------------------------------------------------------- Key: JBIDE-4677 URL: https://jira.jboss.org/jira/browse/JBIDE-4677 Project: Tools (JBoss Tools) Issue Type: Bug Components: Visual Page Editor core Affects Versions: 3.1.0.M3 Reporter: Yura Zhishko Assignee: Yura Zhishko Fix For: 3.1.0.M4 1) Create new CSS file 2) Print: cssclass{ .It's important do not complete class name with } 3) Set cursor before { or into any place in cssclass word 4) Open JBoss CSS Editor 5) Choose any property and print value using CSS editor, for example, in field Color print Red RESULT: Exception occurs and nothing happens in CSS file: java.lang.IllegalStateException: Program Error: modelStateChanging was less than zero at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.internalModelChanged(AbstractStructuredModel.java:872) at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.changedModel(AbstractStructuredModel.java:382) at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel$DocumentToModelNotifier.noChange(AbstractStructuredModel.java:140) at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument._fireEvent(BasicStructuredDocument.java:509) at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.fireStructuredDocumentEvent(BasicStructuredDocument.java:1168) at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.internalReplaceText(BasicStructuredDocument.java:1955) at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2414) at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2397) at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.access$2(JobSafeStructuredDocument.java:1) at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument$3.run(JobSafeStructuredDocument.java:137) at org.eclipse.wst.sse.ui.EditorExecutionContext.execute(EditorExecutionContext.java:147) at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.replaceText(JobSafeStructuredDocument.java:144) at org.eclipse.wst.css.core.internal.document.CSSModelUpdater.removeText(CSSModelUpdater.java:500) at org.eclipse.wst.css.core.internal.document.CSSModelUpdater.childRemoved(CSSModelUpdater.java:202) at org.eclipse.wst.css.core.internal.document.CSSModelUpdater.childReplaced(CSSModelUpdater.java:241) at org.eclipse.wst.css.core.internal.document.CSSModelImpl.childReplaced(CSSModelImpl.java:145) at org.eclipse.wst.css.core.internal.document.CSSNodeImpl.notifyChildReplaced(CSSNodeImpl.java:309) at org.eclipse.wst.css.core.internal.document.CSSNodeImpl.removeChild(CSSNodeImpl.java:364) at org.eclipse.wst.css.core.internal.document.CSSStyleDeclItemImpl.setCssValueText(CSSStyleDeclItemImpl.java:229) at org.eclipse.wst.css.core.internal.document.CSSStyleDeclarationImpl.setProperty(CSSStyleDeclarationImpl.java:267) at org.jboss.tools.jst.css.properties.CSSPropertyPage.handleChange(CSSPropertyPage.java:135) at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41) at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119) at org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65) at org.eclipse.core.databinding.observable.map.ObservableMap.fireMapChange(ObservableMap.java:86) at org.eclipse.core.databinding.observable.map.WritableMap.put(WritableMap.java:121) at org.eclipse.core.internal.databinding.observable.MapEntryObservableValue.doSetValue(MapEntryObservableValue.java:107) at org.eclipse.core.databinding.observable.value.AbstractObservableValue.setValue(AbstractObservableValue.java:55) at org.eclipse.core.databinding.UpdateValueStrategy.doSet(UpdateValueStrategy.java:486) at org.eclipse.core.databinding.ValueBinding$4.run(ValueBinding.java:191) at org.eclipse.core.databinding.observable.Realm$1.run(Realm.java:148) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.databinding.observable.Realm.safeRun(Realm.java:152) at org.eclipse.core.databinding.observable.Realm.exec(Realm.java:170) at org.eclipse.core.databinding.ValueBinding$3.run(ValueBinding.java:182) at org.eclipse.core.databinding.observable.Realm$1.run(Realm.java:148) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.databinding.observable.Realm.safeRun(Realm.java:152) at org.eclipse.core.databinding.observable.Realm.exec(Realm.java:170) at org.eclipse.core.databinding.ValueBinding.doUpdate(ValueBinding.java:145) at org.eclipse.core.databinding.ValueBinding.access$4(ValueBinding.java:134) at org.eclipse.core.databinding.ValueBinding$1.handleValueChange(ValueBinding.java:44) at org.eclipse.core.databinding.observable.value.ValueChangeEvent.dispatch(ValueChangeEvent.java:62) at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119) at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.fireValueChange(DecoratingObservableValue.java:55) at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.handleValueChange(DecoratingObservableValue.java:93) at org.eclipse.core.databinding.observable.value.DecoratingObservableValue$1.handleValueChange(DecoratingObservableValue.java:67) at org.eclipse.core.databinding.observable.value.ValueChangeEvent.dispatch(ValueChangeEvent.java:62) at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119) at org.eclipse.core.databinding.observable.value.AbstractObservableValue.fireValueChange(AbstractObservableValue.java:71) at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.notifyIfChanged(SimplePropertyObservableValue.java:120) at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.access$1(SimplePropertyObservableValue.java:112) at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue$2.run(SimplePropertyObservableValue.java:66) at org.eclipse.core.databinding.observable.Realm$1.run(Realm.java:148) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.databinding.observable.Realm.safeRun(Realm.java:152) at org.eclipse.core.databinding.observable.Realm.exec(Realm.java:170) at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue$1.handleEvent(SimplePropertyObservableValue.java:63) at org.eclipse.core.databinding.property.NativePropertyListener.fireChange(NativePropertyListener.java:63) at org.eclipse.jface.databinding.swt.WidgetValueProperty$WidgetListener.handleEvent(WidgetValueProperty.java:119) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1176) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1200) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1185) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1025) at org.jboss.tools.jst.jsp.outline.cssdialog.widgets.ImageCombo.textEvent(ImageCombo.java:1214) at org.jboss.tools.jst.jsp.outline.cssdialog.widgets.ImageCombo$1.handleEvent(ImageCombo.java:138) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1176) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3493) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3112) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514) at org.eclipse.equinox.launcher.Main.run(Main.java:1311) at org.eclipse.equinox.launcher.Main.main(Main.java:1287) To prevent this exception, I think, css class name should be automated completed with } if it isn't.