1:38 p.m.
[
https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi...
]
Snjezana Peco commented on JBIDE-11299:
---------------------------------------
JBoss Central requires the project examples.
org.jboss.tools.project.examples.feature, org.jboss.tools.maven.project.examples.feature
and the org.jboss.tools.central plugin have to be included in both, JBT and JBDS.
The com.jboss.jbds.project.examples plugin has to be included in JBDS.
The org.jboss.tools.community.project.examples plugin has to be included in JBT.
If a user installs the org.jboss.tools.central feature only, he won't have required
project examples plugins and quickstarts/wizards won't work correctly.
Currently, these features are defined in the following way:
com.jboss.jbds.product.feature
{code}
<includes id="org.eclipse.platform" version="0.0.0" />
<includes id="com.jboss.jbds.m2e.feature" version="0.0.0" />
<plugin id="com.jboss.jbds.product" download-size="0"
install-size="0" version="0.0.0" />
<plugin id="com.jboss.jbds.project.examples" download-size="0"
install-size="0" version="0.0.0" />
<plugin id="com.jboss.jbds.usage.branding" download-size="0"
install-size="0" version="0.0.0" unpack="false" />
<plugin id="com.jboss.jbds.central" download-size="0"
install-size="0" version="0.0.0" unpack="false" />
<!-- JBIDE-11299 - include JBT Central feature (and contained plugin) in JBDS Central
-->
<!-- <plugin id="org.jboss.tools.central" download-size="0"
install-size="0" version="0.0.0" unpack="false"/> -->
<includes id="org.jboss.tools.central.feature" version="0.0.0"
/>
{code}
org.jboss.tools.central.feature
{code}
<plugin id="org.jboss.tools.central" download-size="0"
install-size="0" version="0.0.0" unpack="false"/>
{code}
org.jboss.tools.community.central.feature
{code}
<!-- JBIDE-11299 - include Examples features when installing Central -->
<requires>
<import feature="org.jboss.tools.central.feature"
version="1.0.0.qualifier" match="greaterOrEqual"/>
<import feature="org.jboss.tools.project.examples.feature"
version="1.2.1.qualifier" match="greaterOrEqual"/>
<import feature="org.jboss.tools.community.project.examples.feature"
version="1.2.1.qualifier" match="greaterOrEqual"/>
<import feature="org.jboss.tools.maven.project.examples.feature"
version="1.3.0.qualifier" match="greaterOrEqual"/>
</requires>
<plugin id="org.jboss.tools.community.central" download-size="0"
install-size="0" version="0.0.0"/>
{code}
These definitions contain the following issues:
- the org.jboss.tools.community.central plugin isn't necessary anymore and needs to be
removed.
- the com.jboss.jbds.product.feature feature has to include/require the
org.jboss.tools.maven.project.examples plugin/feature.
- the com.jboss.jbds.product.feature feature includes the org.jboss.tools.central plugin
and doesn't have to include the org.jboss.tools.central.feature
After fixing these issues, the org.jboss.central.feature feature would have to be removed
from the update site.
The user would have to install the org.jboss.tools.community.central.feature feature that
includes all required plugins.
{quote}
Yes, and what I don't grok is why we don't have a com.jboss.jbds.central which
does this:
<imports id="org.jboss.tools.central.feature" version="0.0.0"
/>
<plugin id="com.jboss.jbds.central" download-size="0"
install-size="0" version="0.0.0" unpack="false" />
<plugin id="com.jboss.jbds.project.examples" download-size="0"
install-size="0" version="0.0.0" />
{quote}
The com.jboss.jbds.central.feature isn't necessary. All the required plugins in JBDS
can be added to the com.jboss.jbds.product.feature feature.
{quote}
Actually to be symmetric there should be features for those plugins but not sure why we
have that in community too.
{quote}
The org.jboss.tools.community.central.feature would be a new feature that includes JBoss
Central and all its required plugins/features in JBT.
Central should install Project Examples otherwise the Project
Examples area on Getting Started tab says "No Entries Found" instead of showing
JBoss Quickstarts
---------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-11299
URL: https://issues.jboss.org/browse/JBIDE-11299
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: central
Affects Versions: 3.3.0.Beta1
Reporter: Nick Boldt
Assignee: Snjezana Peco
Fix For: 3.3.0.Beta3
Attachments: eclipse372platform+JBTAbridged=ProjectExamplesFound.png,
IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png,
JBIDE11299.after.patch.png, JBIDE11299.patch2.txt
Steps to repro:
1. unpack eclipse-platform-3.7.2-linux-gtk-x86_64.tar.gz
2. install JBoss Tools 3.3.0.Beta1 (whole Abridged category) from
http://download.jboss.org/jbosstools/updates/development/indigo/
3. restart when prompted, and look at Central:
!eclipse372platform+JBTAbridged=ProjectExamplesFound.png!
Now, try again but only install Central feature (to save time, use JEE bundle):
1. unpack eclipse-jee-indigo-SR1-linux-gtk-x86_64.tar.gz
2. install ONLY JBoss Central 3.3.0.Beta1 from
http://download.jboss.org/jbosstools/updates/development/indigo/
3. restart when prompted, and look at Central:
!IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png!
4. If I then install these three features, the Quickstarts appear:
{code}
org.jboss.tools.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1
org.jboss.tools.community.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1
org.jboss.tools.maven.project.examples.feature_1.3.0.v20120307-0425-H80-Beta1
{code}
So... does this mean the central feature should include & depend on these three
features?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira