[jbosstools-issues] [JBoss JIRA] (JBIDE-10228) org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik with Image dispose
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------
Now, at start dialog creates 138 images, puts them to plugin image registry, reuses them
as needed by new combos created during work with the dialog, and at closing the dialog
removes them from the registry.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira