[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBDS-491:
---------------------------------
Looks like all we're doing to get the status icon is checking if the file exists.
<macrodef name="get.status">
<attribute name="file"/>
<attribute name="property"/>
<sequential>
<if>
<available file="@{file}"/>
<then><property name="@{property}"
value="OK"/></then>
<else><property name="@{property}"
value="FAIL"/></else>
</if>
</sequential>
</macrodef>
Sounds like we need a summary check -- if all the individual pieces are OK, set another
status code for "all.pieces.status" and have the ALL status checks be "if
file exists and all.pieces.status == OK, then OK. If any of the pieces FAIL
(all.pieces.status == FAIL) but ALL file exists, set a new, third status of
"MAYBE" ?
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL:
https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira