[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4669) Toggle hide/show for complex property type on diagram cause autolayout

[ https://jira.jboss.org/jira/browse/JBIDE-4669?page=com.atlassian.jira.plu... ] Vitali Yemialyanchyk commented on JBIDE-4669: --------------------------------------------- 1) Current implementation has a complex logic which doesn't work as expected in more complex cases, for example one more bug a) User collapse the complex property of some class - as result the referenced table become hidden; b) User collapse the same class from (a) - but referenced table stay visible; 2) I don't see a sense to support/bugfix this complex logic, I do not see reasonable use case for this logic; 3) The reasonable logic from my point of view - if the user collapse/expand item, only connection line become hidden in case if some target/source item invisible, if the user want to show/hide class or table he can perform this operation via popup menu in diagram view or in Outline, this logic should simplify the code and give a simple clear use case; 4) About autolayout. Autolayout should be performed only in 2 cases: a) First try to open the diagram - autolayout will arrange items; b) If the user select autolayout command for example from popup menu; Any other case is a wrong case for autolayout; 5) Only visible item could be selected (see JBIDE-4668); 6) All complex logic solutions required comments why and what is happened, diagram viewer has no comments at all, I will to write some explains in the code; JBIDE-4668 and JBIDE-4669 are related. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira