[jbosstools-issues] [JBoss JIRA] (JBIDE-23624) clean up skipTests / swtbot.tests.skip references in integration tests

clean up skipTests / swtbot.tests.skip references in integration tests ---------------------------------------------------------------------- Key: JBIDE-23624 URL: https://issues.jboss.org/browse/JBIDE-23624 Project: Tools (JBoss Tools) Issue Type: Bug Affects Versions: 4.4.2.Final Reporter: Nick Boldt Assignee: Rob Stryker Fix For: 4.4.3.AM1 Rob said: {quote} swtbot.test.skip is old and shouldnt exist anymore {quote} {code} $➔ find.sh . "pom.xml" swtbot.test.skip ** [1] ./tests/org.jboss.tools.easymport.ui.bot.test/pom.xml ** 14- <packaging>eclipse-test-plugin</packaging> 15- <properties> 16: <swtbot.test.skip>false</swtbot.test.skip> 17- <usage_reporting_enabled>false</usage_reporting_enabled> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore> {code} Andre said: {quote} this seems to make no sense at all. These are tests. Why would you want to skip them by default?{quote} {code} ** [1] ./tests/org.jboss.tools.ui.bot.ext.test/pom.xml ** 13- 14- <properties> 15: <skipTests>true</skipTests> 16- </properties> 17-</project> ** [2] ./tests/pom.xml ** 22- <junitExtensionsProperties>-Dreddeer.close.shells=${reddeer.close.shells} -Dreddeer.close.welcome.screen=${reddeer.close.welcome.screen} -Dreddeer.disable.maven.download.repo.index.on.startup=${reddeer.disable.maven.download.repo.index.on.startup}</junitExtensionsProperties> 23- <integrationTestsSystemProperties>-Dswt.bot.test.record.screencast=${swt.bot.test.record.screencast} -Dorg.eclipse.swtbot.screenshots.dir=${project.build.directory}/screenshots -Dusage_reporting_enabled=false -Dcom.atlassian.connector.eclipse.monitor.usage.first.time=false -Dcom.atlassian.connector.eclipse.monitor.usage.enabled=false ${junitExtensionsProperties}</integrationTestsSystemProperties> 24: <skipTests>true</skipTests> 25- <test.installPath.OSX></test.installPath.OSX> 26- <devstudio.repository>https://devstudio.redhat.com/10.0/snapshots/updat... {code} There are also three examples of hardcoding skipTests to false, for no obvious reason: {code} $➔ find.sh . "pom.xml" \<skipTests\>false ** [1] ./tests/org.jboss.ide.eclipse.as.ui.bot.test/pom.xml ** 19- --> 20- <properties> 21: <skipTests>false</skipTests> 22- <usage_reporting_enabled>false</usage_reporting_enabled> 23- <!-- Maven configuration --> ** [2] ./tests/org.jboss.tools.arquillian.ui.bot.test/pom.xml ** 14- <packaging>eclipse-test-plugin</packaging> 15- <properties> 16: <skipTests>false</skipTests> 17- <usage_reporting_enabled>false</usage_reporting_enabled> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore> ** [3] ./tests/org.jboss.tools.examples.ui.bot.test/pom.xml ** 30- <jbosstools.test.jboss-eap-7.x.url>http://download.eng.brq.redhat.com/r... 31- <surefire.timeout>18000</surefire.timeout> 32: <skipTests>false</skipTests> 33- <deployOnServer>true</deployOnServer> 34- </properties> {code}