[jbosstools-issues] [JBoss JIRA] (JBDS-2386) jbdevstudio.ini file contains duplicate jboss.discovery.directory.url entries
[
https://issues.jboss.org/browse/JBDS-2386?page=com.atlassian.jira.plugin....
]
Mickael Istria commented on JBDS-2386:
--------------------------------------
Nick already spotted that configuration of jboss.discovery.directory.url is done twice
(once in JBDS feature + once in product definition). Patch fix that by removing it from
product definition, since it's better to factorize it in JBDS feature (which is
included and installed as part of JBDS product).
For product: when installing product from installer, the following things happen:
* product is installed and generates a .ini: sets the -product
* JBDS product feature (com.jboss.jbds) is installed and its p2 touchpoints are processed:
https://svn.jboss.org/repos/devstudio/trunk/product/site/com.jboss.jbds.p... This p2.inf
also sets the value of -product too
addProgramArg(programArg:com.jboss.jbds.product.product)
So the operation is done twice. The should not be any product configuration in
com.jboss.jbds feature, but instead, most of product-specific conf should be in the
product definiton (and end into the .ini).
[~dgolovin] Do you have a clue?
jbdevstudio.ini file contains duplicate jboss.discovery.directory.url
entries
-----------------------------------------------------------------------------
Key: JBDS-2386
URL: https://issues.jboss.org/browse/JBDS-2386
Project: Developer Studio (JBoss Developer Studio)
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Program
Affects Versions: 6.0.0.CR1
Environment: Version: 6.0.0.CR1
Build id: CR1-v20121118-2035-B111
Build date: 20121118-2035
Reporter: Len DiMaggio
Assignee: Nick Boldt
Priority: Minor
Fix For: 6.0.0.GA
Attachments: JBDS2386-remove-dupe-entry.patch1.txt,
JBDS2386-remove-dupe-entry.patch2.txt
The file in CR1 contains:
cat studio/jbdevstudio.ini
-vm
/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/jre/bin/java
-product
com.jboss.jbds.product.product
-startup
plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
--launcher.library
plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
-product
com.jboss.jbds.product.product
-showsplash
platform\:/base/plugins/com.jboss.jbds.product
--launcher.XXMaxPermSize
256m
--launcher.defaultAction
openFile
-vmargs
-Dosgi.splashPath=platform:/base/plugins/com.jboss.jbds.product
-Djboss.discovery.directory.url=https://devstudio.jboss.com/updates/6.0-staging/devstudio-directory.xml
-Xms512m
-Xmx1024m
-Djboss.discovery.directory.url=https://devstudio.jboss.com/updates/6.0-staging/devstudio-directory.xml
-Dosgi.instance.area.default=(a)user.home/workspace
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira