[jbosstools-issues] [JBoss JIRA] (JBIDE-15766) openshift-java-client: don't refresh env variables on each addition/removal

openshift-java-client: don't refresh env variables on each addition/removal --------------------------------------------------------------------------- Key: JBIDE-15766 URL: https://issues.jboss.org/browse/JBIDE-15766 Project: Tools (JBoss Tools) Issue Type: Bug Components: openshift Affects Versions: 4.1.1.Beta1, 4.2.0.Alpha1 Reporter: Andre Dietisheim Assignee: Andre Dietisheim Fix For: 4.1.1.Beta1, 4.2.0.Alpha1 When adding/removing environment variables, the openshift-java-client would always request the backend for the full list. This should not be required and avoided {code:title=ApplicationResource#addEnvironmentVariable} EnvironmentVariableResourceDTO environmentVariableResourceDTO = new AddEnvironmentVariableRequest().execute(name, value); IEnvironmentVariable environmentVariable = new EnvironmentVariableResource(environmentVariableResourceDTO, this); updateEnvironmentVariables(); return environmentVariable; {code} {code:title=ApplicationResource#updateEnvironmentVariables} protected void updateEnvironmentVariables() throws OpenShiftException { if (environmentVariableByName == null) { environmentVariableByName = loadEnvironmentVariables(); } else { environmentVariableByName.clear(); environmentVariableByName.putAll(loadEnvironmentVariables()); } } {code}