[jbosstools-issues] [JBoss JIRA] (JBIDE-16025) AS7 rse deployment has unnecessary 3 second delay during publish

AS7 rse deployment has unnecessary 3 second delay during publish ---------------------------------------------------------------- Key: JBIDE-16025 URL: https://issues.jboss.org/browse/JBIDE-16025 Project: Tools (JBoss Tools) Issue Type: Bug Components: server Affects Versions: 4.1.1.CR1 Reporter: Rob Stryker Assignee: Rob Stryker Priority: Critical Labels: respin-a Fix For: 4.1.1.CR1 The block of code inside RSEPublishMethod attempts to stop and restart the deployment scanners on the remote server. The current implementation is only fit for AS < 7. There does not currently exist an implementation (in our code) for AS>=7. This block of code is entered, and attempts to ssh into the remote machine, and execute a twiddle command, to turn off (and restart) the scanners. It also delays for 3 seconds hoping that the change goes through. This code is questionable already for AS < 7, but for AS >= 7, it is only a wasted 3-second delay with no purpose at all. Deploy-only servers also suffer from this delay, and deploy-only servers have no such scanners to even be turned off. Since larger-scale refactors are not currently possible at this time, the best solution is to simply exit the block of code early if the target server is not < AS7.