]
Nick Boldt commented on JBIDE-25118:
------------------------------------
Working on a fix now. What about these types of NEEDS INSPECTION items? False positive?
Install some rpms and check something on disk locally? Other processing needed to verify?
* Desktop file sanity:
improve errata waiver check script - add waivers for
desktop-file-sanity, patches, IP v6
----------------------------------------------------------------------------------------
Key: JBIDE-25118
URL:
https://issues.jboss.org/browse/JBIDE-25118
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build, rpm
Reporter: Nick Boldt
Assignee: Nick Boldt
Labels: release
Fix For: 4.5.1.Final
{quote}
It sounds like we could add these check types to my script:
* desktop-file-sanity (always waive?)
* IP v6 (always waive using existing waiver details, eg.,
https://errata.devel.redhat.com/rpmdiff/show/182126?result_id=5028358
Yep, yep.
* patches (waive if %autopatch)
And if the only other complaints are "patch not applied" (I'm not sure if
this check may throw different kinds of error){quote}
So, the next time we have an errata with the above types of issues, I can update this
script [1] to add those use cases.
[1]
https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/errata...
cc: [~mat.booth]