]
Rob Stryker commented on JBIDE-21205:
-------------------------------------
The patches seem to work for me, but after fixing some NPE's, still seem to fail for
Lars. Unfortunately, Lars will need to debug it because I'm having some problems
setting up the environment for fuse.
Modify runtime detection to ensure a detector is only asked to
initialize runtime definitions it created
--------------------------------------------------------------------------------------------------------
Key: JBIDE-21205
URL:
https://issues.jboss.org/browse/JBIDE-21205
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime-detection
Affects Versions: 4.3.0.Beta2
Reporter: Rob Stryker
Assignee: Rob Stryker
Priority: Minor
Fix For: 4.4.0.Alpha1
See
https://issues.jboss.org/browse/JBIDE-21193 for some background.
A runtime detector is asked to initialize all RuntimeDefinition objects, not just ones it
created. While this "works" if you expect a detector to know all type-strings
that it creates RuntimeDefinition objects using, it is still less than optimal and the
workflow is a bit counter-intuitive.
Suggestion is to add a new constructor to RuntimeDefinition and add abstract method for
creating those definitions to AbstractRuntimeDetectorDelegate to instantiate these
definitions.
Care should be taken since this is all public API and used in Fuse, cdk, servertools, and
other locations. It may not be possible to compel consumers to use the new API at all, and
so the benefit may be zero.