[
https://jira.jboss.org/jira/browse/JBIDE-4824?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-4824:
---------------------------------------------
I had a try to inspect code for potential unsafe places - only
AbstractConsoleConfigurationPreferences from my point of view could be unsafe, so I had it
changed. I didn't find other unsafe code related with this issue and particularly
Hibernate reverse engineering editor code should work without problems with this change in
wtp.
This issue is still open cause related eclipse issues are opened.
adjust to proper usage of w3c dom and the changes in upcoming WTP
3.2
---------------------------------------------------------------------
Key: JBIDE-4824
URL:
https://jira.jboss.org/jira/browse/JBIDE-4824
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Hibernate
Affects Versions: 3.1.0.M4
Reporter: Max Rydahl Andersen
Assignee: Vitali Yemialyanchyk
Not sure how much this affects us but the following were posted to WTP-DEV mailing list:
"In an effort to become more compliant with the W3C DOM specification, we are
planning to make changes that may require action on your behalf. The current behavior of
the WTP implementation of org.w3c.dom.Element returns null for getAttribute(String) and
getAttributeNS(String) if the attribute value is not specified. After the change, calls to
these methods will return an empty string if the attribute value is not specified. This
change is required to comply with the interface, and will correct various
NullPointerExceptions when EMF is used with our DOM implementation and the EMF code is
undeniably correct.
What is required?
If your code was depending on the DOM returning null to indicate a missing attribute, the
code should be changed to hasAttribute(String) or hasAttributeNS(String) before obtaining
the value.
When will this change be implemented?
During Milestone 3 of WTP 3.2.
Where can I find more information?
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272378"
We had some code in th reveng.xml editing which I believe depended on this kind of
behavior. Best to adjust to the spec so we work on both versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira