Filter wizard/Database Collector should correctly identify catalog, schema, and tables
even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL:
https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Reporter: Michael Walker
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in the
fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be the
case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the incorrect
naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira