[
https://issues.jboss.org/browse/JBIDE-18771?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-18771:
---------------------------------------------
[~ibuziuk] this just reuses existing iphone 4 resources we got and setup the right
dimensions, correct ? (since still waiting for legal for approving the more realistic
skins, right?).
[~akazakov] it is considered a critical bug our browsersim simulator can't easily be
used to test a device with iphone 6 dimensions/settings. Thus I would say this passes the
critical test, and looking at the PR at first glance it looks like it is a trivial
change/addition or am I missing something ? (it does not change api's, just add a new
setup to already dynamic list does it not ?)
BrowserSim: Create new navigation bar and buttons for iphone 6 / 6+
skins
-------------------------------------------------------------------------
Key: JBIDE-18771
URL:
https://issues.jboss.org/browse/JBIDE-18771
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: browsersim, cordovasim
Affects Versions: 4.2.0.Final
Reporter: Ilya Buziuk
Assignee: Ilya Buziuk
Labels: new_and_noteworthy
Fix For: 4.2.1.Final, 4.3.0.Alpha1
Attachments: nav-mockup.png, sample.png
Navigation bar and buttons will be created from iphone 6 IOS 8 screenshots
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)