11:17 p.m.
Rob Stryker created JBIDE-12447:
-----------------------------------
Summary: Reorganization of 'runtimes' plugin
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 3.4.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.4.0.M1
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component, but
do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from the
runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-12447:
----------------------------------------
I think the plan is fine. Don't forget to consider tests too:
org.jboss.tools.runtime.test depends on a lot of bundles from all other modules. It should
be split and tests should be moved to each module.
We may also want to have a mock runtime detector to test the runtime detector framework by
itself, independently of another component.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 3.4.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.4.0.M1
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:55 p.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-12447:
-------------------------------------
It looks to me that the as-tester is split out into a swt-bot test, but that the seam test
is bundled in with the framework test, so yes, this needs to be split up.
I adjust the steps as follows:
Step 0 becomes split the test suite first, such that one test plugin can safely move to
astools, one can safely move to seam tools, and there is a framework test suite.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 3.4.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.4.0.M1
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-12447:
---------------------------------------------
don't disable nor clone the plugins, use svn mv to avoid trashing the commit history.
Enable these in the build locally, test that it builds/works/installs before committing.
Also need to move the plugins out of the runtime feature.xml and into the specific
components feature.xml.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 3.4.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.4.0.M1
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Nick Boldt edited comment on JBIDE-12447 at 8/23/12 3:15 PM:
-------------------------------------------------------------
+1. This will affect the chunking scheme for git migration (JBIDE-12475). If we do this,
we could move Seam into the Central/Maven catchall chunk, and eliminate one entire git
repo.
was (Author: nickboldt):
This will affect the chunking scheme for git migration. See JBIDE-12475 for proposed
approach and to suggest where runtime could be moved (perhaps into the Base chunk?)
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.M1
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Attachment: runtimes_pushdown.patch
suggested patch for approval
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.M1
Attachments: runtimes_pushdown.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Attachment: runtimes_pushdown.v2.patch
ignore first patch. was missing files (new tests)
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.M1
Attachments: runtimes_pushdown.patch, runtimes_pushdown.v2.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Attachment: runtimes_pushdown.v3.patch
Patch 3, with more files :|
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.M1
Attachments: runtimes_pushdown.patch, runtimes_pushdown.v2.patch,
runtimes_pushdown.v3.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Attachment: runtimes_pushdown.v4.patch
version four, removes some crud, reverses the unnecessary api change from Set to List
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.M1
Attachments: runtimes_pushdown.patch, runtimes_pushdown.v2.patch,
runtimes_pushdown.v3.patch, runtimes_pushdown.v4.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Attachment: runtimepatch.v5.patch
moves and copies now show as adds. This embiggens the patch.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha1
Attachments: runtimepatch.v5.patch, runtimes_pushdown.patch,
runtimes_pushdown.v2.patch, runtimes_pushdown.v3.patch, runtimes_pushdown.v4.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-12447:
---------------------------------------------
+1 for v5 patch after it includes the svn move's and deletes.
Major issues found in the mechanics of the plugin but that is issues also present before
the move.
Main issues found:
* there are getESBDetector() methods in the runtime core, something that should know
nothing about specific runtime detectors.
* inclusion of other types in EAP is done by explicitly looking up possibly non existing
specific runtime detectors instead of having the runtime core detector just ask the
specific ones if they are included inside the AS/EAP detectors.
* lots of internal code is public that should be internal.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha1
Attachments: runtimepatch.v5.patch, runtimes_pushdown.patch,
runtimes_pushdown.v2.patch, runtimes_pushdown.v3.patch, runtimes_pushdown.v4.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12447:
--------------------------------
Fix Version/s: 4.0.0.Alpha2
(was: 4.0.0.Alpha1)
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha2
Attachments: runtimepatch.v5.patch, runtimes_pushdown.patch,
runtimes_pushdown.v2.patch, runtimes_pushdown.v3.patch, runtimes_pushdown.v4.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:46 a.m.
[
https://issues.jboss.org/browse/JBIDE-12447?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-12447.
---------------------------------
Resolution: Done
i would say for the most part the re-org has been completed. anything else that needs to
be done shouldhave a specific jira opened against it.
Reorganization of 'runtimes' plugin
-----------------------------------
Key: JBIDE-12447
URL: https://issues.jboss.org/browse/JBIDE-12447
Project: Tools (JBoss Tools)
Issue Type: Task
Components: JBossAS/Servers, runtime detection, Seam 2
Affects Versions: 4.0.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha2
Attachments: runtimepatch.v5.patch, runtimes_pushdown.patch,
runtimes_pushdown.v2.patch, runtimes_pushdown.v3.patch, runtimes_pushdown.v4.patch
Runtimes plugin currently only has a handful of plugins (4), but sits at the top of the
dependency tree. It depends on astools, seam, and has soft dependencies (via services) to
project examples.
In order to move runtimes down the stack, and make it a low-level component which others
depend on, the following should be done:
1) disable the plugins org.jboss.tools.runtime.as.detector and
org.jboss.tools.runtime.seam.detector from the build
2) Clone org.jboss.tools.runtime.seam.detector (and its feature) into the seam component,
but do not enable in build
3) Clone org.jboss.tools.runtime.as.detector (and feature) into the astools component,
but do not enable in build
4) Without these two plugins and features, runtimes can safely be moved down the stack.
This will require the build team to put runtimes lower on the build train. This should not
affect anyone that CURRENTLY depends on runtimes, since it will still be available, only
sooner. This will allow MORE plugins to depend on runtimes.
5) Once runtimes (without it's as and seam detectors) is in the build and building
properly, then we can:
6) Enable the new plugin and feature in astools
7) enable the new plugin and feature in seam
8) Once the new plugins are alive and building, we can safely remove the old ones from
the runtimes svn tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4317
days inactive
4337
days old
jbosstools-issues@lists.jboss.org
12 comments
4 participants
participants (4)
-
Max Rydahl Andersen (JIRA) -
Mickael Istria (JIRA)
-
Nick Boldt (JIRA)
-
Rob Stryker (JIRA)